LinuxTV Patchwork [v2] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()

login
register
mail settings
Submitter Mao Wenan
Date March 11, 2019, 2:37 p.m.
Message ID <20190311143739.132064-1-maowenan@huawei.com>
Download mbox | patch
Permalink /patch/54994/
State Accepted
Delegated to: Hans Verkuil
Headers show

Comments

Dan Carpenter - March 11, 2019, 2:35 p.m.
Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter
Mao Wenan - March 11, 2019, 2:37 p.m.
There is no need to have the 'T *v' variable static
since new value always be assigned before use it.

Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 v1->v2: remove additional space character between resource_size_t and res_len. 
 drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Mao Wenan - March 15, 2019, 12:15 p.m.
Ping...
Thank you.

On 2019/3/11 22:35, Dan Carpenter wrote:
> Thanks!
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> regards,
> dan carpenter
> 
> 
>

Patch

diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
index 6098f43ac51b..93d6ea48915b 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
@@ -1881,7 +1881,7 @@  int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,
 	struct v4l2_subdev *sd = &vpfe_rsz->crop_resizer.subdev;
 	struct media_pad *pads = &vpfe_rsz->crop_resizer.pads[0];
 	struct media_entity *me = &sd->entity;
-	static resource_size_t  res_len;
+	resource_size_t res_len;
 	struct resource *res;
 	int ret;
 

Privacy Policy