LinuxTV Patchwork [GIT,PULL,FOR,v5.1] add buf_out_validate callback to vb2 + two fixes

login
register
mail settings
Submitter Hans Verkuil
Date Jan. 11, 2019, 1:32 p.m.
Message ID <b8c73d3c-5fbb-4c60-9637-6655fc3f2e79@xs4all.nl>
Download mbox
Permalink /patch/53868/
State Rejected
Delegated to: Hans Verkuil
Headers show

Pull-request

git://linuxtv.org/hverkuil/media_tree.git tags/br-buf_val

Comments

Hans Verkuil - Jan. 11, 2019, 1:32 p.m.
The first three patches add the buf_out_validate callback to vb2 so video
output devices can validate the v4l2_buffer struct (specifically, validating
the field).

This fixes a v4l2-compliance failure.

The last two patches fix a vim2m bug and fix a vivid compliance bug.

With this pull request all v4l2-compliance tests succeed for vivid and vim2m.

Regards,

	Hans

The following changes since commit 1e0d0a5fd38192f23304ea2fc2b531fea7c74247:

  media: s5p-mfc: fix incorrect bus assignment in virtual child device (2019-01-07 14:39:36 -0500)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-buf_val

for you to fetch changes up to 1e89980a8651f6cddbe20f4e02c958dbf2f33d08:

  vivid: do not implement VIDIOC_S_PARM for output streams (2019-01-11 13:25:47 +0100)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Hans Verkuil (5):
      vb2: add buf_out_validate callback
      vim2m: add buf_out_validate callback
      vivid: add buf_out_validate callback
      vim2m: the v4l2_m2m_buf_copy_data args were swapped
      vivid: do not implement VIDIOC_S_PARM for output streams

 drivers/media/common/videobuf2/videobuf2-core.c | 14 +++++++++++---
 drivers/media/platform/vim2m.c                  | 29 +++++++++++++++++------------
 drivers/media/platform/vivid/vivid-core.c       |  2 +-
 drivers/media/platform/vivid/vivid-vid-out.c    | 23 ++++++++++++++++-------
 include/media/videobuf2-core.h                  |  5 +++++
 5 files changed, 50 insertions(+), 23 deletions(-)
Hans Verkuil - Jan. 15, 2019, 2:26 p.m.
On 1/11/19 2:32 PM, Hans Verkuil wrote:
> The first three patches add the buf_out_validate callback to vb2 so video
> output devices can validate the v4l2_buffer struct (specifically, validating
> the field).
> 
> This fixes a v4l2-compliance failure.
> 
> The last two patches fix a vim2m bug and fix a vivid compliance bug.
> 
> With this pull request all v4l2-compliance tests succeed for vivid and vim2m.

I'm dropping this pull request for now. After additional testing I realized that
the first buf_out_validate patch isn't quite right. I need to work on that a bit
more.

I'll post a new pull request for the remaining two patches.

Regards,

	Hans

> 
> Regards,
> 
> 	Hans
> 
> The following changes since commit 1e0d0a5fd38192f23304ea2fc2b531fea7c74247:
> 
>   media: s5p-mfc: fix incorrect bus assignment in virtual child device (2019-01-07 14:39:36 -0500)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/hverkuil/media_tree.git tags/br-buf_val
> 
> for you to fetch changes up to 1e89980a8651f6cddbe20f4e02c958dbf2f33d08:
> 
>   vivid: do not implement VIDIOC_S_PARM for output streams (2019-01-11 13:25:47 +0100)
> 
> ----------------------------------------------------------------
> Tag branch
> 
> ----------------------------------------------------------------
> Hans Verkuil (5):
>       vb2: add buf_out_validate callback
>       vim2m: add buf_out_validate callback
>       vivid: add buf_out_validate callback
>       vim2m: the v4l2_m2m_buf_copy_data args were swapped
>       vivid: do not implement VIDIOC_S_PARM for output streams
> 
>  drivers/media/common/videobuf2/videobuf2-core.c | 14 +++++++++++---
>  drivers/media/platform/vim2m.c                  | 29 +++++++++++++++++------------
>  drivers/media/platform/vivid/vivid-core.c       |  2 +-
>  drivers/media/platform/vivid/vivid-vid-out.c    | 23 ++++++++++++++++-------
>  include/media/videobuf2-core.h                  |  5 +++++
>  5 files changed, 50 insertions(+), 23 deletions(-)
>

Privacy Policy