LinuxTV Patchwork [GIT,FIXES,FOR,v5.0] v4l2-ioctl: Clear only per-plane reserved fields

login
register
mail settings
Submitter Hans Verkuil
Date Jan. 11, 2019, 8:31 a.m.
Message ID <7b7507b5-f4d1-d95b-b77b-bd7a8044a5ef@xs4all.nl>
Download mbox
Permalink /patch/53859/
State Accepted
Headers show

Pull-request

git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.0a2

Comments

Hans Verkuil - Jan. 11, 2019, 8:31 a.m.
Three fixes for a bug introduced in 5.0.

The last patch (Validate num_planes for debug messages) is also backported
to kernels >= 4.12 (the oldest kernel for which it applies cleanly).

Regards,

	Hans


The following changes since commit 1e0d0a5fd38192f23304ea2fc2b531fea7c74247:

  media: s5p-mfc: fix incorrect bus assignment in virtual child device (2019-01-07 14:39:36 -0500)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.0a2

for you to fetch changes up to 8015f0ce4a3c533acfbb3a71f0d6659fa4120778:

  v4l: ioctl: Validate num_planes for debug messages (2019-01-11 09:17:40 +0100)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Sakari Ailus (2):
      v4l: ioctl: Validate num_planes before using it
      v4l: ioctl: Validate num_planes for debug messages

Thierry Reding (1):
      media: v4l2-ioctl: Clear only per-plane reserved fields

 drivers/media/v4l2-core/v4l2-ioctl.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)
Sakari Ailus - Jan. 11, 2019, 9:10 p.m.
Hi Hans,

On Fri, Jan 11, 2019 at 09:31:25AM +0100, Hans Verkuil wrote:
> Three fixes for a bug introduced in 5.0.
> 
> The last patch (Validate num_planes for debug messages) is also backported
> to kernels >= 4.12 (the oldest kernel for which it applies cleanly).

The surrounding lines of code have changed slightly over the years. The
older kernels still suffer from the same problem as far as I see, so the
backport is relevant down to 3.16 at least (but older kernels aren't
supported anyway so I didn't check further). The problem was likely
introduced by the big IOCTL handling patches long, long time ago. Huh.
Hans Verkuil - Jan. 12, 2019, 9:17 a.m.
On 1/11/19 10:10 PM, Sakari Ailus wrote:
> Hi Hans,
> 
> On Fri, Jan 11, 2019 at 09:31:25AM +0100, Hans Verkuil wrote:
>> Three fixes for a bug introduced in 5.0.
>>
>> The last patch (Validate num_planes for debug messages) is also backported
>> to kernels >= 4.12 (the oldest kernel for which it applies cleanly).
> 
> The surrounding lines of code have changed slightly over the years. The
> older kernels still suffer from the same problem as far as I see, so the
> backport is relevant down to 3.16 at least (but older kernels aren't
> supported anyway so I didn't check further). The problem was likely
> introduced by the big IOCTL handling patches long, long time ago. Huh.
> 

I didn't plan on backporting this to older kernels. You have to be root
to enable this debugging, so it is not security bug.

Regards,

	Hans

Privacy Policy