LinuxTV Patchwork dma-buf: balance refcount inbalance

login
register
mail settings
Submitter Jerome Glisse
Date Dec. 6, 2018, 4:18 p.m.
Message ID <20181206161840.6578-1-jglisse@redhat.com>
Download mbox | patch
Permalink /patch/53348/
State Not Applicable
Headers show

Comments

Jerome Glisse - Dec. 6, 2018, 4:18 p.m.
From: Jérôme Glisse <jglisse@redhat.com>

The debugfs take reference on fence without dropping them.

Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: linux-media@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linaro-mm-sig@lists.linaro.org
Cc: Stéphane Marchesin <marcheu@chromium.org>
Cc: stable@vger.kernel.org
---
 drivers/dma-buf/dma-buf.c | 1 +
 1 file changed, 1 insertion(+)
Christian König - Dec. 6, 2018, 6:28 p.m.
Am 06.12.18 um 17:18 schrieb jglisse@redhat.com:
> From: Jérôme Glisse <jglisse@redhat.com>

>

> The debugfs take reference on fence without dropping them.

>

> Signed-off-by: Jérôme Glisse <jglisse@redhat.com>

> Cc: Christian König <christian.koenig@amd.com>

> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>

> Cc: Sumit Semwal <sumit.semwal@linaro.org>

> Cc: linux-media@vger.kernel.org

> Cc: dri-devel@lists.freedesktop.org

> Cc: linaro-mm-sig@lists.linaro.org

> Cc: Stéphane Marchesin <marcheu@chromium.org>

> Cc: stable@vger.kernel.org


Reviewed-by: Christian König <christian.koenig@amd.com>


> ---

>   drivers/dma-buf/dma-buf.c | 1 +

>   1 file changed, 1 insertion(+)

>

> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c

> index 13884474d158..69842145c223 100644

> --- a/drivers/dma-buf/dma-buf.c

> +++ b/drivers/dma-buf/dma-buf.c

> @@ -1069,6 +1069,7 @@ static int dma_buf_debug_show(struct seq_file *s, void *unused)

>   				   fence->ops->get_driver_name(fence),

>   				   fence->ops->get_timeline_name(fence),

>   				   dma_fence_is_signaled(fence) ? "" : "un");

> +			dma_fence_put(fence);

>   		}

>   		rcu_read_unlock();

>

Patch

diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index 13884474d158..69842145c223 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -1069,6 +1069,7 @@  static int dma_buf_debug_show(struct seq_file *s, void *unused)
 				   fence->ops->get_driver_name(fence),
 				   fence->ops->get_timeline_name(fence),
 				   dma_fence_is_signaled(fence) ? "" : "un");
+			dma_fence_put(fence);
 		}
 		rcu_read_unlock();
 

Privacy Policy