LinuxTV Patchwork media: siano: Use kmemdup instead of duplicating its function

login
register
mail settings
Submitter Wen Yang
Date Dec. 6, 2018, 12:29 p.m.
Message ID <20181206122910.50908-1-wen.yang99@zte.com.cn>
Download mbox | patch
Permalink /patch/53345/
State Accepted
Headers show

Comments

Wen Yang - Dec. 6, 2018, 12:29 p.m.
kmemdup has implemented the function that kmalloc() + memcpy().
We prefer to kmemdup rather than code opened implementation.

This issue was detected with the help of coccinelle.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: Tomoki Sekiyama <tomoki.sekiyama@gmail.com>
CC: linux-media@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
 drivers/media/usb/siano/smsusb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch

diff --git a/drivers/media/usb/siano/smsusb.c b/drivers/media/usb/siano/smsusb.c
index be3634407f1f..2ffded08407b 100644
--- a/drivers/media/usb/siano/smsusb.c
+++ b/drivers/media/usb/siano/smsusb.c
@@ -225,10 +225,9 @@  static int smsusb_sendrequest(void *context, void *buffer, size_t size)
 		return -ENOENT;
 	}
 
-	phdr = kmalloc(size, GFP_KERNEL);
+	phdr = kmemdup(buffer, size, GFP_KERNEL);
 	if (!phdr)
 		return -ENOMEM;
-	memcpy(phdr, buffer, size);
 
 	pr_debug("sending %s(%d) size: %d\n",
 		  smscore_translate_msg(phdr->msg_type), phdr->msg_type,

Privacy Policy