LinuxTV Patchwork [v2,1/2] media: lmedm04: Add missing usb_free_urb to free interrupt urb.

login
register
mail settings
Submitter Malcolm Priestley
Date Dec. 5, 2018, 7:11 p.m.
Message ID <17b98f82-c383-0adf-3430-dda449b4eee5@gmail.com>
Download mbox | patch
Permalink /patch/53338/
State Accepted
Delegated to: Sean Young
Headers show

Comments

Malcolm Priestley - Dec. 5, 2018, 7:11 p.m.
The interrupt urb is killed but never freed add the function

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
---
v2 avoiding stale pointer in usb_free_coherent as per sean

 drivers/media/usb/dvb-usb-v2/lmedm04.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2/lmedm04.c
index e9b149a26ce5..cba782261a6f 100644
--- a/drivers/media/usb/dvb-usb-v2/lmedm04.c
+++ b/drivers/media/usb/dvb-usb-v2/lmedm04.c
@@ -1229,6 +1229,7 @@  static void lme2510_exit(struct dvb_usb_device *d)
 		usb_kill_urb(st->lme_urb);
 		usb_free_coherent(d->udev, 128, st->buffer,
 				  st->lme_urb->transfer_dma);
+		usb_free_urb(st->lme_urb);
 		info("Interrupt Service Stopped");
 	}
 }

Privacy Policy