LinuxTV Patchwork [1/6] media: dt-bindings: media: sun6i: Separate H3 compatible from A31

login
register
mail settings
Submitter Chen-Yu Tsai
Date Nov. 30, 2018, 7:58 a.m.
Message ID <20181130075849.16941-2-wens@csie.org>
Download mbox | patch
Permalink /patch/53224/
State New
Delegated to: Hans Verkuil
Headers show

Comments

Chen-Yu Tsai - Nov. 30, 2018, 7:58 a.m.
The CSI controller found on the H3 (and H5) is a reduced version of the
one found on the A31. It only has 1 channel, instead of 4 channels for
time-multiplexed BT.656. Since the H3 is a reduced version, it cannot
"fallback" to a compatible that implements more features than it
supports.

Split out the H3 compatible as a separate entry, with no fallback.

Fixes: b7eadaa3a02a ("media: dt-bindings: media: sun6i: Add A31 and H3
		      compatibles")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 Documentation/devicetree/bindings/media/sun6i-csi.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Jagan Teki - Dec. 3, 2018, 9:41 a.m.
On Fri, Nov 30, 2018 at 1:29 PM Chen-Yu Tsai <wens@csie.org> wrote:
>
> The CSI controller found on the H3 (and H5) is a reduced version of the
> one found on the A31. It only has 1 channel, instead of 4 channels for
> time-multiplexed BT.656. Since the H3 is a reduced version, it cannot
> "fallback" to a compatible that implements more features than it
> supports.
>
> Split out the H3 compatible as a separate entry, with no fallback.
>
> Fixes: b7eadaa3a02a ("media: dt-bindings: media: sun6i: Add A31 and H3
>                       compatibles")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

"media" text appear two times on commit head.

Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
Chen-Yu Tsai - Dec. 3, 2018, 9:48 a.m.
On Mon, Dec 3, 2018 at 5:42 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Fri, Nov 30, 2018 at 1:29 PM Chen-Yu Tsai <wens@csie.org> wrote:
> >
> > The CSI controller found on the H3 (and H5) is a reduced version of the
> > one found on the A31. It only has 1 channel, instead of 4 channels for
> > time-multiplexed BT.656. Since the H3 is a reduced version, it cannot
> > "fallback" to a compatible that implements more features than it
> > supports.
> >
> > Split out the H3 compatible as a separate entry, with no fallback.
> >
> > Fixes: b7eadaa3a02a ("media: dt-bindings: media: sun6i: Add A31 and H3
> >                       compatibles")
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
> "media" text appear two times on commit head.

Just following what previous commits did. :)

> Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>

BTW, I know you've been trying to get CSI to work on the A64.
I have it working for the Bananapi-M64. The CSI SCLK needs to
be lowered to 300 MHz or the image gets corrupted.

ChenYu
Sakari Ailus - Dec. 4, 2018, 1:13 p.m.
Hi Chen-Yu,

On Mon, Dec 03, 2018 at 05:48:31PM +0800, Chen-Yu Tsai wrote:
> On Mon, Dec 3, 2018 at 5:42 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > On Fri, Nov 30, 2018 at 1:29 PM Chen-Yu Tsai <wens@csie.org> wrote:
> > >
> > > The CSI controller found on the H3 (and H5) is a reduced version of the
> > > one found on the A31. It only has 1 channel, instead of 4 channels for
> > > time-multiplexed BT.656. Since the H3 is a reduced version, it cannot
> > > "fallback" to a compatible that implements more features than it
> > > supports.
> > >
> > > Split out the H3 compatible as a separate entry, with no fallback.
> > >
> > > Fixes: b7eadaa3a02a ("media: dt-bindings: media: sun6i: Add A31 and H3
> > >                       compatibles")
> > > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >
> > "media" text appear two times on commit head.
> 
> Just following what previous commits did. :)

I understand Mauro has a  script prefixes everything going through the
media tree with "media: " unless it's already there. I'd drop the latter,
but perhaps elaborate a bit this is about CSI. Fine details... I think it's
fine as-is for now.

> 
> > Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
> 
> BTW, I know you've been trying to get CSI to work on the A64.
> I have it working for the Bananapi-M64. The CSI SCLK needs to
> be lowered to 300 MHz or the image gets corrupted.
> 
> ChenYu

Patch

diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt b/Documentation/devicetree/bindings/media/sun6i-csi.txt
index d4ab34f2240c..cc37cf7fd051 100644
--- a/Documentation/devicetree/bindings/media/sun6i-csi.txt
+++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt
@@ -6,7 +6,7 @@  Allwinner V3s SoC features a CSI module(CSI1) with parallel interface.
 Required properties:
   - compatible: value must be one of:
     * "allwinner,sun6i-a31-csi"
-    * "allwinner,sun8i-h3-csi", "allwinner,sun6i-a31-csi"
+    * "allwinner,sun8i-h3-csi"
     * "allwinner,sun8i-v3s-csi"
   - reg: base address and size of the memory-mapped region.
   - interrupts: interrupt associated to this IP

Privacy Policy