LinuxTV Patchwork dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor

login
register
mail settings
Submitter Manivannan Sadhasivam
Date Nov. 9, 2018, 7:56 a.m.
Message ID <20181109075643.17575-1-manivannan.sadhasivam@linaro.org>
Download mbox | patch
Permalink /patch/52861/
State Accepted
Delegated to: Sakari Ailus
Headers show

Comments

Manivannan Sadhasivam - Nov. 9, 2018, 7:56 a.m.
The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is
incorrectly mentioned as 0x78 in binding. Hence fix that.

Fixes: 09c716af36e6 [media] media: i2c/ov5645: add the device tree binding document
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 Documentation/devicetree/bindings/media/i2c/ov5645.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Todor Tomov - Nov. 9, 2018, 8:57 a.m.
Hi Mani,

On  9.11.2018 09:56, Manivannan Sadhasivam wrote:
> The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is
> incorrectly mentioned as 0x78 in binding. Hence fix that.

The seven bit i2c address of ov5645 is really 0x3c.
Thank you for finding this and sending the fix!

Best regards,
Todor

> 
> Fixes: 09c716af36e6 [media] media: i2c/ov5645: add the device tree binding document
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  Documentation/devicetree/bindings/media/i2c/ov5645.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> index fd7aec9f8e24..1a68ca5eb9a3 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> @@ -26,9 +26,9 @@ Example:
>  	&i2c1 {
>  		...
>  
> -		ov5645: ov5645@78 {
> +		ov5645: ov5645@3c {
>  			compatible = "ovti,ov5645";
> -			reg = <0x78>;
> +			reg = <0x3c>;
>  
>  			enable-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
>  			reset-gpios = <&gpio5 20 GPIO_ACTIVE_LOW>;
>
Rob Herring - Nov. 17, 2018, 4:41 p.m.
On Fri,  9 Nov 2018 13:26:43 +0530, Manivannan Sadhasivam wrote:
> The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is
> incorrectly mentioned as 0x78 in binding. Hence fix that.
> 
> Fixes: 09c716af36e6 [media] media: i2c/ov5645: add the device tree binding document
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  Documentation/devicetree/bindings/media/i2c/ov5645.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
index fd7aec9f8e24..1a68ca5eb9a3 100644
--- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt
+++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
@@ -26,9 +26,9 @@  Example:
 	&i2c1 {
 		...
 
-		ov5645: ov5645@78 {
+		ov5645: ov5645@3c {
 			compatible = "ovti,ov5645";
-			reg = <0x78>;
+			reg = <0x3c>;
 
 			enable-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
 			reset-gpios = <&gpio5 20 GPIO_ACTIVE_LOW>;

Privacy Policy