LinuxTV Patchwork dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope

login
register
mail settings
Submitter Martin Gansser
Date Oct. 10, 2018, 9:46 a.m.
Message ID <trinity-a67f3523-924e-4ec9-a042-860e5c893105-1539164789063@3c-app-gmx-bs80>
Download mbox | patch
Permalink /patch/52488/
State New
Headers show

Comments

Martin Gansser - Oct. 10, 2018, 9:46 a.m.
I have contacted Andreas.


On advice of Andreas, I have defined the IOCTL myself in the file dvbhdffdevice.h

this is the Patch: define_AUDIO_GET_PTS.patch
with this patch i get this warnings: [2]


when the patch only have this line:
+#define AUDIO_GET_PTS              _IOR('o', 19, __u64)
it compiles without warnings: [1]

[1] https://kojipkgs.fedoraproject.org//work/tasks/9241/30159241/build.log
[2] https://kojipkgs.fedoraproject.org//work/tasks/9649/30159649/build.log

what is correct ?

Thanks Martin
 

Gesendet: Dienstag, 09. Oktober 2018 um 11:31 Uhr
Von: "Klaus Schmidinger" <Klaus.Schmidinger@tvdr.de>
An: vdr@linuxtv.org
Betreff: Re: [vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope
On 10/9/18 10:27 AM, Martin Gansser wrote:
> Hello Klaus,
>
> will you provide a kernel> = 4.8 patch or will I need to contact the kernel developer for this?

Hello Martin,

please contact Andreas Regel <andreas.regel@gmx.de> about this.
He maintains the dvbhddevice plugin.

Greetings
Klaus
Klaus Schmidinger - Oct. 10, 2018, 9:50 a.m.
On 10/10/18 11:46 AM, Martin Gansser wrote:
> I have contacted Andreas.
> 
> 
> On advice of Andreas, I have defined the IOCTL myself in the file dvbhdffdevice.h
> 
> this is the Patch: define_AUDIO_GET_PTS.patch
> with this patch i get this warnings: [2]
> 
> --- vdr-2.4.0/PLUGINS/src/dvbhddevice/dvbhdffdevice.h.orig	2018-10-10 09:03:47.464147905 +0200
> +++ vdr-2.4.0/PLUGINS/src/dvbhddevice/dvbhdffdevice.h	2018-10-10 09:04:59.353350738 +0200
> @@ -4,6 +4,9 @@
>    * See the README file for copyright information and how to reach the author.
>    */
>   
> +#ifndef AUDIO_GET_PTS              _IOR('o', 19, __u64)

This should just be

#ifndef AUDIO_GET_PTS

Klaus
Martin Gansser - Oct. 10, 2018, 10:58 a.m.
Thanks for you help
Martin 

Gesendet: Mittwoch, 10. Oktober 2018 um 11:50 Uhr
Von: "Klaus Schmidinger" <Klaus.Schmidinger@tvdr.de>
An: vdr@linuxtv.org
Betreff: Re: [vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope
On 10/10/18 11:46 AM, Martin Gansser wrote:
> I have contacted Andreas.
>
>
> On advice of Andreas, I have defined the IOCTL myself in the file dvbhdffdevice.h
>
> this is the Patch: define_AUDIO_GET_PTS.patch
> with this patch i get this warnings: [2]
>
> --- vdr-2.4.0/PLUGINS/src/dvbhddevice/dvbhdffdevice.h.orig 2018-10-10 09:03:47.464147905 +0200
> +++ vdr-2.4.0/PLUGINS/src/dvbhddevice/dvbhdffdevice.h 2018-10-10 09:04:59.353350738 +0200
> @@ -4,6 +4,9 @@
> * See the README file for copyright information and how to reach the author.
> */
>
> +#ifndef AUDIO_GET_PTS _IOR('o', 19, __u64)

This should just be

#ifndef AUDIO_GET_PTS

Klaus

Patch

--- vdr-2.4.0/PLUGINS/src/dvbhddevice/dvbhdffdevice.h.orig	2018-10-10 09:03:47.464147905 +0200
+++ vdr-2.4.0/PLUGINS/src/dvbhddevice/dvbhdffdevice.h	2018-10-10 09:04:59.353350738 +0200
@@ -4,6 +4,9 @@ 
  * See the README file for copyright information and how to reach the author.
  */
 
+#ifndef AUDIO_GET_PTS              _IOR('o', 19, __u64)
+#define AUDIO_GET_PTS              _IOR('o', 19, __u64)
+#endif
 #ifndef __DVBHDFFDEVICE_H
 #define __DVBHDFFDEVICE_H


Privacy Policy