Message ID | 20170710151227.15616-1-d.scheller.oss@gmail.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1dUaMV-00065m-WA; Mon, 10 Jul 2017 15:12:36 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.89/mailfrontend-5) with esmtp id 1dUaMT-0005qz-7i; Mon, 10 Jul 2017 17:12:35 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753298AbdGJPMc (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 10 Jul 2017 11:12:32 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33846 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753173AbdGJPMb (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 10 Jul 2017 11:12:31 -0400 Received: by mail-wr0-f194.google.com with SMTP id k67so25523889wrc.1 for <linux-media@vger.kernel.org>; Mon, 10 Jul 2017 08:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=dgjx0lfuGQbNWts/goZnY/sjISLtBtI2d7rifoqs1fE=; b=nElvz0OIDsgcFL295VntcyX4QdX6LyImrbC+8uW+t8TswVWQn0lkslomdVqmvFrK78 rHO5sxJn+wB5f8mF9O2ahdKJzaYZGKMHLSlaInHvGgvDQ14LSN1mJpB1YEO7II3jSGU5 KJApOHfLmEFjowCy7feO+znKo3SFMW5KFuDKpfBlvgbWx6wxqgBvikROQcgxPERDo0u0 wYSjTu17RmrbCBFkhE8ksf7+qxw1/11Iw27guskMMFNx2l6TefMVxXdXXWHmt7R8DbtP B4yO2LmSSFKsHxY5TLsbx4UL0N10fW0pINCl/+jAxuLG/sM5CUsP/AL559k58sNq3l18 zSvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dgjx0lfuGQbNWts/goZnY/sjISLtBtI2d7rifoqs1fE=; b=PAnYpl3kWQ3vqyl8rgi0Ywfy791/oWTZmvs8aDRD06InXVJ75H6/B2vP30cHrR+qnF 27pfzUbT7tnvelAEWxC/cm+7XfDpDrFMiUkUS9YUa6B9Da4iA/8UAdLxGaWnOKe3TPtm mGHJt7cwC+sVSQEKaFKAuCt7Ge+0dw8iKJfRGHKU2YDJiGcAYLJTMmw2ciBktesr8i1Q CQmnWNho+aRrijUGIw6KM2G7iAOPbNn0jUQA8Rj21Qw8apfPZwaf5lku1O6yVwPePAj6 fFgZIRTl7Sr8A+TfJoIbPdoSeCD7Yd9rBuXxzOa371RHAFftrzkaed5/zOGe8u9nijMY 1B3g== X-Gm-Message-State: AIVw113mkrtXD/Fncy/EiSB4w6lxgkQTgmqUFcKhOA3mTRt9s3HDXFjE CVtnCOIdDfL12C8h X-Received: by 10.223.132.133 with SMTP id 5mr7530712wrg.132.1499699549906; Mon, 10 Jul 2017 08:12:29 -0700 (PDT) Received: from dvbdev.wuest.de (ip-37-24-178-151.hsi14.unitymediagroup.de. [37.24.178.151]) by smtp.gmail.com with ESMTPSA id g5sm9932541wmf.5.2017.07.10.08.12.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 10 Jul 2017 08:12:29 -0700 (PDT) From: Daniel Scheller <d.scheller.oss@gmail.com> To: linux-media@vger.kernel.org, mchehab@kernel.org, mchehab@s-opensource.com Cc: jasmin@anw.at, garsilva@embeddedor.com Subject: [PATCH] [media] ddbridge: constify i2c_algorithm structure Date: Mon, 10 Jul 2017 17:12:27 +0200 Message-Id: <20170710151227.15616-1-d.scheller.oss@gmail.com> X-Mailer: git-send-email 2.13.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.7.10.150615 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, NO_URI_HTTPS 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, URI_WITH_PATH_ONLY 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MULTIPLE_RCPTS_CC_X2 0, __NO_HTML_TAG_RAW 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NOT_IMG 0, __URI_NS , __URI_WITH_PATH 0, __YOUTUBE_RCVD 0' |
Commit Message
Daniel Scheller
July 10, 2017, 3:12 p.m. UTC
From: Daniel Scheller <d.scheller@gmx.net> Original patch and issue identified by Gustavo A. R. Silva <garsilva@embeddedor.com> via [1] using Coccinelle. While at it, even mark the struct static again since it isn't referenced anywhere else. [1] http://www.spinics.net/lists/linux-media/msg118221.html Cc: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: Daniel Scheller <d.scheller@gmx.net> --- drivers/media/pci/ddbridge/ddbridge-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Am Mon, 10 Jul 2017 17:12:27 +0200 schrieb Daniel Scheller <d.scheller.oss@gmail.com>: > From: Daniel Scheller <d.scheller@gmx.net> > > Original patch and issue identified by Gustavo A. R. Silva > <garsilva@embeddedor.com> via [1] using Coccinelle. While at it, even > mark the struct static again since it isn't referenced anywhere else. > > [1] http://www.spinics.net/lists/linux-media/msg118221.html > > Cc: Gustavo A. R. Silva <garsilva@embeddedor.com> > Signed-off-by: Daniel Scheller <d.scheller@gmx.net> > --- > drivers/media/pci/ddbridge/ddbridge-i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/ddbridge/ddbridge-i2c.c > b/drivers/media/pci/ddbridge/ddbridge-i2c.c index > 22b2543da4ca..3d0aefe05cec 100644 --- > a/drivers/media/pci/ddbridge/ddbridge-i2c.c +++ > b/drivers/media/pci/ddbridge/ddbridge-i2c.c @@ -212,7 +212,7 @@ > static u32 ddb_i2c_functionality(struct i2c_adapter *adap) return > I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; } > > -struct i2c_algorithm ddb_i2c_algo = { > +static const struct i2c_algorithm ddb_i2c_algo = { > .master_xfer = ddb_i2c_master_xfer, > .functionality = ddb_i2c_functionality, > }; This one can be marked "Obsolete" in patchwork. Original ddbridge patches have since been rebased (will re-send soonish), with this change included. Best regards, Daniel Scheller
diff --git a/drivers/media/pci/ddbridge/ddbridge-i2c.c b/drivers/media/pci/ddbridge/ddbridge-i2c.c index 22b2543da4ca..3d0aefe05cec 100644 --- a/drivers/media/pci/ddbridge/ddbridge-i2c.c +++ b/drivers/media/pci/ddbridge/ddbridge-i2c.c @@ -212,7 +212,7 @@ static u32 ddb_i2c_functionality(struct i2c_adapter *adap) return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; } -struct i2c_algorithm ddb_i2c_algo = { +static const struct i2c_algorithm ddb_i2c_algo = { .master_xfer = ddb_i2c_master_xfer, .functionality = ddb_i2c_functionality, };