UVC Module - Support Intel RealSense SR300 Depth Camera formats
Commit Message
Specify GUID and FourCC codes mapping for Depth-related pixel formats advertised by Intel RealSense(tm) SR300 depth camera.
Provide documentation for the new INZI pixel format introduced.
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
Comments
Hi Evgeni,
Thank you for the patch.
On Monday 05 Dec 2016 10:06:55 Raikhel, Evgeni wrote:
> Specify GUID and FourCC codes mapping for Depth-related pixel formats
> advertised by Intel RealSense(tm) SR300 depth camera. Provide documentation
> for the new INZI pixel format introduced.
Could you please resend the patches inline instead of as attachments ? See
Documentation/SubmittingPatches for more information.
Hi Laurent,
Thanks for the feedback - I resubmitted the patches inline, as requested.
Regards,
Evgeni Raikhel
-----Original Message-----
From: Laurent Pinchart [mailto:laurent.pinchart@ideasonboard.com]
Sent: Monday, December 05, 2016 13:02
To: Raikhel, Evgeni <evgeni.raikhel@intel.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] UVC Module - Support Intel RealSense SR300 Depth Camera formats
Hi Evgeni,
Thank you for the patch.
On Monday 05 Dec 2016 10:06:55 Raikhel, Evgeni wrote:
> Specify GUID and FourCC codes mapping for Depth-related pixel formats
> advertised by Intel RealSense(tm) SR300 depth camera. Provide
> documentation for the new INZI pixel format introduced.
Could you please resend the patches inline instead of as attachments ? See Documentation/SubmittingPatches for more information.
--
Regards,
Laurent Pinchart
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Evgeni Raikhel <evgeni.raikhel@intel.com>
This is the third iteration of the formats patch.
Change log:
- Changing INZI entry order in documentation to keep it sorted alphabetically
- Adding format description string to v4l_fill_fmtdesc() function
- Comments update
Daniel Patrick Johnson (1):
uvcvideo: Add support for Intel SR300 depth camera
eraikhel (1):
Documentation: Intel SR300 Depth camera INZI format
Documentation/media/uapi/v4l/depth-formats.rst | 1 +
Documentation/media/uapi/v4l/pixfmt-inzi.rst | 81 ++++++++++++++++++++++++++
drivers/media/usb/uvc/uvc_driver.c | 15 +++++
drivers/media/usb/uvc/uvcvideo.h | 9 +++
drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
include/uapi/linux/videodev2.h | 1 +
6 files changed, 108 insertions(+)
create mode 100644 Documentation/media/uapi/v4l/pixfmt-inzi.rst
From: Evgeni Raikhel <evgeni.raikhel@intel.com>
This is the third iteration of the patch that addresses reported issues.
Change Log:
- Adding V4L2_PIX_FMT_INZI format description to v4l_fill_fmtdesc(..)
- Reorder INZI entry in ../depth-formats.rst to keep the list strictly alphabetic
- Patch comments minor amendments
Daniel Patrick Johnson (1):
uvcvideo: Add support for Intel SR300 depth camera
eraikhel (1):
Documentation: Intel SR300 Depth camera INZI format
Documentation/media/uapi/v4l/depth-formats.rst | 1 +
Documentation/media/uapi/v4l/pixfmt-inzi.rst | 81 ++++++++++++++++++++++++++
drivers/media/usb/uvc/uvc_driver.c | 15 +++++
drivers/media/usb/uvc/uvcvideo.h | 9 +++
drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
include/uapi/linux/videodev2.h | 1 +
6 files changed, 108 insertions(+)
create mode 100644 Documentation/media/uapi/v4l/pixfmt-inzi.rst
From: Evgeni Raikhel <evgeni.raikhel@intel.com>
Change Log:
- Fixing FourCC description in v4l2_ioctl.c to be less than 32 bytes
- Reorder INZI format entry in Documentation chapter
Daniel Patrick Johnson (1):
uvcvideo: Add support for Intel SR300 depth camera
eraikhel (1):
Documentation: Intel SR300 Depth camera INZI format
Documentation/media/uapi/v4l/depth-formats.rst | 1 +
Documentation/media/uapi/v4l/pixfmt-inzi.rst | 81 ++++++++++++++++++++++++++
drivers/media/usb/uvc/uvc_driver.c | 15 +++++
drivers/media/usb/uvc/uvcvideo.h | 9 +++
drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
include/uapi/linux/videodev2.h | 1 +
6 files changed, 108 insertions(+)
create mode 100644 Documentation/media/uapi/v4l/pixfmt-inzi.rst
Hi Laurent,
Can you please update on the status of the submission?
The last version has been reviewed a month ago.
Is there any estimate on when it is going to be staged/triaged/merged into media tree?
Please advise,
Evgeni
-----Original Message-----
From: Raikhel, Evgeni
Sent: Friday, March 03, 2017 01:43
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com; Liakhovetski, Guennadi <guennadi.liakhovetski@intel.com>; Tamir, Eliezer <eliezer.tamir@intel.com>; Raikhel, Evgeni <evgeni.raikhel@intel.com>
Subject: [PATCH v4 0/2] Intel Depth Formats for SR300 Camera
From: Evgeni Raikhel <evgeni.raikhel@intel.com>
Change Log:
- Fixing FourCC description in v4l2_ioctl.c to be less than 32 bytes
- Reorder INZI format entry in Documentation chapter
Daniel Patrick Johnson (1):
uvcvideo: Add support for Intel SR300 depth camera
eraikhel (1):
Documentation: Intel SR300 Depth camera INZI format
Documentation/media/uapi/v4l/depth-formats.rst | 1 +
Documentation/media/uapi/v4l/pixfmt-inzi.rst | 81 ++++++++++++++++++++++++++
drivers/media/usb/uvc/uvc_driver.c | 15 +++++
drivers/media/usb/uvc/uvcvideo.h | 9 +++
drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
include/uapi/linux/videodev2.h | 1 +
6 files changed, 108 insertions(+)
create mode 100644 Documentation/media/uapi/v4l/pixfmt-inzi.rst
Hi Evgeni,
On Monday 03 Apr 2017 08:53:44 Raikhel, Evgeni wrote:
> Hi Laurent,
> Can you please update on the status of the submission?
> The last version has been reviewed a month ago.
> Is there any estimate on when it is going to be staged/triaged/merged into
> media tree?
I've just sent a pull request to Mauro (and CC'ed you). The patches should get
merged in v4.12.
> -----Original Message-----
> From: Raikhel, Evgeni
> Sent: Friday, March 03, 2017 01:43
> To: linux-media@vger.kernel.org
> Cc: laurent.pinchart@ideasonboard.com; Liakhovetski, Guennadi
> <guennadi.liakhovetski@intel.com>; Tamir, Eliezer
> <eliezer.tamir@intel.com>; Raikhel, Evgeni <evgeni.raikhel@intel.com>
> Subject: [PATCH v4 0/2] Intel Depth Formats for SR300 Camera
>
> From: Evgeni Raikhel <evgeni.raikhel@intel.com>
>
> Change Log:
> - Fixing FourCC description in v4l2_ioctl.c to be less than 32 bytes
> - Reorder INZI format entry in Documentation chapter
>
> Daniel Patrick Johnson (1):
> uvcvideo: Add support for Intel SR300 depth camera
>
> eraikhel (1):
> Documentation: Intel SR300 Depth camera INZI format
>
> Documentation/media/uapi/v4l/depth-formats.rst | 1 +
> Documentation/media/uapi/v4l/pixfmt-inzi.rst | 81 ++++++++++++++++++++++
> drivers/media/usb/uvc/uvc_driver.c | 15 +++++
> drivers/media/usb/uvc/uvcvideo.h | 9 +++
> drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
> include/uapi/linux/videodev2.h | 1 +
> 6 files changed, 108 insertions(+)
> create mode 100644 Documentation/media/uapi/v4l/pixfmt-inzi.rst
From 581f4c3e60d8e7895bc34f9e0e90476eed31fa8d Mon Sep 17 00:00:00 2001
From: Evgeni Raikhel <evgeni.raikhel@intel.com>
Date: Wed, 16 Nov 2016 11:53:49 +0200
Subject: [PATCH 2/2] Document Intel SR300 Depth camera INZI format
Provide the frame structure and data layout of V4L2-PIX-FMT-INZI
format utilized by Intel SR300 Depth camera.
This is a complimentary patch for:
[PATCH] UVC: Add support for Intel SR300 depth camera
Signed-off-by: Evgeni Raikhel <evgeni.raikhel@intel.com>
---
Documentation/media/uapi/v4l/pixfmt-inzi.rst | 40 ++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
create mode 100644 Documentation/media/uapi/v4l/pixfmt-inzi.rst
new file mode 100644
@@ -0,0 +1,40 @@
+.. -*- coding: utf-8; mode: rst -*-
+
+.. _V4L2-PIX-FMT-INZI:
+
+**************************
+V4L2_PIX_FMT_INZI ('INZI')
+**************************
+
+Infrared 10-bit linked with Depth 16-bit images
+
+
+Description
+===========
+
+Custom multi-planar format used by Intel SR300 Depth cameras, comprise of Infrared image followed by Depth data.
+The pixel definition is 32-bpp, with the Depth and Infrared Data split into separate continuous planes of identical dimensions.
+
+The first plane - Infrared data - is stored in V4L2_PIX_FMT_Y10 (see :ref:`pixfmt-y10`) greyscale format. Each pixel is 16-bit cell, with actual data present in the 10 LSBs with values in range 0 to 1023. The six remaining MSBs are padded with zeros.
+
+The second plane provides 16-bit per-pixel Depth data in V4L2_PIX_FMT_Z16 (:ref:`pixfmt-z16`) format.
+
+
+**Frame Structure.**
+Each cell is a 16-bit word with the significant data byte is stored at lower memory address (little-endian).
+
++-----------------+-----------------+-----------------+-----------------+-----------------+-----------------+
+| Ir\ :sub:`0` | Ir\ :sub:`1` | Ir\ :sub:`2` | ... | ... | ... |
++-----------------+-----------------+-----------------+-----------------+-----------------+-----------------+
+| ... ... ... |
+| Infrared Data |
+| ... ... ... |
++-----------------+-----------------+-----------------+-----------------+-----------------+-----------------+
+| Ir\ :sub:`n-3` | Ir\ :sub:`n-2` | Ir\ :sub:`n-1` | Depth\ :sub:`0` | Depth\ :sub:`1` | Depth\ :sub:`2` |
++-----------------+-----------------+-----------------+-----------------+-----------------+-----------------+
+| ... ... ... |
+| Depth Data |
+| ... ... ... |
++-----------------+-----------------+-----------------+-----------------+-----------------+-----------------+
+| ... | ... | ... |Depth\ :sub:`n-3`|Depth\ :sub:`n-2`|Depth\ :sub:`n-1`|
++-----------------+-----------------+-----------------+-----------------+-----------------+-----------------+
--
2.7.4