Message ID | 20160302130409.60df670f@recife.lan (mailing list archive) |
---|---|
State | RFC, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84) (envelope-from <linux-media-owner@vger.kernel.org>) id 1ab9G9-0007vI-Hq; Wed, 02 Mar 2016 16:04:21 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.76/mailfrontend-6) with esmtp id 1ab9G7-0000nh-59; Wed, 02 Mar 2016 17:04:21 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756179AbcCBQEQ (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 2 Mar 2016 11:04:16 -0500 Received: from lists.s-osg.org ([54.187.51.154]:57470 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755565AbcCBQEO (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 2 Mar 2016 11:04:14 -0500 Received: from recife.lan (177.18.16.130.dynamic.adsl.gvt.net.br [177.18.16.130]) by lists.s-osg.org (Postfix) with ESMTPSA id 6017F462C1; Wed, 2 Mar 2016 08:04:12 -0800 (PST) Date: Wed, 2 Mar 2016 13:04:09 -0300 From: Mauro Carvalho Chehab <mchehab@osg.samsung.com> To: Sakari Ailus <sakari.ailus@iki.fi> Cc: LMML <linux-media@vger.kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, Javier Martinez Canillas <javier@osg.samsung.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Subject: Re: [RFC] Representing hardware connections via MC Message-ID: <20160302130409.60df670f@recife.lan> In-Reply-To: <20160302124029.0e6cee85@recife.lan> References: <20160226091317.5a07c374@recife.lan> <20160302141643.GH11084@valkosipuli.retiisi.org.uk> <20160302124029.0e6cee85@recife.lan> Organization: Samsung X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.3.2.160019 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, FROM_NAME_PHRASE 0, NO_URI_HTTPS 0, REFERENCES 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __REFERENCES 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0' |
Commit Message
Mauro Carvalho Chehab
March 2, 2016, 4:04 p.m. UTC
Em Wed, 2 Mar 2016 12:40:29 -0300 Mauro Carvalho Chehab <mchehab@osg.samsung.com> escreveu: > After all the discussions, I guess "CONN" for connection is the best way > to represent it. Better to put it on a patch. Please review. Regards, Mauro [media] Better define MEDIA_ENT_F_CONN_* entities Putting concepts in a paper is hard, specially since different people may interpret it in a different way. Make clear about the meaning of the MEDIA_ENT_F_CONN_* entities Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
Hello Mauro, On 03/02/2016 01:04 PM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Mar 2016 12:40:29 -0300 > Mauro Carvalho Chehab <mchehab@osg.samsung.com> escreveu: > >> After all the discussions, I guess "CONN" for connection is the best way >> to represent it. > I agree, after all in the latest proposal, the entity is really a connection (or set of connections as for example in a S-Video with separate Y and C) and the pads are the ones modeling the carrying signals. Just some small typos mentioned below. > Better to put it on a patch. > > Please review. > > Regards, > Mauro > > [media] Better define MEDIA_ENT_F_CONN_* entities > > Putting concepts in a paper is hard, specially since different people > may interpret it in a different way. > > Make clear about the meaning of the MEDIA_ENT_F_CONN_* entities > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > > diff --git a/Documentation/DocBook/media/v4l/media-types.xml b/Documentation/DocBook/media/v4l/media-types.xml > index 5e3f20fdcf17..b036e6103949 100644 > --- a/Documentation/DocBook/media/v4l/media-types.xml > +++ b/Documentation/DocBook/media/v4l/media-types.xml > @@ -46,15 +46,26 @@ > </row> > <row> > <entry><constant>MEDIA_ENT_F_CONN_RF</constant></entry> > - <entry>Connector for a Radio Frequency (RF) signal.</entry> > + <entry>Entity representing the logical connection associated with a > + single Radio Frequency (RF) signal connector. It > + corresponds to the logical input or output associated > + with the RF signal.</entry> > </row> > <row> > <entry><constant>MEDIA_ENT_F_CONN_SVIDEO</constant></entry> > - <entry>Connector for a S-Video signal.</entry> > + <entry>Entity representing the logical connection assowiated s/assowiated/associated > + with a sigle S-Video connector. Such entity should have > + two pads, one for the luminance signal(Y) and one > + for the chrominance signal (C). It corresponds to the s/luminance signal(Y)/luminance signal (Y) > + logical input or output associated with S-Video Y and C > + signals.</entry> > </row> > <row> > <entry><constant>MEDIA_ENT_F_CONN_COMPOSITE</constant></entry> > - <entry>Connector for a RGB composite signal.</entry> > + <entry>Entity representing the logical connection for a composite > + signal. It corresponds to the logical input or output > + associated with the a single signal that carries both s/a/ > + chrominance and luminance information (Y+C).</entry> > </row> > <row> > <entry><constant>MEDIA_ENT_F_CAM_SENSOR</constant></entry> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
On 03/02/2016 09:04 AM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Mar 2016 12:40:29 -0300 > Mauro Carvalho Chehab <mchehab@osg.samsung.com> escreveu: > >> After all the discussions, I guess "CONN" for connection is the best way >> to represent it. > > Better to put it on a patch. > > Please review. > > Regards, > Mauro > > [media] Better define MEDIA_ENT_F_CONN_* entities > > Putting concepts in a paper is hard, specially since different people > may interpret it in a different way. > > Make clear about the meaning of the MEDIA_ENT_F_CONN_* entities > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > > diff --git a/Documentation/DocBook/media/v4l/media-types.xml b/Documentation/DocBook/media/v4l/media-types.xml > index 5e3f20fdcf17..b036e6103949 100644 > --- a/Documentation/DocBook/media/v4l/media-types.xml > +++ b/Documentation/DocBook/media/v4l/media-types.xml > @@ -46,15 +46,26 @@ > </row> > <row> > <entry><constant>MEDIA_ENT_F_CONN_RF</constant></entry> > - <entry>Connector for a Radio Frequency (RF) signal.</entry> > + <entry>Entity representing the logical connection associated with a > + single Radio Frequency (RF) signal connector. It > + corresponds to the logical input or output associated > + with the RF signal.</entry> > </row> > <row> > <entry><constant>MEDIA_ENT_F_CONN_SVIDEO</constant></entry> > - <entry>Connector for a S-Video signal.</entry> > + <entry>Entity representing the logical connection assowiated > + with a sigle S-Video connector. Such entity should have > + two pads, one for the luminance signal(Y) and one > + for the chrominance signal (C). It corresponds to the > + logical input or output associated with S-Video Y and C > + signals.</entry> > </row> > <row> > <entry><constant>MEDIA_ENT_F_CONN_COMPOSITE</constant></entry> > - <entry>Connector for a RGB composite signal.</entry> > + <entry>Entity representing the logical connection for a composite > + signal. It corresponds to the logical input or output > + associated with the a single signal that carries both > + chrominance and luminance information (Y+C).</entry> > </row> > <row> > <entry><constant>MEDIA_ENT_F_CAM_SENSOR</constant></entry> Finally caught up with RFC discussion. Looks good to me. Thanks for the summary and the patch. Acked-by: Shuah Khan <shuahkh@osg.samsung.com> In general I agree with the direction to go with property API as it offers flexibility for future enhancements and allows drivers to care about only the properties they need to support. -- Shuah
On 03/02/2016 05:04 PM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Mar 2016 12:40:29 -0300 > Mauro Carvalho Chehab <mchehab@osg.samsung.com> escreveu: > >> After all the discussions, I guess "CONN" for connection is the best way >> to represent it. > > Better to put it on a patch. > > Please review. > > Regards, > Mauro > > [media] Better define MEDIA_ENT_F_CONN_* entities > > Putting concepts in a paper is hard, specially since different people > may interpret it in a different way. > > Make clear about the meaning of the MEDIA_ENT_F_CONN_* entities > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > > diff --git a/Documentation/DocBook/media/v4l/media-types.xml b/Documentation/DocBook/media/v4l/media-types.xml > index 5e3f20fdcf17..b036e6103949 100644 > --- a/Documentation/DocBook/media/v4l/media-types.xml > +++ b/Documentation/DocBook/media/v4l/media-types.xml > @@ -46,15 +46,26 @@ > </row> > <row> > <entry><constant>MEDIA_ENT_F_CONN_RF</constant></entry> > - <entry>Connector for a Radio Frequency (RF) signal.</entry> > + <entry>Entity representing the logical connection associated with a > + single Radio Frequency (RF) signal connector. It > + corresponds to the logical input or output associated > + with the RF signal.</entry> > </row> > <row> > <entry><constant>MEDIA_ENT_F_CONN_SVIDEO</constant></entry> > - <entry>Connector for a S-Video signal.</entry> > + <entry>Entity representing the logical connection assowiated > + with a sigle S-Video connector. Such entity should have > + two pads, one for the luminance signal(Y) and one Add space after 'signal'. Other than that: Acked-by: Hans Verkuil <hans.verkuil@cisco.com> Regards, Hans > + for the chrominance signal (C). It corresponds to the > + logical input or output associated with S-Video Y and C > + signals.</entry> > </row> > <row> > <entry><constant>MEDIA_ENT_F_CONN_COMPOSITE</constant></entry> > - <entry>Connector for a RGB composite signal.</entry> > + <entry>Entity representing the logical connection for a composite > + signal. It corresponds to the logical input or output > + associated with the a single signal that carries both > + chrominance and luminance information (Y+C).</entry> > </row> > <row> > <entry><constant>MEDIA_ENT_F_CAM_SENSOR</constant></entry> > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/DocBook/media/v4l/media-types.xml b/Documentation/DocBook/media/v4l/media-types.xml index 5e3f20fdcf17..b036e6103949 100644 --- a/Documentation/DocBook/media/v4l/media-types.xml +++ b/Documentation/DocBook/media/v4l/media-types.xml @@ -46,15 +46,26 @@ </row> <row> <entry><constant>MEDIA_ENT_F_CONN_RF</constant></entry> - <entry>Connector for a Radio Frequency (RF) signal.</entry> + <entry>Entity representing the logical connection associated with a + single Radio Frequency (RF) signal connector. It + corresponds to the logical input or output associated + with the RF signal.</entry> </row> <row> <entry><constant>MEDIA_ENT_F_CONN_SVIDEO</constant></entry> - <entry>Connector for a S-Video signal.</entry> + <entry>Entity representing the logical connection assowiated + with a sigle S-Video connector. Such entity should have + two pads, one for the luminance signal(Y) and one + for the chrominance signal (C). It corresponds to the + logical input or output associated with S-Video Y and C + signals.</entry> </row> <row> <entry><constant>MEDIA_ENT_F_CONN_COMPOSITE</constant></entry> - <entry>Connector for a RGB composite signal.</entry> + <entry>Entity representing the logical connection for a composite + signal. It corresponds to the logical input or output + associated with the a single signal that carries both + chrominance and luminance information (Y+C).</entry> </row> <row> <entry><constant>MEDIA_ENT_F_CAM_SENSOR</constant></entry>