| Message ID | 1405083417-20615-1-git-send-email-ao2@ao2.it (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Hans de Goede |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33])
by www.linuxtv.org with esmtp (Exim 4.72)
(envelope-from <linux-media-owner@vger.kernel.org>)
id 1X5aOE-0005pV-1z; Fri, 11 Jul 2014 14:57:26 +0200
X-tubIT-Incoming-IP: 209.132.180.67
Received: from vger.kernel.org ([209.132.180.67])
by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp
id 1X5aOB-0006ZL-5q; Fri, 11 Jul 2014 14:57:25 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1752391AbaGKM5V (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other);
Fri, 11 Jul 2014 08:57:21 -0400
Received: from smtp206.alice.it ([82.57.200.102]:3237 "EHLO smtp206.alice.it"
rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
id S1753215AbaGKM5D (ORCPT <rfc822;linux-media@vger.kernel.org>);
Fri, 11 Jul 2014 08:57:03 -0400
Received: from jcn (82.57.107.85) by smtp206.alice.it (8.6.060.28)
id 529A678F2A04950A; Fri, 11 Jul 2014 14:57:00 +0200
Received: from ao2 by jcn with local (Exim 4.82_1-5b7a7c0-XX)
(envelope-from <ao2@ao2.it>)
id 1X5aNn-0005N6-0p; Fri, 11 Jul 2014 14:56:59 +0200
From: Antonio Ospite <ao2@ao2.it>
To: linux-media@vger.kernel.org
Cc: Antonio Ospite <ao2@ao2.it>, Hans de Goede <hdegoede@redhat.com>
Subject: [PATCH] gspca_stv06xx: enable button found on some Quickcam Express
variant
Date: Fri, 11 Jul 2014 14:56:57 +0200
Message-Id: <1405083417-20615-1-git-send-email-ao2@ao2.it>
X-Mailer: git-send-email 2.0.1
X-Face: z*RaLf`X<@C75u6Ig9}{oW$H; 1_\2t5)({*|jhM<pyWR#k60!#=#>/Vb;
]yA5<GWI5`6u&+ ; 6b'@y|8w"wB;
4/e!7wYYrcqdJFY,~%Gk_4]cq$Ei/7<j&N3ah(m`ku?pX.&+~:_/wC~dwn^)MizBG
!pE^+iDQQ1yC6^,)YDKkxDd!T>\I~93>J<_`<4)A{':UrE
Sender: linux-media-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409,
Antispam-Data: 2014.7.11.124520
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report='
MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05,
BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0,
BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0,
BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0,
__CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0,
__HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0,
__MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0,
__TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS '
|
Commit Message
Antonio Ospite
July 11, 2014, 12:56 p.m. UTC
Signed-off-by: Antonio Ospite <ao2@ao2.it>
---
drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hi, On 07/11/2014 02:56 PM, Antonio Ospite wrote: > Signed-off-by: Antonio Ospite <ao2@ao2.it> Thanks, I've added this to my tree and send a pull-req for it to Mauro. Regards, Hans > --- > drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c > index 49d209b..6ac93d8 100644 > --- a/drivers/media/usb/gspca/stv06xx/stv06xx.c > +++ b/drivers/media/usb/gspca/stv06xx/stv06xx.c > @@ -505,13 +505,13 @@ static int sd_int_pkt_scan(struct gspca_dev *gspca_dev, > { > int ret = -EINVAL; > > - if (len == 1 && data[0] == 0x80) { > + if (len == 1 && (data[0] == 0x80 || data[0] == 0x10)) { > input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1); > input_sync(gspca_dev->input_dev); > ret = 0; > } > > - if (len == 1 && data[0] == 0x88) { > + if (len == 1 && (data[0] == 0x88 || data[0] == 0x11)) { > input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0); > input_sync(gspca_dev->input_dev); > ret = 0; > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 14 Jul 2014 12:27:57 +0200 Hans de Goede <hdegoede@redhat.com> wrote: > Hi, > > On 07/11/2014 02:56 PM, Antonio Ospite wrote: > > Signed-off-by: Antonio Ospite <ao2@ao2.it> > > Thanks, I've added this to my tree and send a pull-req for it > to Mauro. > Hi Hans, I still don't see the change in 3.18-rc2, maybe it got lost. Here is the patchwork link in case you want to pick the change for 3.19: https://patchwork.linuxtv.org/patch/24732/ Thanks, Antonio > Regards, > > Hans > > > --- > > drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c > > index 49d209b..6ac93d8 100644 > > --- a/drivers/media/usb/gspca/stv06xx/stv06xx.c > > +++ b/drivers/media/usb/gspca/stv06xx/stv06xx.c > > @@ -505,13 +505,13 @@ static int sd_int_pkt_scan(struct gspca_dev *gspca_dev, > > { > > int ret = -EINVAL; > > > > - if (len == 1 && data[0] == 0x80) { > > + if (len == 1 && (data[0] == 0x80 || data[0] == 0x10)) { > > input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1); > > input_sync(gspca_dev->input_dev); > > ret = 0; > > } > > > > - if (len == 1 && data[0] == 0x88) { > > + if (len == 1 && (data[0] == 0x88 || data[0] == 0x11)) { > > input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0); > > input_sync(gspca_dev->input_dev); > > ret = 0; > >
On Tue, 28 Oct 2014 15:39:41 +0100 Antonio Ospite <ao2@ao2.it> wrote: > On Mon, 14 Jul 2014 12:27:57 +0200 > Hans de Goede <hdegoede@redhat.com> wrote: > > > Hi, > > > > On 07/11/2014 02:56 PM, Antonio Ospite wrote: > > > Signed-off-by: Antonio Ospite <ao2@ao2.it> > > > > Thanks, I've added this to my tree and send a pull-req for it > > to Mauro. > > > > Hi Hans, I still don't see the change in 3.18-rc2, maybe it got lost. > > Here is the patchwork link in case you want to pick the change for 3.19: > https://patchwork.linuxtv.org/patch/24732/ > Ping. Still missing in 3.19-rc3. Can we have it for 3.20? Thanks, Antonio > > Regards, > > > > Hans > > > > > --- > > > drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c > > > index 49d209b..6ac93d8 100644 > > > --- a/drivers/media/usb/gspca/stv06xx/stv06xx.c > > > +++ b/drivers/media/usb/gspca/stv06xx/stv06xx.c > > > @@ -505,13 +505,13 @@ static int sd_int_pkt_scan(struct gspca_dev *gspca_dev, > > > { > > > int ret = -EINVAL; > > > > > > - if (len == 1 && data[0] == 0x80) { > > > + if (len == 1 && (data[0] == 0x80 || data[0] == 0x10)) { > > > input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1); > > > input_sync(gspca_dev->input_dev); > > > ret = 0; > > > } > > > > > > - if (len == 1 && data[0] == 0x88) { > > > + if (len == 1 && (data[0] == 0x88 || data[0] == 0x11)) { > > > input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0); > > > input_sync(gspca_dev->input_dev); > > > ret = 0; > > > > > > -- > Antonio Ospite > http://ao2.it > > A: Because it messes up the order in which people normally read text. > See http://en.wikipedia.org/wiki/Posting_style > Q: Why is top-posting such a bad thing? > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 06-01-15 21:59, Antonio Ospite wrote: > On Tue, 28 Oct 2014 15:39:41 +0100 > Antonio Ospite <ao2@ao2.it> wrote: > >> On Mon, 14 Jul 2014 12:27:57 +0200 >> Hans de Goede <hdegoede@redhat.com> wrote: >> >>> Hi, >>> >>> On 07/11/2014 02:56 PM, Antonio Ospite wrote: >>>> Signed-off-by: Antonio Ospite <ao2@ao2.it> >>> >>> Thanks, I've added this to my tree and send a pull-req for it >>> to Mauro. >>> >> >> Hi Hans, I still don't see the change in 3.18-rc2, maybe it got lost. >> >> Here is the patchwork link in case you want to pick the change for 3.19: >> https://patchwork.linuxtv.org/patch/24732/ >> > > Ping. > > Still missing in 3.19-rc3. Yes, weird, I had it in a pull-req for 3.17: http://git.linuxtv.org/cgit.cgi/hgoede/gspca.git/log/?h=media-for_v3.17 Anyways I've queued it up for 3.20 now. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c index 49d209b..6ac93d8 100644 --- a/drivers/media/usb/gspca/stv06xx/stv06xx.c +++ b/drivers/media/usb/gspca/stv06xx/stv06xx.c @@ -505,13 +505,13 @@ static int sd_int_pkt_scan(struct gspca_dev *gspca_dev, { int ret = -EINVAL; - if (len == 1 && data[0] == 0x80) { + if (len == 1 && (data[0] == 0x80 || data[0] == 0x10)) { input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1); input_sync(gspca_dev->input_dev); ret = 0; } - if (len == 1 && data[0] == 0x88) { + if (len == 1 && (data[0] == 0x88 || data[0] == 0x11)) { input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0); input_sync(gspca_dev->input_dev); ret = 0;