Message ID | 20140428214000.GA9187@gmail.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1WetHV-0005Da-PT; Mon, 28 Apr 2014 23:40:09 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1WetHT-0003KT-5j; Mon, 28 Apr 2014 23:40:09 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932118AbaD1VkF (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 28 Apr 2014 17:40:05 -0400 Received: from mail-we0-f177.google.com ([74.125.82.177]:52531 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753974AbaD1VkD (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 28 Apr 2014 17:40:03 -0400 Received: by mail-we0-f177.google.com with SMTP id t60so5119744wes.22 for <multiple recipients>; Mon, 28 Apr 2014 14:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=tBu7bj/K43Ly3eXo8H/f5pfyVvEQ1eO2ggdIzX9IclY=; b=pPltGcYaP2a/Jw7FeMRtT/Rb+VueUWkA2KdnbDwHC5/WmdYOQ6LM1moFg5Brs0IPGw v/y14wFCsZ2TVk/OaAkMZJM/KTilJUnVocpL9y2kjRjpB0Zi/gRwrIfJANjyf+02weAJ pKIqKPfRhjyM1edpbAnyMA63iKuv6dV32NJoivwyUZd1TU0fHtPH6+7oIh8H5pp514ys ywa6ci1gE2+gYLPtRlfpT5uNxBJNz0u1TWpCuMA24AgH4U5PVgDvd52WDRN4lgEcLgKP ZzN40kiYBPclZA5/YPPl7FNFWfkj7xe84xvaNg77c1NDbwzoYunEY3dweEIeou1WGF11 D1iQ== X-Received: by 10.180.108.147 with SMTP id hk19mr17284402wib.42.1398721202337; Mon, 28 Apr 2014 14:40:02 -0700 (PDT) Received: from gmail.com ([109.76.212.133]) by mx.google.com with ESMTPSA id uc3sm619029wib.10.2014.04.28.14.39.59 for <multiple recipients> (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 28 Apr 2014 14:40:01 -0700 (PDT) Date: Mon, 28 Apr 2014 22:40:00 +0100 From: Brian Healy <healybrian@gmail.com> To: Antti Palosaari <crope@iki.fi>, Mauro Carvalho Chehab <m.chehab@samsung.com> Cc: Linus Torvalds <torvalds@linux-foundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org> Subject: Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver Message-ID: <20140428214000.GA9187@gmail.com> References: <CAGG=RuYdtfjJf5wKG92KdyKuG6AiBHp2_OSH8Wemi3yQOsouMQ@mail.gmail.com> <CA+55aFzhydSCJqMLoUX59cLpiwbnoXtL524O5VtQ4-CVj8HxyA@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="opJtzjQTFsWo+cga" Content-Disposition: inline In-Reply-To: <CA+55aFzhydSCJqMLoUX59cLpiwbnoXtL524O5VtQ4-CVj8HxyA@mail.gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.4.28.213319 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MIME_TEXT_ONLY_MP_MIXED 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1900_1999 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0, __FORWARDED_MSG 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0, __YOUTUBE_RCVD 0' |
Commit Message
Brian Healy
April 28, 2014, 9:40 p.m. UTC
On Sun, Apr 27, 2014 at 03:19:12PM -0700, Linus Torvalds wrote: Hi Linus, apologies, i've changed email clients in order to preserve the formatting this time around. The patch is now included inline as an attachment. I ran the script but noticed you've already cc'd the appropriate people. Brian. Resubmitting modified patch. It's purpose is to add the appropriate device/usb ids for the "Peak DVT-B usb dongle" to the rtl28xxu.c driver. Signed-off-by: Brian Healy <healybrian <at> gmail.com> > Brian, please use > > ./scripts/get_maintainer -f drivers/media/usb/dvb-usb-v2/rtl28xxu.c > > to get the proper people to send this to, so that it doesn't get lost > in the flood in lkml. > > The indentation of that new entry also seems to be suspect, in that it > doesn't match the ones around it. > > Quoting full email for context for people added. > > Linus >
Comments
Em Mon, 28 Apr 2014 22:40:00 +0100 Brian Healy <healybrian@gmail.com> escreveu: > From: Brian Healy <healybrian@gmail.com> > To: Antti Palosaari <crope@iki.fi>, Mauro Carvalho Chehab <m.chehab@samsung.com> > Cc: Linus Torvalds <torvalds@linux-foundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org> > Subject: Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver > Date: Mon, 28 Apr 2014 22:40:00 +0100 > Sender: linux-media-owner@vger.kernel.org > User-Agent: Mutt/1.5.21 (2010-09-15) > > On Sun, Apr 27, 2014 at 03:19:12PM -0700, Linus Torvalds wrote: > > Hi Linus, > > apologies, i've changed email clients in order to preserve the > formatting this time around. The patch is now included inline as an > attachment. I ran the script but noticed you've already cc'd the > appropriate people. > > Brian. > > > Resubmitting modified patch. It's purpose is to add the appropriate > device/usb ids for the "Peak DVT-B usb dongle" to the rtl28xxu.c driver. > > Signed-off-by: Brian Healy <healybrian <at> gmail.com> > > > > Brian, please use > > > > ./scripts/get_maintainer -f drivers/media/usb/dvb-usb-v2/rtl28xxu.c > > > > to get the proper people to send this to, so that it doesn't get lost > > in the flood in lkml. > > > > The indentation of that new entry also seems to be suspect, in that it > > doesn't match the ones around it. > > > > Quoting full email for context for people added. > > > > Linus > > > > diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > index 61d196e..b6e20cc 100644 > --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > @@ -1499,6 +1499,8 @@ static const struct usb_device_id rtl28xxu_id_table[] = { > &rtl2832u_props, "Crypto ReDi PC 50 A", NULL) }, > { DVB_USB_DEVICE(USB_VID_KYE, 0x707f, > &rtl2832u_props, "Genius TVGo DVB-T03", NULL) }, > + { DVB_USB_DEVICE(USB_VID_KWORLD_2, 0xd395, > + &rtl2832u_props, "Peak DVB-T USB", NULL) }, Patch is still a little odd, as you're using spaces for indenting, instead of tabs, but I can fix it with my scripts. Next time, please use tabs. Also, specifically in the case of patches for linux-media, you don't need to c/c me. Just send the patch to linux-media and to the driver maintainer (Antti, in this case). My workflow is to pick the patches from patchwork: https://patchwork.linuxtv.org/patch/23792/ after receiving Antti's ack. Alternatively, Antti may opt to put it on his git tree, sending it to me latter together of other patches he may have for the devices he maintains. > > /* RTL2832P devices: */ > { DVB_USB_DEVICE(USB_VID_HANFTEK, 0x0131, Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks Mauro, I'll know for next time. It's my first patch submission so wasn't aware of the formatting rules. Brian On 29 April 2014 15:16, Mauro Carvalho Chehab <m.chehab@samsung.com> wrote: > Em Mon, 28 Apr 2014 22:40:00 +0100 > Brian Healy <healybrian@gmail.com> escreveu: > >> From: Brian Healy <healybrian@gmail.com> >> To: Antti Palosaari <crope@iki.fi>, Mauro Carvalho Chehab <m.chehab@samsung.com> >> Cc: Linus Torvalds <torvalds@linux-foundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org> >> Subject: Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver >> Date: Mon, 28 Apr 2014 22:40:00 +0100 >> Sender: linux-media-owner@vger.kernel.org >> User-Agent: Mutt/1.5.21 (2010-09-15) >> >> On Sun, Apr 27, 2014 at 03:19:12PM -0700, Linus Torvalds wrote: >> >> Hi Linus, >> >> apologies, i've changed email clients in order to preserve the >> formatting this time around. The patch is now included inline as an >> attachment. I ran the script but noticed you've already cc'd the >> appropriate people. >> >> Brian. >> >> >> Resubmitting modified patch. It's purpose is to add the appropriate >> device/usb ids for the "Peak DVT-B usb dongle" to the rtl28xxu.c driver. >> >> Signed-off-by: Brian Healy <healybrian <at> gmail.com> >> >> >> > Brian, please use >> > >> > ./scripts/get_maintainer -f drivers/media/usb/dvb-usb-v2/rtl28xxu.c >> > >> > to get the proper people to send this to, so that it doesn't get lost >> > in the flood in lkml. >> > >> > The indentation of that new entry also seems to be suspect, in that it >> > doesn't match the ones around it. >> > >> > Quoting full email for context for people added. >> > >> > Linus >> > >> >> diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c >> index 61d196e..b6e20cc 100644 >> --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c >> +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c >> @@ -1499,6 +1499,8 @@ static const struct usb_device_id rtl28xxu_id_table[] = { >> &rtl2832u_props, "Crypto ReDi PC 50 A", NULL) }, >> { DVB_USB_DEVICE(USB_VID_KYE, 0x707f, >> &rtl2832u_props, "Genius TVGo DVB-T03", NULL) }, >> + { DVB_USB_DEVICE(USB_VID_KWORLD_2, 0xd395, >> + &rtl2832u_props, "Peak DVB-T USB", NULL) }, > > Patch is still a little odd, as you're using spaces for indenting, instead of > tabs, but I can fix it with my scripts. Next time, please use tabs. > > Also, specifically in the case of patches for linux-media, you don't need > to c/c me. Just send the patch to linux-media and to the driver maintainer > (Antti, in this case). > > My workflow is to pick the patches from patchwork: > https://patchwork.linuxtv.org/patch/23792/ > after receiving Antti's ack. > > Alternatively, Antti may opt to put it on his git tree, sending it to me > latter together of other patches he may have for the devices he maintains. > >> >> /* RTL2832P devices: */ >> { DVB_USB_DEVICE(USB_VID_HANFTEK, 0x0131, > > Thanks, > Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index 61d196e..b6e20cc 100644 --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c @@ -1499,6 +1499,8 @@ static const struct usb_device_id rtl28xxu_id_table[] = { &rtl2832u_props, "Crypto ReDi PC 50 A", NULL) }, { DVB_USB_DEVICE(USB_VID_KYE, 0x707f, &rtl2832u_props, "Genius TVGo DVB-T03", NULL) }, + { DVB_USB_DEVICE(USB_VID_KWORLD_2, 0xd395, + &rtl2832u_props, "Peak DVB-T USB", NULL) }, /* RTL2832P devices: */ { DVB_USB_DEVICE(USB_VID_HANFTEK, 0x0131,