LinuxTV Patchwork small patch for vdr.c: continue even with read-only video directory

login
register
mail settings
Submitter Peter Münster
Date March 9, 2013, 8:24 p.m.
Message ID <878v5wxqx1.fsf@micropit.couberia.selfip.net>
Download mbox | patch
Permalink /patch/17190/
State New
Headers show

Comments

Peter Münster - March 9, 2013, 8:24 p.m.
Hi Klaus,

Could you please delete line 577 from vdr.c or do something similar to
let vdr continue even with read-only video directory?

vdr runs fine with this patch on my system, and it's important for me,
that vdr cannot write anything to the video directory.
(see also http://pmrb.free.fr/vdr/)

Here a small patch:

--8<---------------cut here---------------start------------->8---
--8<---------------cut here---------------end--------------->8---

If you prefer, I can write a better patch: stop if not readable, warn if
not writable.

TIA,
Klaus Schmidinger - March 10, 2013, 11:18 a.m.
On 09.03.2013 21:24, Peter Münster wrote:
> Hi Klaus,
>
> Could you please delete line 577 from vdr.c or do something similar to
> let vdr continue even with read-only video directory?
>
> vdr runs fine with this patch on my system, and it's important for me,
> that vdr cannot write anything to the video directory.
> (see also http://pmrb.free.fr/vdr/)
>
> Here a small patch:
>
> --8<---------------cut here---------------start------------->8---
> --- vdr.c.orig	2013-03-09 21:13:57.846826771 +0100
> +++ vdr.c	2013-03-09 21:16:33.503521762 +0100
> @@ -574,7 +574,6 @@
>
>     if (!DirectoryOk(VideoDirectory, true)) {
>        fprintf(stderr, "vdr: can't access video directory %s\n", VideoDirectory);
> -     return 2;
>        }
>
>     // Daemon mode:
> --8<---------------cut here---------------end--------------->8---
>
> If you prefer, I can write a better patch: stop if not readable, warn if
> not writable.

I'm afraid we're too close to releasing version 2.0.0 to make such
changes now.

Besides, why don't you just use a writeable video directory and mount
your read-only directory below that? Something like

/video
/video/readonly

Klaus
Peter Münster - March 10, 2013, 7:45 p.m.
On Sun, Mar 10 2013, Klaus Schmidinger wrote:

> I'm afraid we're too close to releasing version 2.0.0 to make such
> changes now.

No problem. I would just like to know, if you agree with such a patch
(or something more elaborated).


> Besides, why don't you just use a writeable video directory and mount
> your read-only directory below that? Something like
>
> /video
> /video/readonly

1. I don't want, that the client VDR can write/record anything to
   /video.
2. I want my VDR setup to be as simple as possible.

(It just works... ;)

Patch

--- vdr.c.orig	2013-03-09 21:13:57.846826771 +0100
+++ vdr.c	2013-03-09 21:16:33.503521762 +0100
@@ -574,7 +574,6 @@ 
 
   if (!DirectoryOk(VideoDirectory, true)) {
      fprintf(stderr, "vdr: can't access video directory %s\n", VideoDirectory);
-     return 2;
      }
 
   // Daemon mode:

Privacy Policy