LinuxTV Patchwork [ANNOUNCE] vdr-rotorng-0.3

login
register
mail settings
Submitter L. Hanisch
Date Oct. 25, 2012, 4:42 p.m.
Message ID <50896C07.3060200@flensrocker.de>
Download mbox | patch
Permalink /patch/15196/
State New
Headers show

Comments

L. Hanisch - Oct. 25, 2012, 4:42 p.m.
Hi,

Am 25.10.2012 17:23, schrieb Morfsta:
> The third version of my plugin rotorng has been released here: -
> 
> http://projects.vdr-developer.org/projects/plg-rotor-ng/files
> 
> This plugin allows you to steer a disecq 1.1 rotor, find satellites
> with a signal meter and to store them at given positions. It also has
> a rudimentary channel scanner which works with both DVB-S and S2. Much
> of this code has been merged together from the existing actuator and
> rotor plugins, so thanks to the developers of those for their work.
> 
> Please see the README file, there are a number of functions within the
> user interface that aren't fully implemented or working but the main
> functions are there.
> 
> Changes since previous version: -
> 
> 2012-10-11: Version 0.2
> 
> - updated sat card store value in config, always resetting
> - fixed issue with change implemented in 1.7.23 (thanks to Ihanisch)
> 
> 2012-10-21: Version 0.3
> 
> - Added patch for vdr-1.7.27 onwards, old patch for VDR still exists also.
> - Fixed problem with cStatusMonitor::ChannelSwitch call introduced in
> VDR 1.7.26 so dish moves on channel change

 You've forgotten the wrap the definition of ChannelSwitch into #if's:


Regards,
Lars.

> 
> Good luck!
> 
> _______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
>
Morfsta - Oct. 25, 2012, 5:44 p.m.
On Thu, Oct 25, 2012 at 5:42 PM, Lars Hanisch <dvb@flensrocker.de> wrote:
>  You've forgotten the wrap the definition of ChannelSwitch into #if's:
>
> --- a/rotorng.c
> +++ b/rotorng.c
> @@ -333,7 +333,11 @@
>    int last_position_shown;
>    bool transfer;
>  protected:
> +#if VDRVERSNUM >= 10726
>    virtual void ChannelSwitch(const cDevice *Device, int ChannelNumber, bool LiveView);
> +#else
> +  virtual void ChannelSwitch(const cDevice *Device, int ChannelNumber);
> +#endif
>  public:
>    cStatusMonitor();
>  };
>

Are you sure? Its definitely in my copy and seems to be in the one on
the projects site.

Thanks
L. Hanisch - Oct. 26, 2012, 6:59 a.m.
Hi,

Am 25.10.2012 19:44, schrieb Morfsta:
> On Thu, Oct 25, 2012 at 5:42 PM, Lars Hanisch <dvb@flensrocker.de> wrote:
>>  You've forgotten the wrap the definition of ChannelSwitch into #if's:
>>
>> --- a/rotorng.c
>> +++ b/rotorng.c
>> @@ -333,7 +333,11 @@
>>    int last_position_shown;
>>    bool transfer;
>>  protected:
>> +#if VDRVERSNUM >= 10726
>>    virtual void ChannelSwitch(const cDevice *Device, int ChannelNumber, bool LiveView);
>> +#else
>> +  virtual void ChannelSwitch(const cDevice *Device, int ChannelNumber);
>> +#endif
>>  public:
>>    cStatusMonitor();
>>  };
>>
> 
> Are you sure? Its definitely in my copy and seems to be in the one on
> the projects site.

 There are two places: one in the class definition and one a few lines below that. Just search for "ChannelSwitch"... :)
 Line 336 and line 347.

Regards,
Lars.

> 
> Thanks
> 
> _______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
>
Morfsta - Oct. 26, 2012, 11:36 a.m.
On Fri, Oct 26, 2012 at 7:59 AM, Lars Hanisch <dvb@flensrocker.de> wrote:
>>  There are two places: one in the class definition and one a few lines below that. Just search for "ChannelSwitch"... :)
>  Line 336 and line 347.

Oops. Thanks for the help, I'll update and release a fixed version.

Thanks
Morfsta - Oct. 26, 2012, 12:12 p.m.
Okay, updated version (0.3.1) has been uploaded to the VDR Projects site.

I have also fixed all the compilation warnings (at last)!

Thanks
L. Hanisch - Oct. 27, 2012, 10:18 a.m.
Hi,

Am 26.10.2012 14:12, schrieb Morfsta:
> Okay, updated version (0.3.1) has been uploaded to the VDR Projects site.
> 
> I have also fixed all the compilation warnings (at last)!

 rotorng.c, line 204:
  if (ActuatorDevice->SendDiseqcCmd(switch_cmds[KNr]))
  {
    dsyslog("Failed to send diseqc command!\n");
    return;
  }

 I think, it should be (missed a !)
  if (!ActuatorDevice->SendDiseqcCmd(switch_cmds[KNr]))
  {
    dsyslog("Failed to send diseqc command!\n");
    return;
  }

 Tomorrow I will do some more review, so be patient with a new release... :)
 This one isn't bad, just a failure debug message when there's no error.

Lars.

> 
> Thanks
> 
> _______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
>
YUP - Feb. 19, 2013, 5:03 p.m.
Hey Morfsta,
Vdr 2.0.0 is coming, it's time to update your plugin. BTW, take a look into
this issue http://projects.vdr-developer.org/issues/740 . The same error I
discovered when compiled against vdr-1.7.38.
Regards,
Yarema


2012/10/27 Lars Hanisch <dvb@flensrocker.de>

> Hi,
>
> Am 26.10.2012 14:12, schrieb Morfsta:
> > Okay, updated version (0.3.1) has been uploaded to the VDR Projects site.
> >
> > I have also fixed all the compilation warnings (at last)!
>
>  rotorng.c, line 204:
>   if (ActuatorDevice->SendDiseqcCmd(switch_cmds[KNr]))
>   {
>     dsyslog("Failed to send diseqc command!\n");
>     return;
>   }
>
>  I think, it should be (missed a !)
>   if (!ActuatorDevice->SendDiseqcCmd(switch_cmds[KNr]))
>   {
>     dsyslog("Failed to send diseqc command!\n");
>     return;
>   }
>
>  Tomorrow I will do some more review, so be patient with a new release...
> :)
>  This one isn't bad, just a failure debug message when there's no error.
>
> Lars.
>
> >
> > Thanks
> >
> > _______________________________________________
> > vdr mailing list
> > vdr@linuxtv.org
> > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
> >
>
> _______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
>
Morfsta - Feb. 20, 2013, 1:41 p.m.
On Tue, Feb 19, 2013 at 5:03 PM, YUP <yupadmin@gmail.com> wrote:
> Hey Morfsta,
> Vdr 2.0.0 is coming, it's time to update your plugin. BTW, take a look into
> this issue http://projects.vdr-developer.org/issues/740 . The same error I
> discovered when compiled against vdr-1.7.38.
> Regards,
> Yarema

That issue was fixed in version 0.3.1. Are there any further changes
that are required for VDR 2.0.0?

Regards,

Morfsta
Joerg Bornkessel - March 12, 2013, 7:08 p.m.
> That issue was fixed in version 0.3.1. Are there any further changes
> that are required for VDR 2.0.0?

rotorng-0.3.1

- still relies on the old Makefile
this is easy to fix, copy the Makefile from dvbhddevice
adapt the line PLUGIN and OBJS, thats all
no backwards crap, no worrys :)
depend the plugin to >=vdr-1.7.38 in README

- remove the leftover DIR /locale (from earlyer local compile?)

Patch

--- a/rotorng.c
+++ b/rotorng.c
@@ -333,7 +333,11 @@ 
   int last_position_shown;
   bool transfer;
 protected:
+#if VDRVERSNUM >= 10726
   virtual void ChannelSwitch(const cDevice *Device, int ChannelNumber, bool LiveView);
+#else
+  virtual void ChannelSwitch(const cDevice *Device, int ChannelNumber);
+#endif
 public:
   cStatusMonitor();
 };

Privacy Policy