LinuxTV Patchwork correct some includes at plugins

login
register
mail settings
Submitter L. Hanisch
Date Oct. 20, 2012, 1:03 p.m.
Message ID <5082A105.7000003@flensrocker.de>
Download mbox | patch
Permalink /patch/15069/
State New
Headers show

Comments

L. Hanisch - Oct. 20, 2012, 1:03 p.m.
Hi,

Plugins should use

#include <vdr/...>

 and not

#include "vdr/..."

Regards,
Lars.
L. Hanisch - Nov. 18, 2012, 11:03 p.m.
Hi,

Am 20.10.2012 15:03, schrieb Lars Hanisch:
> Plugins should use
> 
> #include <vdr/...>
> 
>  and not
> 
> #include "vdr/..."

 Any reason, this didn't get into 1.7.32?
 Is it wrong or was it just missed? ;)
 It would help packaging plugins which needs headers of the dvb?ddevice-plugins.

 Here's a link to the patch:
 http://patchwork.linuxtv.org/patch/15069/

Regards,
Lars.
Klaus Schmidinger - Nov. 18, 2012, 11:20 p.m.
On 19.11.2012 00:03, Lars Hanisch wrote:
> Hi,
>
> Am 20.10.2012 15:03, schrieb Lars Hanisch:
>> Plugins should use
>>
>> #include <vdr/...>
>>
>>   and not
>>
>> #include "vdr/..."
>
>   Any reason, this didn't get into 1.7.32?
>   Is it wrong or was it just missed? ;)

It's not wrong and it wasn't missed, either ;-)
It's just somewhat further down the TODO list, and I wanted to
have the new cutting code finally available for others to test
and maybe debug.

Klaus
L. Hanisch - Nov. 18, 2012, 11:27 p.m.
Am 19.11.2012 00:20, schrieb Klaus Schmidinger:
> On 19.11.2012 00:03, Lars Hanisch wrote:
>> Hi,
>>
>> Am 20.10.2012 15:03, schrieb Lars Hanisch:
>>> Plugins should use
>>>
>>> #include <vdr/...>
>>>
>>>   and not
>>>
>>> #include "vdr/..."
>>
>>   Any reason, this didn't get into 1.7.32?
>>   Is it wrong or was it just missed? ;)
> 
> It's not wrong and it wasn't missed, either ;-)
> It's just somewhat further down the TODO list, and I wanted to
> have the new cutting code finally available for others to test
> and maybe debug.

 Ok, I'm fine with it. :)

Lars.

> 
> Klaus
> 
> _______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
>

Patch

diff --git a/PLUGINS/src/dvbhddevice/dvbhdffdevice.h b/PLUGINS/src/dvbhddevice/dvbhdffdevice.h
index 439ec9b..10882ae 100644
--- a/PLUGINS/src/dvbhddevice/dvbhdffdevice.h
+++ b/PLUGINS/src/dvbhddevice/dvbhdffdevice.h
@@ -10,8 +10,8 @@ 
 #define __DVBHDFFDEVICE_H
 
 #include "hdffcmd.h"
-#include "vdr/dvbdevice.h"
-#include "vdr/dvbspu.h"
+#include <vdr/dvbdevice.h>
+#include <vdr/dvbspu.h>
 
 /// The cDvbHdFfDevice implements a DVB device which can be accessed through the Linux DVB driver API.
 
diff --git a/PLUGINS/src/dvbsddevice/dvbsdffdevice.h b/PLUGINS/src/dvbsddevice/dvbsdffdevice.h
index bd74cde..eff1511 100644
--- a/PLUGINS/src/dvbsddevice/dvbsdffdevice.h
+++ b/PLUGINS/src/dvbsddevice/dvbsdffdevice.h
@@ -9,8 +9,8 @@ 
 #ifndef __DVBSDFFDEVICE_H
 #define __DVBSDFFDEVICE_H
 
-#include "vdr/dvbdevice.h"
-#include "vdr/dvbspu.h"
+#include <vdr/dvbdevice.h>
+#include <vdr/dvbspu.h>
 
 /// The cDvbSdFfDevice implements a DVB device which can be accessed through the Linux DVB driver API.
 
diff --git a/PLUGINS/src/dvbsddevice/dvbsdffosd.h b/PLUGINS/src/dvbsddevice/dvbsdffosd.h
index 8a1bc62..762cc8a 100644
--- a/PLUGINS/src/dvbsddevice/dvbsdffosd.h
+++ b/PLUGINS/src/dvbsddevice/dvbsdffosd.h
@@ -9,7 +9,7 @@ 
 #ifndef __DVBSDFFODF_H
 #define __DVBSDFFODF_H
 
-#include "vdr/osd.h"
+#include <vdr/osd.h>
 
 class cDvbOsdProvider : public cOsdProvider {
 private:

Privacy Policy