LinuxTV Patchwork [ANNOUNCE] VDR developer version 1.7.28

login
register
mail settings
Submitter Klaus Schmidinger
Date July 9, 2012, 8:29 p.m.
Message ID <4FFB3F13.6080602@tvdr.de>
Download mbox | patch
Permalink /patch/13289/
State New
Headers show

Comments

Klaus Schmidinger - July 9, 2012, 8:29 p.m.
On 09.07.2012 18:57, Joerg Bornkessel wrote:
>
>> VDR developer version 1.7.28 is now available at
> .
>>     "LCARS" is the new default skin of VDR. It requires at least a 4bpp (16 color) full
>>     screen OSD, but you can still operate it if your OSD can handle only fewer colors
>>     (in which case you may want to switch to the "ST:TNG" or "Classic VDR" skin).
>
> * QA Notice: Package triggers severe warnings which indicate that it
> *            may exhibit random runtime failures.
> * skinlcars.c:518:39: warning: passing NULL to non-pointer argument 2 of ‘cString ChannelString(const cChannel*, int)’ [-Wconversion-null]
>
> on compile with gcc-4.7.1

This has already been reported (I assume by someone on vdr-portal.de, because I don't
have a name associated with this fix ;-).



Klaus
Joerg Bornkessel - July 10, 2012, 8:18 p.m.
> On 09.07.2012 18:57, Joerg Bornkessel wrote:
>>
>>> VDR developer version 1.7.28 is now available at
>> .
>>>     "LCARS" is the new default skin of VDR. It requires at least a 4bpp (16 color) full
>>>     screen OSD, but you can still operate it if your OSD can handle only fewer colors
>>>     (in which case you may want to switch to the "ST:TNG" or "Classic VDR" skin).
>>
>> * QA Notice: Package triggers severe warnings which indicate that it
>> *            may exhibit random runtime failures.
>> * skinlcars.c:518:39: warning: passing NULL to non-pointer argument 2 of ‘cString ChannelString(const cChannel*, int)’ [-Wconversion-null]
>>
>> on compile with gcc-4.7.1

> This has already been reported (I assume by someone on vdr-portal.de, because I don't
> have a name associated with this fix ;-).

oops, didn't read it, leaved before; to much blabla about the lcars
scin ;)

anyway, works with you fix

Patch

--- skinlcars.c 2012/06/04 08:53:57     2.5
+++ skinlcars.c 2012/06/04 09:35:43     2.6
@@ -515,7 +515,7 @@ 
    else if (Number)
       ChNumber = cString::sprintf("%d-", Number);
    else
-     ChName = ChannelString(NULL, NULL);
+     ChName = ChannelString(NULL, 0);
    osd->DrawText(xc00, yc00, ChNumber, Theme.Color(clrChannelFrameFg), frameColor, tallFont, xc02 - xc00, yc02 - yc00, taTop | taRight | taBorder);
    osd->DrawText(xc03, yc00, ChName, Theme.Color(clrChannelName), Theme.Color(clrBackground), tallFont, xi - xc03 - lineHeight, 0, taTop | taLeft);
    lastSignalDisplay = 0;

Privacy Policy