LinuxTV Patchwork vdr 1.7.23: patch for handling symlinks in recordings directory as earlier

login
register
mail settings
Submitter sundararaj reel
Date Jan. 17, 2012, 1:26 p.m.
Message ID <CAD9BhHuM+2T7MQoCKF2cuzOh8Rv5YdnhNzSqDQh0zaSNTE2EJg@mail.gmail.com>
Download mbox | patch
Permalink /patch/12924/
State New
Headers show

Comments

sundararaj reel - Jan. 17, 2012, 1:26 p.m.
Hi,

I am attaching a patch for vdr 1.7.23 for the problem described here:
http://www.vdr-portal.de/board1-news/board2-vdr-news/p1047199-announce-vdr-developer-version-1-7-23/#post1047199

There appears to be a problem in listing recordings due to a bug fix
in vdr 1.7.23. "Fixed handling symbolic links in
cRecordings::ScanVideoDir()"

The attached patch just disables the translation of symbolic links to
"real" paths. So that all recordings appear to be under the same
(recordings) directory tree, as it was earlier.

Please reply with your results.
Klaus Schmidinger - Jan. 25, 2012, 9:29 a.m.
On 17.01.2012 14:26, sundararaj reel wrote:
> Hi,
>
> I am attaching a patch for vdr 1.7.23 for the problem described here:
> http://www.vdr-portal.de/board1-news/board2-vdr-news/p1047199-announce-vdr-developer-version-1-7-23/#post1047199
>
> There appears to be a problem in listing recordings due to a bug fix
> in vdr 1.7.23. "Fixed handling symbolic links in
> cRecordings::ScanVideoDir()"
>
> The attached patch just disables the translation of symbolic links to
> "real" paths. So that all recordings appear to be under the same
> (recordings) directory tree, as it was earlier.
>
> Please reply with your results.

Can somebody who has actually this use case please confirm
whether this patch fixes the problem?

Klaus
Oliver Endriss - Jan. 25, 2012, 1:11 p.m.
On Wednesday 25 January 2012 10:29:16 Klaus Schmidinger wrote:
> On 17.01.2012 14:26, sundararaj reel wrote:
> > Hi,
> >
> > I am attaching a patch for vdr 1.7.23 for the problem described here:
> > http://www.vdr-portal.de/board1-news/board2-vdr-news/p1047199-announce-vdr-developer-version-1-7-23/#post1047199
> >
> > There appears to be a problem in listing recordings due to a bug fix
> > in vdr 1.7.23. "Fixed handling symbolic links in
> > cRecordings::ScanVideoDir()"
> >
> > The attached patch just disables the translation of symbolic links to
> > "real" paths. So that all recordings appear to be under the same
> > (recordings) directory tree, as it was earlier.
> >
> > Please reply with your results.
> 
> Can somebody who has actually this use case please confirm
> whether this patch fixes the problem?

Confirmed.

Without this patch, symbolic links are not displayed
correctly on my machine.

Oliver

Patch

diff --git a/recording.c b/recording.c
index cf35bb7..5772dab 100644
--- a/recording.c
+++ b/recording.c
@@ -1120,9 +1120,13 @@  void cRecordings::ScanVideoDir(const char *DirName, bool Foreground, int LinkLev
                     continue;
                     }
                  Link = 1;
+#if 0 
+                 // do not resolve the symbolic links in paths to real path
+                 // thereby keeping all the recordings under one directory
                  buffer = ReadLink(buffer);
                  if (!*buffer)
                     continue;
+#endif
                  if (stat(buffer, &st) != 0)
                     continue;
                  }

Privacy Policy