LinuxTV Patchwork LiveBuffer for vdr 1.7.x

login
register
mail settings
Submitter Marc
Date Dec. 23, 2011, 12:27 p.m.
Message ID <4EF473A6.2030308@ekass.net>
Download mbox | patch
Permalink /patch/12918/
State New
Headers show

Comments

Marc - Dec. 23, 2011, 12:27 p.m.
On 23/12/2011 12:11, Dominic Evans wrote:
>> It's a patch from yaVDR and it doesn't apply to the vdr source tree as is
>> (at least for me).
> Here's the patch from yaVDR rebased to apply to vanilla 1.7.21 sources:
>
> https://gist.github.com/1513894
>
> https://raw.github.com/gist/1513894
>
> _______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
It works, thanks !

There is a typo error in vdr.c but that's all.

For gentoo users, I attached the patches I use. I relocated some hunk of 
config.c and config.h and renamed USE_LIVEBUFFER to LIVEBUFFER in Makefile.

Patch the ebuild and put the other patch in 
/etc/portage/patches/media-video/vdr-1.7.21 (I use the epatch_user tool 
instead of the script, see the ebuild patch).

Marc.
Rene Hertell - Jan. 1, 2012, 5:41 p.m.
On 23.12.2011 14:27 , Marc wrote:
> There is a typo error in vdr.c but that's all.
>
> For gentoo users, I attached the patches I use. I relocated some hunk of
> config.c and config.h and renamed USE_LIVEBUFFER to LIVEBUFFER in Makefile.
>
> Patch the ebuild and put the other patch in
> /etc/portage/patches/media-video/vdr-1.7.21 (I use the epatch_user tool
> instead of the script, see the ebuild patch).

Hi Marc,

I'm having trouble in getting the patch you posted to work in my setup. 
Could you please check if you find something that i screwed up?

http://paste.me.uk/1484.html

I have saved the patch as: 
0001-opt-96-livebuffer12-rmm.dpatch-rebased-onto-1.7.21.patch

What i did was that i deleted the message-headers etc from the file, and 
left the first row to be: diff --git a/Makefile b/Makefile



Best Regards,

René
Marc - Jan. 1, 2012, 6:23 p.m.
On 01/01/2012 18:41, René wrote:
> On 23.12.2011 14:27 , Marc wrote:
>> There is a typo error in vdr.c but that's all.
>>
>> For gentoo users, I attached the patches I use. I relocated some hunk of
>> config.c and config.h and renamed USE_LIVEBUFFER to LIVEBUFFER in 
>> Makefile.
>>
>> Patch the ebuild and put the other patch in
>> /etc/portage/patches/media-video/vdr-1.7.21 (I use the epatch_user tool
>> instead of the script, see the ebuild patch).
>
> Hi Marc,
>
> I'm having trouble in getting the patch you posted to work in my 
> setup. Could you please check if you find something that i screwed up?
>
> http://paste.me.uk/1484.html
>
> I have saved the patch as: 
> 0001-opt-96-livebuffer12-rmm.dpatch-rebased-onto-1.7.21.patch
>
> What i did was that i deleted the message-headers etc from the file, 
> and left the first row to be: diff --git a/Makefile b/Makefile
>
>
>
> Best Regards,
>
> René
>
> _______________________________________________
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Hi René,

You can watch the output of the patch 
(/var/tmp/portage/media-video/vdr-1.7.21-r2/temp/0001-opt-96-livebuffer12-rmm.dpatch-rebased-onto-1.7.21.patch.out) 
and see where it fails.

vdr 1.7.22 is out now on vdr-devel overlay. I'll post an updated patch 
for it tomorrow. It could work better on your configuration.

Regards,

Marc.
Rene Hertell - Jan. 1, 2012, 7:44 p.m.
On 01.01.2012 20:23 , Marc wrote:
> Hi René,
>
> You can watch the output of the patch
> (/var/tmp/portage/media-video/vdr-1.7.21-r2/temp/0001-opt-96-livebuffer12-rmm.dpatch-rebased-onto-1.7.21.patch.out)
> and see where it fails.
>
> vdr 1.7.22 is out now on vdr-devel overlay. I'll post an updated patch
> for it tomorrow. It could work better on your configuration.

Hi Marc,

I pasted the output over here: http://pastebin.com/8eMsEuMf

It looks that it can't find the files to patch. Maybe the patch was not 
compatible with Gentoo?

It would be great if you could send an updated ebuild to 1.7.22 :-) I 
really miss the days when i updated my vdr on every release.. Now i have 
been "stuck" with 1.6.x for ages..

Do you think that it would be possible to add the livebuffer-patch back 
to the official gentoo overlay? Even better if it could be added as a 
basic feature of vdr (that could be turned on/off from the settings :-) 
Klaus? Please, please, pleaaaaase :-)


Regards,

René
VDR User - Jan. 1, 2012, 8:13 p.m.
On Sun, Jan 1, 2012 at 11:44 AM, René <linuxtv@hertell.com> wrote:
> the official gentoo overlay? Even better if it could be added as a basic
> feature of vdr (that could be turned on/off from the settings :-) Klaus?
> Please, please, pleaaaaase :-)

There was talk of this some time ago, though I don't think anything
solid came of it. I personally am not interested in it unless ram came
be used for the buffer storage. Having a harddrive (or even worse, an
ssd) in a constant write state 24/7 is not something I'd like to do.
Whatever the case, I think you'll be stuck with the patch for a while.
Rene Hertell - Jan. 1, 2012, 9:31 p.m.
On 01.01.2012 22:13 , VDR User wrote:
> There was talk of this some time ago, though I don't think anything
> solid came of it. I personally am not interested in it unless ram came
> be used for the buffer storage. Having a harddrive (or even worse, an
> ssd) in a constant write state 24/7 is not something I'd like to do.
> Whatever the case, I think you'll be stuck with the patch for a while.

I have set my livebuffer to use 2gb memory (hdd). If i would have 4gb 
ram (now i have just 1gb), then i would use a 2gb ramdisk for 
livebuffer, and the rest for my system. This would be more than enough.. 
:-) But having a patch working for vdr is ok too :-)

René
VDR User - Jan. 2, 2012, 12:19 a.m.
On Sun, Jan 1, 2012 at 1:31 PM, René <linuxtv@hertell.com> wrote:
>> There was talk of this some time ago, though I don't think anything
>> solid came of it. I personally am not interested in it unless ram came
>> be used for the buffer storage. Having a harddrive (or even worse, an
>> ssd) in a constant write state 24/7 is not something I'd like to do.
>> Whatever the case, I think you'll be stuck with the patch for a while.
>
> I have set my livebuffer to use 2gb memory (hdd). If i would have 4gb ram
> (now i have just 1gb), then i would use a 2gb ramdisk for livebuffer, and
> the rest for my system. This would be more than enough.. :-) But having a
> patch working for vdr is ok too :-)

RAM is cheap enough now days that having plenty of it isn't a problem
for most people. For example, 4GB will cost you less than a few hours
at the pub with friends. :)
Torgeir Veimo - Jan. 2, 2012, 3:12 a.m.
On 2 January 2012 10:19, VDR User <user.vdr@gmail.com> wrote:
> On Sun, Jan 1, 2012 at 1:31 PM, René <linuxtv@hertell.com> wrote:
>>> There was talk of this some time ago, though I don't think anything
>>> solid came of it. I personally am not interested in it unless ram came
>>> be used for the buffer storage. Having a harddrive (or even worse, an
>>> ssd) in a constant write state 24/7 is not something I'd like to do.
>>> Whatever the case, I think you'll be stuck with the patch for a while.
>>
>> I have set my livebuffer to use 2gb memory (hdd). If i would have 4gb ram
>> (now i have just 1gb), then i would use a 2gb ramdisk for livebuffer, and
>> the rest for my system. This would be more than enough.. :-) But having a
>> patch working for vdr is ok too :-)
>
> RAM is cheap enough now days that having plenty of it isn't a problem
> for most people. For example, 4GB will cost you less than a few hours
> at the pub with friends. :)

The OP probably meant to have the option to use RAM directly without
fiddling with a RAM disk setup.
Rene Hertell - Jan. 2, 2012, 7:21 a.m.
On 02.01.2012 5:12 , Torgeir Veimo wrote:
>> RAM is cheap enough now days that having plenty of it isn't a problem
>> for most people. For example, 4GB will cost you less than a few hours
>> at the pub with friends. :)
>
> The OP probably meant to have the option to use RAM directly without
> fiddling with a RAM disk setup.

This could be a nice feature, but setting up a ramdisk is also pretty 
easy..

-René

Patch

--- vdr-1.7.21-r1.ebuild	2011-10-25 03:10:08.000000000 +0200
+++ vdr-1.7.21-r2.ebuild	2011-12-23 13:10:44.000000000 +0100
@@ -7,7 +7,7 @@ 
 inherit eutils flag-o-matic multilib
 
 # Switches supported by extensions-patch
-EXT_PATCH_FLAGS="alternatechannel cutterlimit
+EXT_PATCH_FLAGS="alternatechannel cutterlimit livebuffer
 	ddepgentry dvlvidprefer graphtft hardlinkcutter jumpplay
 	lnbshare liemikuutio mainmenuhooks menuorg noepg pinplugin setup timerinfo
 	yaepg lircsettings"
@@ -295,27 +295,8 @@ 
 
 	fi
 
-	# apply local patches defined by variable VDR_LOCAL_PATCHES_DIR
-	if test -n "${VDR_LOCAL_PATCHES_DIR}"; then
-		local dir_tmp_var
-		local LOCALPATCHES_SUBDIR=${PV}
-		for dir_tmp_var in allversions-fallback ${PV%_p*} ${PV} ; do
-			if [[ -d ${VDR_LOCAL_PATCHES_DIR}/${dir_tmp_var} ]]; then
-				LOCALPATCHES_SUBDIR="${dir_tmp_var}"
-			fi
-		done
-
-		echo
-		if [[ ${LOCALPATCHES_SUBDIR} == ${PV} ]]; then
-			einfo "Applying local patches"
-		else
-			einfo "Applying local patches (Using subdirectory: ${LOCALPATCHES_SUBDIR})"
-		fi
-
-		for LOCALPATCH in ${VDR_LOCAL_PATCHES_DIR}/${LOCALPATCHES_SUBDIR}/*.{diff,patch}; do
-			test -f "${LOCALPATCH}" && epatch "${LOCALPATCH}"
-		done
-	fi
+	# apply local patches
+	epatch_user
 
 	if [[ -n "${VDRSOURCE_DIR}" ]]; then
 		cp -r "${S}" "${T}"/source-tree

Privacy Policy