| Message ID | f6e576dde2640bcf6a79d157f83c96ca13c453a3.1505826082.git.dave.stevenson@raspberrypi.org (mailing list archive) |
|---|---|
| State | Obsoleted, archived |
| Delegated to: | Hans Verkuil |
| Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1duIHO-0000tj-C0; Tue, 19 Sep 2017 13:09:34 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750998AbdISNJc (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Tue, 19 Sep 2017 09:09:32 -0400 Received: from mx07-00252a01.pphosted.com ([62.209.51.214]:28471 "EHLO mx07-00252a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbdISNJc (ORCPT <rfc822;linux-media@vger.kernel.org>); Tue, 19 Sep 2017 09:09:32 -0400 Received: from pps.filterd (m0102628.ppops.net [127.0.0.1]) by mx07-00252a01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v8JD9UD7006048 for <linux-media@vger.kernel.org>; Tue, 19 Sep 2017 14:09:30 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.org; h=from : to : cc : subject : date : message-id : in-reply-to : references : in-reply-to : references; s=pp; bh=wVvKS7iOYUH6F/DarbxU5377YwTNtwlmGfafK4k62C4=; b=eCwSoQNL1aBCoDZDuN+Dzf0zsY411UB089HoB4lH+XuEURpmDs8FV1uawxqf19vqilgR k8PnOI54bs2QUQcfPXDeNPrZ0rkwwGY+Yp8llwOgW+zi/9eoai8ywjMNfKtwvE50NfrP ETYQ+dqJc7C0lkADkor4784b5HvSMWqMMH84RFzQtvP77IC7I9Xc/gCwrXcGB8yQWEhr WIRtIHzpEJG9lMePL9Bpc1CN9i+7WBZFDSuoHLQT5Aebr4Fz1vqIxV8stBN1w0UMT0x8 r4ldEKb3FesWBfTSlEo6pu65hU6+bzJKdxlyq2F/fe+ZYbhLEP/LKr3dzSqhOVkWsCay yQ== Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by mx07-00252a01.pphosted.com with ESMTP id 2d0sc01jc8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK) for <linux-media@vger.kernel.org>; Tue, 19 Sep 2017 14:09:30 +0100 Received: by mail-wm0-f72.google.com with SMTP id u138so3873605wmu.2 for <linux-media@vger.kernel.org>; Tue, 19 Sep 2017 06:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=wVvKS7iOYUH6F/DarbxU5377YwTNtwlmGfafK4k62C4=; b=A4gQBiHAkvVJXgtWvw/QF4IdiY2a/aTImPZ+osafAlweP5NwmZTjSzER2bzRZ4PWKn p0MOk7k6ZyQLoIlGGtVaYJ0xcjt2SqbFF8BB4IXy+vXuE4LO/jawTlVVVOcvebAiMguF 1olW5gyMHaYkmrYgBlxTVZTjnlMYjJe/9jV64+QmlurhtLjrGfoZVS88pwQSBwAl/Pc2 i1Ce6o49sBiaXutlF1CJfvcu6ltLkorBY7rwnS04qkmPkT/fC4NzJqGdfE89+FIUyZPx cjS3uEWSU1tY5YgqZCaaU7Na1wyg5iBOEId6iHI/5ficO1bG+nRruw/XZ8SK9aUhOghp d9aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=wVvKS7iOYUH6F/DarbxU5377YwTNtwlmGfafK4k62C4=; b=kz2QCftJdx0VzBnxUvSNaK2DxVbmvEonaGZMV4Efe05rPd+NP/mTh2XWqpTI4NNUUo sthrpcc0K5Ir3ubsAUHeLqcEOXzOJY8ML8aoaFhGDo/tVL1MuRDuk8hTvUDVf86w+Fkr lb+9QS+ROVYZiqQP7FM+sMJDlJ6jpJs1nOO4zxXZhLRyVMtv7qte3QyYBcZ17S1DfWj8 WxYPtlrLI76M2kwPNhGBju4IFMf2MdM56lMHe8lGymzqfLhQH+aTzgSMI0DKpp3dnKP6 KAm9Uqt4W5T713RUtArkYqXI30JaeAQbyzoi/C0WMmwvJ80kvt4Cvrurgmo3NjO/sChl vbXA== X-Gm-Message-State: AHPjjUjb98rJas9rnx/alpRdpFPAyx9EmN6P5Bpx1XtDcX7GxZH8EDTm eSRA1viBzgbyxzmJ61Uc+0ogOgm+xFh8XyA2jxccQYjN39SYyAu5rapmG2402uup8KTdc58F/kP CqM8vIAjqgJPYS3Lu4/s+Fg== X-Received: by 10.223.198.130 with SMTP id j2mr1449661wrg.52.1505826570208; Tue, 19 Sep 2017 06:09:30 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCQFfQLVRZD3fo2GE868O/bi3j9D3C0/HTsxsvMsvgDPT8nlyqlf+cCNqqpptPpfRZ6rQ4/eA== X-Received: by 10.223.198.130 with SMTP id j2mr1449650wrg.52.1505826570024; Tue, 19 Sep 2017 06:09:30 -0700 (PDT) Received: from dave-VirtualBox.pitowers.org ([217.33.127.173]) by smtp.googlemail.com with ESMTPSA id a195sm1119170wme.34.2017.09.19.06.09.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Sep 2017 06:09:29 -0700 (PDT) From: Dave Stevenson <dave.stevenson@raspberrypi.org> To: Mats Randgaard <matrandg@cisco.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hans.verkuil@cisco.com>, Philipp Zabel <p.zabel@pengutronix.de>, linux-media@vger.kernel.org Cc: Dave Stevenson <dave.stevenson@raspberrypi.org> Subject: [PATCH 1/3] [media] tc358743: Correct clock mode reported in g_mbus_config Date: Tue, 19 Sep 2017 14:08:51 +0100 Message-Id: <f6e576dde2640bcf6a79d157f83c96ca13c453a3.1505826082.git.dave.stevenson@raspberrypi.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <cover.1505826082.git.dave.stevenson@raspberrypi.org> References: <cover.1505826082.git.dave.stevenson@raspberrypi.org> In-Reply-To: <cover.1505826082.git.dave.stevenson@raspberrypi.org> References: <cover.1505826082.git.dave.stevenson@raspberrypi.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-09-19_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709190186 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Dave Stevenson
Sept. 19, 2017, 1:08 p.m. UTC
Support for non-continuous clock had previously been added via
device tree, but a comment and the value reported by g_mbus_config
still stated that it wasn't supported.
Remove the comment, and return the correct value in g_mbus_config.
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
---
drivers/media/i2c/tc358743.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Comments
On Tue, 2017-09-19 at 14:08 +0100, Dave Stevenson wrote: > Support for non-continuous clock had previously been added via > device tree, but a comment and the value reported by g_mbus_config > still stated that it wasn't supported. > Remove the comment, and return the correct value in g_mbus_config. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> > --- > drivers/media/i2c/tc358743.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/tc358743.c > b/drivers/media/i2c/tc358743.c > index e6f5c36..6b0fd07 100644 > --- a/drivers/media/i2c/tc358743.c > +++ b/drivers/media/i2c/tc358743.c > @@ -1461,8 +1461,9 @@ static int tc358743_g_mbus_config(struct > v4l2_subdev *sd, > > cfg->type = V4L2_MBUS_CSI2; > > - /* Support for non-continuous CSI-2 clock is missing in the > driver */ > - cfg->flags = V4L2_MBUS_CSI2_CONTINUOUS_CLOCK; > + cfg->flags = state->bus.flags & > + (V4L2_MBUS_CSI2_CONTINUOUS_CLOCK | > + V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK); Acked-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index e6f5c36..6b0fd07 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1461,8 +1461,9 @@ static int tc358743_g_mbus_config(struct v4l2_subdev *sd, cfg->type = V4L2_MBUS_CSI2; - /* Support for non-continuous CSI-2 clock is missing in the driver */ - cfg->flags = V4L2_MBUS_CSI2_CONTINUOUS_CLOCK; + cfg->flags = state->bus.flags & + (V4L2_MBUS_CSI2_CONTINUOUS_CLOCK | + V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK); switch (state->csi_lanes_in_use) { case 1: