Message ID | 1457053344-28992-1-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
---|---|
State | Rejected, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84) (envelope-from <linux-media-owner@vger.kernel.org>) id 1abe8y-00069R-0Y; Fri, 04 Mar 2016 01:03:00 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.76/mailfrontend-5) with esmtp id 1abe8u-0007Od-9f; Fri, 04 Mar 2016 02:02:59 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932158AbcCDBCk (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 3 Mar 2016 20:02:40 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:39810 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756835AbcCDBCj (ORCPT <rfc822; linux-media@vger.kernel.org>); Thu, 3 Mar 2016 20:02:39 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O3H00D7KPKBTG30@mailout2.w1.samsung.com>; Fri, 04 Mar 2016 01:02:35 +0000 (GMT) X-AuditID: cbfec7f5-f79b16d000005389-8b-56d8deaa2dfd Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 14.19.21385.AAED8D65; Fri, 4 Mar 2016 01:02:34 +0000 (GMT) Received: from localhost.localdomain ([10.113.63.52]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O3H005BGPK4PQ50@eusync1.samsung.com>; Fri, 04 Mar 2016 01:02:34 +0000 (GMT) From: Krzysztof Kozlowski <k.kozlowski@samsung.com> To: Sylwester Nawrocki <s.nawrocki@samsung.com>, Mauro Carvalho Chehab <mchehab@osg.samsung.com>, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Arnd Bergmann <arnd@arndb.de>, Krzysztof Kozlowski <k.kozlowski@samsung.com> Subject: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM Date: Fri, 04 Mar 2016 10:02:24 +0900 Message-id: <1457053344-28992-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 2.5.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLJMWRmVeSWpSXmKPExsVy+t/xy7qr7t0IM5h4Tcvi76Rj7BavXxha bHp8jdXi8q45bBY9G7ayWsw4v4/JYvWzCovDb9pZHTg8fv+axOixeUm9x5b+u+wefVtWMXp8 3iQXwBrFZZOSmpNZllqkb5fAlbH0ZlLBX7aKbW0nmRsY37N2MXJySAiYSPTP2A1li0lcuLee rYuRi0NIYCmjRM/aX1DOf0aJxytbGEGq2ASMJTYvXwKWEBF4xSjRf/ArE0iCWSBAYsLFlWCj hAVCJf7+nwoWZxFQlZhyHWIFr4C7xJeH64AGcQCtk5NYcCF9AiP3AkaGVYyiqaXJBcVJ6blG esWJucWleel6yfm5mxghgfJ1B+PSY1aHGAU4GJV4eG80XA8TYk0sK67MPcQowcGsJMKr1Hcj TIg3JbGyKrUoP76oNCe1+BCjNAeLkjjvzF3vQ4QE0hNLUrNTUwtSi2CyTBycUg2M2h8zN4Rt apvztTDJqeTNnSc6Xbee8ZukeDpM0rhfvXf114q7rdeWrGrL/c1sfunki0sx64rmi98vcRKv eKUj+2dfQl5pouCh6Swcm370h12psec6pCRdvU+TJ9ogJGi1m+Pn4Av8F3SXslWf3nOjQ+pY Un3Tv7Y1tlF1gRx/In6piU0oV7ZWYinOSDTUYi4qTgQA4STFORACAAA= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.3.4.5717 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, NO_URI_HTTPS 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_RCPTS_TO_X5 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __TO_MALFORMED_2 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0' |
Commit Message
Krzysztof Kozlowski
March 4, 2016, 1:02 a.m. UTC
The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet
direct dependencies.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
Changes since v1:
1. Fix comments from Arnd: VIDEO_OMAP3 does not require it, however
VIDEO_S5P_FIMC still needs it.
---
drivers/media/platform/exynos4-is/Kconfig | 1 +
1 file changed, 1 insertion(+)
Comments
Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
> + depends on HAS_IOMEM # For MFD_SYSCON
^^^^^^^^^^^^^^^^
I think this comment is not necessary, it's also highly unusual. On
other words: other patches like this don't add such comments.
You can always use "git blame" to find out why some line has changed the
way it changed ...
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04.03.2016 16:03, Holger Schurig wrote: > Krzysztof Kozlowski <k.kozlowski@samsung.com> writes: > >> + depends on HAS_IOMEM # For MFD_SYSCON > ^^^^^^^^^^^^^^^^ > > I think this comment is not necessary, it's also highly unusual. On > other words: other patches like this don't add such comments. > > You can always use "git blame" to find out why some line has changed the > way it changed ... No problem, I can remove it. I thought it might be useful since this dependency is not for the driver but for selected item. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/04/2016 02:02 AM, Krzysztof Kozlowski wrote: > The MFD_SYSCON depends on HAS_IOMEM so when selecting > it avoid unmet direct dependencies. > diff --git a/drivers/media/platform/exynos4-is/Kconfig > b/drivers/media/platform/exynos4-is/Kconfig > index 57d42c6172c5..c4317b99d257 100644 > --- a/drivers/media/platform/exynos4-is/Kconfig > +++ b/drivers/media/platform/exynos4-is/Kconfig > @@ -17,6 +17,7 @@ config VIDEO_S5P_FIMC > tristate "S5P/EXYNOS4 FIMC/CAMIF camera interface driver" > depends on I2C > depends on HAS_DMA > + depends on HAS_IOMEM # For MFD_SYSCON > select VIDEOBUF2_DMA_CONTIG > select V4L2_MEM2MEM_DEV > select MFD_SYSCON While we are already at it, shouldn't "depends on HAS_IOMEM" be instead added at the top level entry in this Kconfig file, i.e. "config VIDEO_SAMSUNG_EXYNOS4_IS" ? For things like devm_ioremap_resource() depending on HAS_IOMEM and used in all the sub-drivers, enabled by VIDEO_SAMSUNG_EXYNOS4_IS?
2016-03-04 20:02 GMT+09:00 Sylwester Nawrocki <s.nawrocki@samsung.com>: > On 03/04/2016 02:02 AM, Krzysztof Kozlowski wrote: >> The MFD_SYSCON depends on HAS_IOMEM so when selecting >> it avoid unmet direct dependencies. > >> diff --git a/drivers/media/platform/exynos4-is/Kconfig >> b/drivers/media/platform/exynos4-is/Kconfig >> index 57d42c6172c5..c4317b99d257 100644 >> --- a/drivers/media/platform/exynos4-is/Kconfig >> +++ b/drivers/media/platform/exynos4-is/Kconfig >> @@ -17,6 +17,7 @@ config VIDEO_S5P_FIMC >> tristate "S5P/EXYNOS4 FIMC/CAMIF camera interface driver" >> depends on I2C >> depends on HAS_DMA >> + depends on HAS_IOMEM # For MFD_SYSCON >> select VIDEOBUF2_DMA_CONTIG >> select V4L2_MEM2MEM_DEV >> select MFD_SYSCON > > While we are already at it, shouldn't "depends on HAS_IOMEM" > be instead added at the top level entry in this Kconfig file, > i.e. "config VIDEO_SAMSUNG_EXYNOS4_IS" ? For things like > devm_ioremap_resource() depending on HAS_IOMEM and used in all > the sub-drivers, enabled by VIDEO_SAMSUNG_EXYNOS4_IS? Indeed that would make sense... but now after some more looking at it, even this patch is not needed. All these drivers are children of MEDIA_SUPPORT which already depends on HAS_IOMEM. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/exynos4-is/Kconfig b/drivers/media/platform/exynos4-is/Kconfig index 57d42c6172c5..c4317b99d257 100644 --- a/drivers/media/platform/exynos4-is/Kconfig +++ b/drivers/media/platform/exynos4-is/Kconfig @@ -17,6 +17,7 @@ config VIDEO_S5P_FIMC tristate "S5P/EXYNOS4 FIMC/CAMIF camera interface driver" depends on I2C depends on HAS_DMA + depends on HAS_IOMEM # For MFD_SYSCON select VIDEOBUF2_DMA_CONTIG select V4L2_MEM2MEM_DEV select MFD_SYSCON