Latest version of em28xx / em28xx-dvb patch for PCTV 290e
Commit Message
Two more patches:
a) clean up resources more reliably if em28xx_init_dev() fails,
b) move two printk() statements outside the mutex lock
Cheers,
Chris
Signed-off-by: Chris Rankin <rankincj@yahoo.com>
Comments
Em 18-08-2011 15:11, Chris Rankin escreveu:
> Two more patches:
>
> a) clean up resources more reliably if em28xx_init_dev() fails,
> b) move two printk() statements outside the mutex lock
>
> Cheers,
> Chris
>
> Signed-off-by: Chris Rankin <rankincj@yahoo.com>
>
Chris,
Please, never send two patches at the same email. This doesn't
work: patchwork and all tools used by me and other maintainers
will either discard one or both patches, or even merge both into
one.
Also, when you're sending us a series of patches, be sure to
number the patch series with PATCH 01/xx (where xx is the last
patch), and put a different subject on each patch. There's no
need to reply the original thread.
See how all your patches will appear for me:
https://patchwork.kernel.org/project/linux-media/list/?submitter=4542
It is very hard to know that you have a complese series of patches,
instead of just a new version of a patch that you've already sent.
By default, the last case is assumed, as it is somewhat common to reply
to a patch with a new version of it (yet, the best practice would be
to rename the new patch series as PATCH v2, PATCH v3, etc). If I wouldn't
notice this before I would simply mark all patches except by the last
one as superseded, and just get the last one.
Thanks!
Mauro
PS.: I suggest you to take a look at the wiki page bellow. It helps
people about what's the expected way for you to submit your work
http://linuxtv.org/wiki/index.php/Development:_How_to_submit_patches
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
@@ -1186,8 +1186,8 @@
list_for_each_entry(dev, &em28xx_devlist, devlist) {
ops->init(dev);
}
- printk(KERN_INFO "Em28xx: Initialized (%s) extension\n", ops->name);
mutex_unlock(&em28xx_devlist_mutex);
+ printk(KERN_INFO "Em28xx: Initialized (%s) extension\n", ops->name);
return 0;
}
EXPORT_SYMBOL(em28xx_register_extension);
@@ -1200,9 +1200,9 @@
list_for_each_entry(dev, &em28xx_devlist, devlist) {
ops->fini(dev);
}
- printk(KERN_INFO "Em28xx: Removed (%s) extension\n", ops->name);
list_del(&ops->next);
mutex_unlock(&em28xx_devlist_mutex);
+ printk(KERN_INFO "Em28xx: Removed (%s) extension\n", ops->name);
}
EXPORT_SYMBOL(em28xx_unregister_extension);