Message ID | 1397044446-2257-1-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
---|---|
State | Obsoleted, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1WXr6j-00055S-6y; Wed, 09 Apr 2014 13:55:57 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1WXr6h-0006AB-41; Wed, 09 Apr 2014 13:55:57 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932807AbaDILyo (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 9 Apr 2014 07:54:44 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:20475 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932482AbaDILyn (ORCPT <rfc822; linux-media@vger.kernel.org>); Wed, 9 Apr 2014 07:54:43 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N3R0050NIF4M6B0@mailout1.w1.samsung.com>; Wed, 09 Apr 2014 12:54:40 +0100 (BST) X-AuditID: cbfec7f4-b7f796d000005a13-42-534535016ef6 Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 15.3D.23059.10535435; Wed, 09 Apr 2014 12:54:41 +0100 (BST) Content-transfer-encoding: 8BIT Received: from AMDC1943.digital.local ([106.116.151.171]) by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0N3R005VUIEV3R60@eusync1.samsung.com>; Wed, 09 Apr 2014 12:54:41 +0100 (BST) From: Krzysztof Kozlowski <k.kozlowski@samsung.com> To: Kyungmin Park <kyungmin.park@samsung.com>, Andrzej Hajda <a.hajda@samsung.com>, Mauro Carvalho Chehab <m.chehab@samsung.com>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>, Krzysztof Kozlowski <k.kozlowski@samsung.com> Subject: [PATCH] [media] V4L: s5c73m3: Fix build after v4l2_of_get_next_endpoint rename Date: Wed, 09 Apr 2014 13:54:06 +0200 Message-id: <1397044446-2257-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.8.3.2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMLMWRmVeSWpSXmKPExsVy+t/xy7qMpq7BBnNeCVvcWneO1eL1C0OL s01v2C0u75rDZtGzYSurxcV18haH37SzOrB79G1ZxejxeZNcAFMUl01Kak5mWWqRvl0CV8av /gnMBT85Kz4f+8ncwHibo4uRg0NCwETi1oyQLkZOIFNM4sK99WxdjFwcQgJLGSUmfzrCApLg FRCU+DH5HgtIPbOAvMSRS9kgYWYBdYlJ8xYxQ9T3MUn8uHSeFSTBJmAssXn5ErBBIgIHGSWm bDnODNGRIDH780swW1ggUuJl63UmEJtFQFXi8a7FzBDL3CRW3VjODnGRgsSyL2uZJzDyzUJy xyyEO2YhuWMBI/MqRtHU0uSC4qT0XEO94sTc4tK8dL3k/NxNjJCA/LKDcfExq0OMAhyMSjy8 CpYuwUKsiWXFlbmHGCU4mJVEeNsMXIOFeFMSK6tSi/Lji0pzUosPMTJxcEo1MMa7fPhdtcT/ QEHjT8eyHV9Uz/Y3PnuhNVvFuNcmseRB1M1p1tpHv1SKOdssv7dNfdreqE5eLvNVf1tYznic uR4W934Jm1b6uh2LOqb5z4h9pBG36cFRNYE4Dmn7/IfGV/fHnli5b2GmaJD0speacz6fmZAS uSBJt2jzjse7/j2YZbdjReLGGmslluKMREMt5qLiRADumbmiJgIAAA== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.4.9.114819 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1400_1499 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_RCPTS_TO_X5 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Krzysztof Kozlowski
April 9, 2014, 11:54 a.m. UTC
Fix build error after v4l2_of_get_next_endpoint rename (fd9fdb78a9bf:
"[media] of: move graph helpers from drivers/media/v4l2-core..."):
drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function ‘s5c73m3_get_platform_data’:
drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:2: error: implicit declaration of function ‘v4l2_of_get_next_endpoint’ [-Werror=implicit-function-declaration]
drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:10: warning: assignment makes pointer from integer without a cast [enabled by default]
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, 9 Apr 2014, Krzysztof Kozlowski wrote: > Fix build error after v4l2_of_get_next_endpoint rename (fd9fdb78a9bf: > "[media] of: move graph helpers from drivers/media/v4l2-core..."): > > drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function ‘s5c73m3_get_platform_data’: > drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:2: error: implicit declaration of function ‘v4l2_of_get_next_endpoint’ [-Werror=implicit-function-declaration] > drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:10: warning: assignment makes pointer from integer without a cast [enabled by default] > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c > index a4459301b5f8..ee0f57e01b56 100644 > --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c > +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c > @@ -1616,7 +1616,7 @@ static int s5c73m3_get_platform_data(struct s5c73m3 *state) > if (ret < 0) > return -EINVAL; > > - node_ep = v4l2_of_get_next_endpoint(node, NULL); > + node_ep = of_graph_get_next_endpoint(node, NULL); > if (!node_ep) { > dev_warn(dev, "no endpoint defined for node: %s\n", > node->full_name); Acked-by: David Rientjes <rientjes@google.com> The build error that this patch fixes is still present in Linus's tree, and there's been no response to it in two weeks. Any chance of this getting merged?
On 04/23/2014 10:57 PM, David Rientjes wrote: > On Wed, 9 Apr 2014, Krzysztof Kozlowski wrote: > >> Fix build error after v4l2_of_get_next_endpoint rename (fd9fdb78a9bf: >> "[media] of: move graph helpers from drivers/media/v4l2-core..."): >> >> drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function ‘s5c73m3_get_platform_data’: >> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:2: error: implicit declaration of function ‘v4l2_of_get_next_endpoint’ [-Werror=implicit-function-declaration] >> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:10: warning: assignment makes pointer from integer without a cast [enabled by default] >> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> --- >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c >> index a4459301b5f8..ee0f57e01b56 100644 >> --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c >> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c >> @@ -1616,7 +1616,7 @@ static int s5c73m3_get_platform_data(struct s5c73m3 *state) >> if (ret < 0) >> return -EINVAL; >> >> - node_ep = v4l2_of_get_next_endpoint(node, NULL); >> + node_ep = of_graph_get_next_endpoint(node, NULL); >> if (!node_ep) { >> dev_warn(dev, "no endpoint defined for node: %s\n", >> node->full_name); > > Acked-by: David Rientjes <rientjes@google.com> > > The build error that this patch fixes is still present in Linus's tree, > and there's been no response to it in two weeks. Any chance of this > getting merged? I expect a patch fixing this issue to be sent in next batch of the media fixes from Mauro. It has been queued in the media tree: http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?h=fixes&id=41f484d12c0105ce01ea79acdc094fff9124491b Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index a4459301b5f8..ee0f57e01b56 100644 --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c @@ -1616,7 +1616,7 @@ static int s5c73m3_get_platform_data(struct s5c73m3 *state) if (ret < 0) return -EINVAL; - node_ep = v4l2_of_get_next_endpoint(node, NULL); + node_ep = of_graph_get_next_endpoint(node, NULL); if (!node_ep) { dev_warn(dev, "no endpoint defined for node: %s\n", node->full_name);