[v3,media] s5p-mfc: remove meaningless memory bank assignment

Message ID 1394081739-23017-1-git-send-email-sw0312.kim@samsung.com (mailing list archive)
State Awaiting Upstream, archived
Delegated to: Kamil Debski
Headers

Commit Message

Seung-Woo Kim March 6, 2014, 4:55 a.m. UTC
  This patch removes meaningless assignment of memory bank to itself.

Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
change from v2
- simplify description and change typo in subject
change from v1
- fixes subject and adds proper description
---
 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
  

Comments

Sachin Kamat March 6, 2014, 4:59 a.m. UTC | #1
Hi Seung-Woo,

On 6 March 2014 10:25, Seung-Woo Kim <sw0312.kim@samsung.com> wrote:
> This patch removes meaningless assignment of memory bank to itself.
>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---

Thanks for re-doing this.

Acked-by: Sachin Kamat <sachin.kamat@linaro.org>
  

Patch

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
index 2475a3c..ee05f2d 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
@@ -44,8 +44,6 @@  int s5p_mfc_alloc_firmware(struct s5p_mfc_dev *dev)
 		return -ENOMEM;
 	}
 
-	dev->bank1 = dev->bank1;
-
 	if (HAS_PORTNUM(dev) && IS_TWOPORT(dev)) {
 		bank2_virt = dma_alloc_coherent(dev->mem_dev_r, 1 << MFC_BASE_ALIGN_ORDER,
 					&bank2_dma_addr, GFP_KERNEL);