Message ID | 1394017710-671-1-git-send-email-sw0312.kim@samsung.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Kamil Debski |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1WL9gV-0006OT-PX; Wed, 05 Mar 2014 12:08:23 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1WL9gT-0004EY-jQ; Wed, 05 Mar 2014 12:08:23 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754790AbaCELIS (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 5 Mar 2014 06:08:18 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:55690 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754060AbaCELIR (ORCPT <rfc822; linux-media@vger.kernel.org>); Wed, 5 Mar 2014 06:08:17 -0500 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N1Y00FKRMXS1T40@mailout2.samsung.com> for linux-media@vger.kernel.org; Wed, 05 Mar 2014 20:08:16 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.116]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id C5.33.14803.F9507135; Wed, 05 Mar 2014 20:08:16 +0900 (KST) X-AuditID: cbfee691-b7efc6d0000039d3-39-5317059ff0c3 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 7E.3C.28157.F9507135; Wed, 05 Mar 2014 20:08:15 +0900 (KST) Received: from localhost.localdomain ([10.252.75.83]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N1Y004SLMXQ3Y30@mmp1.samsung.com>; Wed, 05 Mar 2014 20:08:15 +0900 (KST) From: Seung-Woo Kim <sw0312.kim@samsung.com> To: linux-media@vger.kernel.org, k.debski@samsung.com, m.chehab@samsung.com Cc: m.szyprowski@samsung.com, sw0312.kim@samsung.com Subject: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment Date: Wed, 05 Mar 2014 20:08:30 +0900 Message-id: <1394017710-671-1-git-send-email-sw0312.kim@samsung.com> X-Mailer: git-send-email 1.7.4.1 In-reply-to: <187b01cf385bb9b4510$%debski@samsung.com> References: <187b01cf385bb9b4510$%debski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNLMWRmVeSWpSXmKPExsWyRsSkRHcBq3iwwcs+Rosfry+wWfRs2Mpq cXGdvMXaI3fZLWZMfsnmwOrRt2UVo8fnTXIBTFFcNimpOZllqUX6dglcGZ1dP1kLTrBXtL56 xtLAuJGti5GTQ0LARKJzz18oW0ziwr31QDYXh5DAUkaJvTM2MHYxcoAVXfjoBRFfxCjxdv8i VpAGIYFWJokfU4NAbDYBHYn9S36DxUUEvCV+n+hkArGZgXpnNW5mAbGFBbwkzi57AhZnEVCV 6PnxHyzOK+Ai0XN7FSvEEQoSC+69BTuIU8BM4tPHFUwQu0wlJq+/ygRyhITAdzaJbVtvM0IM EpD4NvkQC8ShshKbDjBDzJGUOLjiBssERuEFjAyrGEVTC5ILipPSi0z1ihNzi0vz0vWS83M3 MQID9vS/ZxN3MN4/YH2IMRlo3ERmKdHkfGDA55XEGxqbGVmYmpgaG5lbmpEmrCTOm/4oKUhI ID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDY3HqxcfA2NP8XmtVY64wj+1nXcIsTbXO9X21HlJ/ mT4Vc0VtmVMtKD1NzbyjxmpZhqHvjle+j740rreoPK7xTm3+k5vdOSr7XJheZ6//VxykfYXf aSL/wjenzvs8UZzyP2fqsoO3nNJj9s48vIVjHpuLZ930g9Nm9/0M+1bbWvHJt+meXGuMEktx RqKhFnNRcSIAIBj/324CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRmVeSWpSXmKPExsVy+t9jAd35rOLBBus3mFr8eH2BzaJnw1ZW i4vr5C3WHrnLbjFj8ks2B1aPvi2rGD0+b5ILYIpqYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneO NzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMAdqmpFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3 JAiux8gADSSsYczo7PrJWnCCvaL11TOWBsaNbF2MHBwSAiYSFz56dTFyApliEhfurQcKc3EI CSxilHi7fxErSEJIoJVJ4sfUIBCbTUBHYv+S32BxEQFvid8nOplAbGagObMaN7OA2MICXhJn lz0Bi7MIqEr0/PgPFucVcJHoub2KFWKZgsSCe2/ZQGxOATOJTx9XMEHsMpWYvP4q0wRG3gWM DKsYRVMLkguKk9JzjfSKE3OLS/PS9ZLzczcxguPhmfQOxlUNFocYBTgYlXh4X3CIBQuxJpYV V+YeYpTgYFYS4T3GIh4sxJuSWFmVWpQfX1Sak1p8iDEZ6KqJzFKiyfnAWM0riTc0NjEzsjQy N7QwMjYnTVhJnPdgq3WgkEB6YklqdmpqQWoRzBYmDk6pBkb77EBeprCdR2c+lNSU32OVrGG/ +8K3YjmhY3fv1m5WPHDahe2n/vLX+wzdbjUuu177PMReMN5Gx7aGw9s3If1YjvaTdQXz/7nU LH8357XSxEqhXb+/GXziS3U5f/3Iy3RLyfq/4oHPCpeZKh68u3Jhh6GI8N0z/DP9J1RnPDLp CTTX2qup8kOJpTgj0VCLuag4EQBY+ZYYywIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.3.5.105715 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SUBJ_PHRASE1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Seung-Woo Kim
March 5, 2014, 11:08 a.m. UTC
There was assignment of memory bank with dma address converted
from physical address. But allocation has been changed with dma
function, so the assignment is not necessary.
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
change from v1
- fixes subject and adds proper description
---
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
Comments
On 5 March 2014 16:38, Seung-Woo Kim <sw0312.kim@samsung.com> wrote: > There was assignment of memory bank with dma address converted > from physical address. But allocation has been changed with dma > function, so the assignment is not necessary. > > Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com> > --- > change from v1 > - fixes subject and adds proper description > --- > drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c > index 2475a3c..ee05f2d 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c > @@ -44,8 +44,6 @@ int s5p_mfc_alloc_firmware(struct s5p_mfc_dev *dev) > return -ENOMEM; > } > > - dev->bank1 = dev->bank1; Are you sure this isn't some kind of typo? If not then your commit description is too verbose to actually say that the code is redundant and could be removed. The code here is something like a = a; which does not make sense nor add any value and hence redundant and could be removed.
Hello Sachin, On 2014? 03? 05? 20:42, Sachin Kamat wrote: > On 5 March 2014 16:38, Seung-Woo Kim <sw0312.kim@samsung.com> wrote: (...) >> - dev->bank1 = dev->bank1; > > Are you sure this isn't some kind of typo? If not then your commit > description is too verbose > to actually say that the code is redundant and could be removed. The > code here is something like > > a = a; > > which does not make sense nor add any value and hence redundant and > could be removed. Right, this meaningless code can be simply removed as like the first version. Anyway this redundant made from change of address type in earlier patch. So I tried to describe that. Regards, - Seung-Woo Kim
Hi Seung-Woo, On 6 March 2014 07:43, Seung-Woo Kim <sw0312.kim@samsung.com> wrote: > Hello Sachin, > > On 2014? 03? 05? 20:42, Sachin Kamat wrote: >> On 5 March 2014 16:38, Seung-Woo Kim <sw0312.kim@samsung.com> wrote: > > (...) > >>> - dev->bank1 = dev->bank1; >> >> Are you sure this isn't some kind of typo? If not then your commit >> description is too verbose >> to actually say that the code is redundant and could be removed. The >> code here is something like >> >> a = a; >> >> which does not make sense nor add any value and hence redundant and >> could be removed. > > Right, this meaningless code can be simply removed as like the first > version. Anyway this redundant made from change of address type in > earlier patch. So I tried to describe that. What Kamil meant was that it is not a good practice to leave the commit description blank however trivial the patch might be. So a single line stating the obvious should be sufficient in this case.
Hello Sachin, On 2014? 03? 06? 12:28, Sachin Kamat wrote: > Hi Seung-Woo, > > On 6 March 2014 07:43, Seung-Woo Kim <sw0312.kim@samsung.com> wrote: >> Hello Sachin, >> >> On 2014? 03? 05? 20:42, Sachin Kamat wrote: >>> On 5 March 2014 16:38, Seung-Woo Kim <sw0312.kim@samsung.com> wrote: >> >> (...) >> >>>> - dev->bank1 = dev->bank1; >>> >>> Are you sure this isn't some kind of typo? If not then your commit >>> description is too verbose >>> to actually say that the code is redundant and could be removed. The >>> code here is something like >>> >>> a = a; >>> >>> which does not make sense nor add any value and hence redundant and >>> could be removed. >> >> Right, this meaningless code can be simply removed as like the first >> version. Anyway this redundant made from change of address type in >> earlier patch. So I tried to describe that. > > What Kamil meant was that it is not a good practice to leave the > commit description > blank however trivial the patch might be. So a single line stating the > obvious should > be sufficient in this case. > Ok, I will re-send with just simple statement. Thanks, - Seung-Woo Kim
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c index 2475a3c..ee05f2d 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c @@ -44,8 +44,6 @@ int s5p_mfc_alloc_firmware(struct s5p_mfc_dev *dev) return -ENOMEM; } - dev->bank1 = dev->bank1; - if (HAS_PORTNUM(dev) && IS_TWOPORT(dev)) { bank2_virt = dma_alloc_coherent(dev->mem_dev_r, 1 << MFC_BASE_ALIGN_ORDER, &bank2_dma_addr, GFP_KERNEL);