Message ID | 1375452223-30524-7-git-send-email-archit@ti.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1V5Fyz-0005io-OP; Fri, 02 Aug 2013 16:05:29 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1V5Fyx-0003YE-2J; Fri, 02 Aug 2013 16:05:29 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753324Ab3HBOFY (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 2 Aug 2013 10:05:24 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:42731 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753250Ab3HBOFU (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 2 Aug 2013 10:05:20 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id r72E5CD8020087; Fri, 2 Aug 2013 09:05:12 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id r72E5CAp018434; Fri, 2 Aug 2013 09:05:12 -0500 Received: from dlelxv23.itg.ti.com (172.17.1.198) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.2.342.3; Fri, 2 Aug 2013 09:05:11 -0500 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dlelxv23.itg.ti.com (8.13.8/8.13.8) with ESMTP id r72E5B8j009688; Fri, 2 Aug 2013 09:05:11 -0500 Received: from localhost (a0393947pc.apr.dhcp.ti.com [172.24.145.166]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id r72E58t00621; Fri, 2 Aug 2013 09:05:08 -0500 (CDT) From: Archit Taneja <archit@ti.com> To: <linux-media@vger.kernel.org> CC: <linux-omap@vger.kernel.org>, <dagriego@biglakesoftware.com>, <dale@farnsworth.org>, <pawel@osciak.com>, <m.szyprowski@samsung.com>, <hverkuil@xs4all.nl>, <laurent.pinchart@ideasonboard.com>, <tomi.valkeinen@ti.com>, Archit Taneja <archit@ti.com>, Rajendra Nayak <rnayak@ti.com>, Sricharan R <r.sricharan@ti.com> Subject: [PATCH 6/6] experimental: arm: dts: dra7xx: Add a DT node for VPE Date: Fri, 2 Aug 2013 19:33:43 +0530 Message-ID: <1375452223-30524-7-git-send-email-archit@ti.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1375452223-30524-1-git-send-email-archit@ti.com> References: <1375452223-30524-1-git-send-email-archit@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.8.2.135419 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Archit Taneja
Aug. 2, 2013, 2:03 p.m. UTC
Add a DT node for VPE in dra7.dtsi. This is experimental because we might need
to split the VPE address space a bit more, and also because the IRQ line
described is accessible the IRQ crossbar driver is added for DRA7XX.
Cc: Rajendra Nayak <rnayak@ti.com>
Cc: Sricharan R <r.sricharan@ti.com>
Signed-off-by: Archit Taneja <archit@ti.com>
---
arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
Comments
Hi Archit, Thank you for the patch. On Friday 02 August 2013 19:33:43 Archit Taneja wrote: > Add a DT node for VPE in dra7.dtsi. This is experimental because we might > need to split the VPE address space a bit more, and also because the IRQ > line described is accessible the IRQ crossbar driver is added for DRA7XX. > > Cc: Rajendra Nayak <rnayak@ti.com> > Cc: Sricharan R <r.sricharan@ti.com> > Signed-off-by: Archit Taneja <archit@ti.com> > --- > arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++ Documentation is missing :-) As this is an experimental patch you can probably document the bindings later. > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index ce9a0f0..3237972 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -484,6 +484,17 @@ > dmas = <&sdma 70>, <&sdma 71>; > dma-names = "tx0", "rx0"; > }; > + > + vpe { > + compatible = "ti,vpe"; > + ti,hwmods = "vpe"; > + reg = <0x489d0000 0xd000>, <0x489dd000 0x400>; > + reg-names = "vpe", "vpdma"; > + interrupts = <0 159 0x4>; > + #address-cells = <1>; > + #size-cells = <0>; Are #address-cells and #size-cells really needed ? > + }; > + > }; > > clocks {
Hi Laurent, Sorry about the late response, I had scrapped the DT patch out of the VPE series since there were dependencies on crossbar drivers and some other baseport stuff. Comments below. On Friday 09 August 2013 03:41 AM, Laurent Pinchart wrote: > Hi Archit, > > Thank you for the patch. > > On Friday 02 August 2013 19:33:43 Archit Taneja wrote: >> Add a DT node for VPE in dra7.dtsi. This is experimental because we might >> need to split the VPE address space a bit more, and also because the IRQ >> line described is accessible the IRQ crossbar driver is added for DRA7XX. >> >> Cc: Rajendra Nayak <rnayak@ti.com> >> Cc: Sricharan R <r.sricharan@ti.com> >> Signed-off-by: Archit Taneja <archit@ti.com> >> --- >> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++ > > Documentation is missing :-) As this is an experimental patch you can probably > document the bindings later. Yes, I will work on that. > >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index ce9a0f0..3237972 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -484,6 +484,17 @@ >> dmas = <&sdma 70>, <&sdma 71>; >> dma-names = "tx0", "rx0"; >> }; >> + >> + vpe { >> + compatible = "ti,vpe"; >> + ti,hwmods = "vpe"; >> + reg = <0x489d0000 0xd000>, <0x489dd000 0x400>; >> + reg-names = "vpe", "vpdma"; >> + interrupts = <0 159 0x4>; >> + #address-cells = <1>; >> + #size-cells = <0>; > > Are #address-cells and #size-cells really needed ? These aren't needed, vpe derives the address info from it's parent(ocp). I didn't know that the child nodes inherit these params from the parent. Archit -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Laurent, On Friday 09 August 2013 03:41 AM, Laurent Pinchart wrote: > Hi Archit, > > Thank you for the patch. > > On Friday 02 August 2013 19:33:43 Archit Taneja wrote: >> Add a DT node for VPE in dra7.dtsi. This is experimental because we might >> need to split the VPE address space a bit more, and also because the IRQ >> line described is accessible the IRQ crossbar driver is added for DRA7XX. >> >> Cc: Rajendra Nayak <rnayak@ti.com> >> Cc: Sricharan R <r.sricharan@ti.com> >> Signed-off-by: Archit Taneja <archit@ti.com> >> --- >> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++ > > Documentation is missing :-) As this is an experimental patch you can probably > document the bindings later. Sorry for the late reply, I missed out on reading this message somehow. I'm blocked on adding the DT nodes because of some dependencies on dra7x clocks, and the crossbar framework. I'll make sure to add documentation :) > >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index ce9a0f0..3237972 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -484,6 +484,17 @@ >> dmas = <&sdma 70>, <&sdma 71>; >> dma-names = "tx0", "rx0"; >> }; >> + >> + vpe { >> + compatible = "ti,vpe"; >> + ti,hwmods = "vpe"; >> + reg = <0x489d0000 0xd000>, <0x489dd000 0x400>; >> + reg-names = "vpe", "vpdma"; >> + interrupts = <0 159 0x4>; >> + #address-cells = <1>; >> + #size-cells = <0>; > > Are #address-cells and #size-cells really needed ? They aren't needed. The vpe node inherits these params from the parent "ocp" node. Thanks, Archit -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index ce9a0f0..3237972 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi @@ -484,6 +484,17 @@ dmas = <&sdma 70>, <&sdma 71>; dma-names = "tx0", "rx0"; }; + + vpe { + compatible = "ti,vpe"; + ti,hwmods = "vpe"; + reg = <0x489d0000 0xd000>, <0x489dd000 0x400>; + reg-names = "vpe", "vpdma"; + interrupts = <0 159 0x4>; + #address-cells = <1>; + #size-cells = <0>; + }; + }; clocks {