[RFC,08/10] bttv: apply mute settings on open
Commit Message
Previously, this has been done implicitly for video device nodes by calling
set_input() (which calls audio_input() and also modified the mute
setting).
Since input and mute setting are now untangled (as much as possible), we need to
apply the mute setting with an explicit call to audio_mute().
Also apply the mute setting when the radio device node gets opened.
Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
---
drivers/media/pci/bt8xx/bttv-driver.c | 3 ++-
1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
Comments
On Wed 20 March 2013 20:24:48 Frank Schäfer wrote:
> Previously, this has been done implicitly for video device nodes by calling
> set_input() (which calls audio_input() and also modified the mute
> setting).
> Since input and mute setting are now untangled (as much as possible), we need to
> apply the mute setting with an explicit call to audio_mute().
> Also apply the mute setting when the radio device node gets opened.
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
> Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
> ---
> drivers/media/pci/bt8xx/bttv-driver.c | 3 ++-
> 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
>
> diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c
> index 55eab61..2fb2168 100644
> --- a/drivers/media/pci/bt8xx/bttv-driver.c
> +++ b/drivers/media/pci/bt8xx/bttv-driver.c
> @@ -3065,7 +3065,7 @@ static int bttv_open(struct file *file)
> fh, &btv->lock);
> set_tvnorm(btv,btv->tvnorm);
> set_input(btv, btv->input, btv->tvnorm);
> -
> + audio_mute(btv, btv->mute);
>
> /* The V4L2 spec requires one global set of cropping parameters
> which only change on request. These are stored in btv->crop[1].
> @@ -3230,6 +3230,7 @@ static int radio_open(struct file *file)
> v4l2_fh_init(&fh->fh, vdev);
>
> btv->radio_user++;
> + audio_mute(btv, btv->mute);
>
> v4l2_fh_add(&fh->fh);
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
@@ -3065,7 +3065,7 @@ static int bttv_open(struct file *file)
fh, &btv->lock);
set_tvnorm(btv,btv->tvnorm);
set_input(btv, btv->input, btv->tvnorm);
-
+ audio_mute(btv, btv->mute);
/* The V4L2 spec requires one global set of cropping parameters
which only change on request. These are stored in btv->crop[1].
@@ -3230,6 +3230,7 @@ static int radio_open(struct file *file)
v4l2_fh_init(&fh->fh, vdev);
btv->radio_user++;
+ audio_mute(btv, btv->mute);
v4l2_fh_add(&fh->fh);