Message ID | 878v5wxqx1.fsf@micropit.couberia.selfip.net |
---|---|
State | New |
Headers |
Received: from localhost ([127.0.0.1] helo=www.linuxtv.org) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <vdr-bounces@linuxtv.org>) id 1UEQNr-0002xO-Pr; Sat, 09 Mar 2013 21:28:48 +0100 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <glv-vdr@m.gmane.org>) id 1UEQNM-0002x7-60 for vdr@linuxtv.org; Sat, 09 Mar 2013 21:28:41 +0100 X-tubIT-Incoming-IP: 80.91.229.3 Received: from plane.gmane.org ([80.91.229.3]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtps [TLSv1:AES256-SHA:256] for <vdr@linuxtv.org> id 1UEQNL-00058q-BZ; Sat, 09 Mar 2013 21:28:15 +0100 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from <glv-vdr@m.gmane.org>) id 1UEQNc-0003Yn-Sz for vdr@linuxtv.org; Sat, 09 Mar 2013 21:28:32 +0100 Received: from arennes-651-1-118-202.w2-2.abo.wanadoo.fr ([2.2.13.202]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for <vdr@linuxtv.org>; Sat, 09 Mar 2013 21:28:32 +0100 Received: from pmlists by arennes-651-1-118-202.w2-2.abo.wanadoo.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for <vdr@linuxtv.org>; Sat, 09 Mar 2013 21:28:32 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: vdr@linuxtv.org From: =?utf-8?Q?Peter_M=C3=BCnster?= <pmlists@free.fr> Date: Sat, 09 Mar 2013 21:24:26 +0100 Lines: 30 Message-ID: <878v5wxqx1.fsf@micropit.couberia.selfip.net> Mime-Version: 1.0 X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: arennes-651-1-118-202.w2-2.abo.wanadoo.fr User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2 (gnu/linux) Cancel-Lock: sha1:UbkfzDbdNn6kFCByihSUY4l0CUE= X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.3.9.202416 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, KNOWN_FREEWEB_URI 0.05, MIME_LOWER_CASE 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_800_899 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __KNOWN_FREEWEB_URI1 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_START 0, __SUBJ_ALPHA_START_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_MAILTO 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' X-LSpam-Score: -1.1 (-) X-LSpam-Report: No, score=-1.1 required=5.0 tests=BAYES_00=-1.9, FREEMAIL_FROM=0.001, RDNS_NONE=0.793 autolearn=no Subject: [vdr] small patch for vdr.c: continue even with read-only video directory X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: VDR Mailing List <vdr@linuxtv.org> List-Id: VDR Mailing List <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/options/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: vdr-bounces@linuxtv.org Errors-To: vdr-bounces@linuxtv.org |
Commit Message
Peter Münster
March 9, 2013, 8:24 p.m. UTC
Hi Klaus, Could you please delete line 577 from vdr.c or do something similar to let vdr continue even with read-only video directory? vdr runs fine with this patch on my system, and it's important for me, that vdr cannot write anything to the video directory. (see also http://pmrb.free.fr/vdr/) Here a small patch: --8<---------------cut here---------------start------------->8--- --8<---------------cut here---------------end--------------->8--- If you prefer, I can write a better patch: stop if not readable, warn if not writable. TIA,
Comments
On 09.03.2013 21:24, Peter Münster wrote: > Hi Klaus, > > Could you please delete line 577 from vdr.c or do something similar to > let vdr continue even with read-only video directory? > > vdr runs fine with this patch on my system, and it's important for me, > that vdr cannot write anything to the video directory. > (see also http://pmrb.free.fr/vdr/) > > Here a small patch: > > --8<---------------cut here---------------start------------->8--- > --- vdr.c.orig 2013-03-09 21:13:57.846826771 +0100 > +++ vdr.c 2013-03-09 21:16:33.503521762 +0100 > @@ -574,7 +574,6 @@ > > if (!DirectoryOk(VideoDirectory, true)) { > fprintf(stderr, "vdr: can't access video directory %s\n", VideoDirectory); > - return 2; > } > > // Daemon mode: > --8<---------------cut here---------------end--------------->8--- > > If you prefer, I can write a better patch: stop if not readable, warn if > not writable. I'm afraid we're too close to releasing version 2.0.0 to make such changes now. Besides, why don't you just use a writeable video directory and mount your read-only directory below that? Something like /video /video/readonly Klaus
On Sun, Mar 10 2013, Klaus Schmidinger wrote: > I'm afraid we're too close to releasing version 2.0.0 to make such > changes now. No problem. I would just like to know, if you agree with such a patch (or something more elaborated). > Besides, why don't you just use a writeable video directory and mount > your read-only directory below that? Something like > > /video > /video/readonly 1. I don't want, that the client VDR can write/record anything to /video. 2. I want my VDR setup to be as simple as possible. (It just works... ;)
--- vdr.c.orig 2013-03-09 21:13:57.846826771 +0100 +++ vdr.c 2013-03-09 21:16:33.503521762 +0100 @@ -574,7 +574,6 @@ if (!DirectoryOk(VideoDirectory, true)) { fprintf(stderr, "vdr: can't access video directory %s\n", VideoDirectory); - return 2; } // Daemon mode: