Message ID | 1345799431-29426-4-git-send-email-agust@denx.de (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1T4puh-00010i-Nz for patchwork@linuxtv.org; Fri, 24 Aug 2012 11:10:47 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for <patchwork@linuxtv.org> id 1T4puh-000589-A5; Fri, 24 Aug 2012 11:10:47 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932413Ab2HXJKn (ORCPT <rfc822;patchwork@linuxtv.org>); Fri, 24 Aug 2012 05:10:43 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:51039 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757828Ab2HXJKi (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 24 Aug 2012 05:10:38 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3X3GtK5fFZz3hhwf; Fri, 24 Aug 2012 11:10:33 +0200 (CEST) X-Auth-Info: f+LKG7QoQWKl0+ZY4Q2F2kASK/Cw+eAwSLJ0eOj3484= Received: from localhost (p4FC461F2.dip.t-dialin.net [79.196.97.242]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA id 3X3GtK4Mr3zbbj3; Fri, 24 Aug 2012 11:10:33 +0200 (CEST) From: Anatolij Gustschin <agust@denx.de> To: linux-media@vger.kernel.org Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>, Mauro Carvalho Chehab <mchehab@infradead.org>, dzu@denx.de Subject: [PATCH 3/3] mt9v022: set y_skip_top field to zero Date: Fri, 24 Aug 2012 11:10:31 +0200 Message-Id: <1345799431-29426-4-git-send-email-agust@denx.de> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1345799431-29426-1-git-send-email-agust@denx.de> References: <1345799431-29426-1-git-send-email-agust@denx.de> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.8.24.90018 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Anatolij Gustschin
Aug. 24, 2012, 9:10 a.m. UTC
Set "y_skip_top" to zero and remove comment as I do not see this
line corruption on two different mt9v022 setups. The first read-out
line is perfectly fine.
Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
drivers/media/i2c/soc_camera/mt9v022.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
Comments
On Fri, 24 Aug 2012, Anatolij Gustschin wrote: > Set "y_skip_top" to zero and remove comment as I do not see this > line corruption on two different mt9v022 setups. The first read-out > line is perfectly fine. On what systems have you checked this? Thanks Guennadi > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > --- > drivers/media/i2c/soc_camera/mt9v022.c | 6 +----- > 1 files changed, 1 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/i2c/soc_camera/mt9v022.c b/drivers/media/i2c/soc_camera/mt9v022.c > index d26c071..e41d738 100644 > --- a/drivers/media/i2c/soc_camera/mt9v022.c > +++ b/drivers/media/i2c/soc_camera/mt9v022.c > @@ -960,11 +960,7 @@ static int mt9v022_probe(struct i2c_client *client, > > mt9v022->chip_control = MT9V022_CHIP_CONTROL_DEFAULT; > > - /* > - * MT9V022 _really_ corrupts the first read out line. > - * TODO: verify on i.MX31 > - */ > - mt9v022->y_skip_top = 1; > + mt9v022->y_skip_top = 0; > mt9v022->rect.left = MT9V022_COLUMN_SKIP; > mt9v022->rect.top = MT9V022_ROW_SKIP; > mt9v022->rect.width = MT9V022_MAX_WIDTH; > -- > 1.7.1 > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 24 Aug 2012 13:23:22 +0200 (CEST) Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote: > On Fri, 24 Aug 2012, Anatolij Gustschin wrote: > > > Set "y_skip_top" to zero and remove comment as I do not see this > > line corruption on two different mt9v022 setups. The first read-out > > line is perfectly fine. > > On what systems have you checked this? On camera systems from ifm, both using mt9v022. Anatolij -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 24 Aug 2012, Anatolij Gustschin wrote: > On Fri, 24 Aug 2012 13:23:22 +0200 (CEST) > Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote: > > > On Fri, 24 Aug 2012, Anatolij Gustschin wrote: > > > > > Set "y_skip_top" to zero and remove comment as I do not see this > > > line corruption on two different mt9v022 setups. The first read-out > > > line is perfectly fine. > > > > On what systems have you checked this? > > On camera systems from ifm, both using mt9v022. Ok, I agree, this was a hack in the beginning, and, probably, there was a reason for the problem, that we've seen, that we didn't find a proper solution to, but I wouldn't like to punish those systems now. The y_skip_top field is only taken into account by the pxa driver, and there is only one pxa270 system, using mt9v022: pcm990-baseboard.c. Could you, please, add platform data to mt9v022 with only one parameter to initialise y_skip_top, use 0 as default and set it to 1 on pcm990-baseboard.c? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Guennadi, On Tue, 11 Sep 2012 10:55:31 +0200 (CEST) Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote: ... > > > On what systems have you checked this? > > > > On camera systems from ifm, both using mt9v022. > > Ok, I agree, this was a hack in the beginning, and, probably, there was a > reason for the problem, that we've seen, that we didn't find a proper > solution to, but I wouldn't like to punish those systems now. The > y_skip_top field is only taken into account by the pxa driver, and there > is only one pxa270 system, using mt9v022: pcm990-baseboard.c. Could you, > please, add platform data to mt9v022 with only one parameter to initialise > y_skip_top, use 0 as default and set it to 1 on pcm990-baseboard.c? Yes, I've reworked this patch as suggested and will resubmit. Thanks, Anatolij -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/i2c/soc_camera/mt9v022.c b/drivers/media/i2c/soc_camera/mt9v022.c index d26c071..e41d738 100644 --- a/drivers/media/i2c/soc_camera/mt9v022.c +++ b/drivers/media/i2c/soc_camera/mt9v022.c @@ -960,11 +960,7 @@ static int mt9v022_probe(struct i2c_client *client, mt9v022->chip_control = MT9V022_CHIP_CONTROL_DEFAULT; - /* - * MT9V022 _really_ corrupts the first read out line. - * TODO: verify on i.MX31 - */ - mt9v022->y_skip_top = 1; + mt9v022->y_skip_top = 0; mt9v022->rect.left = MT9V022_COLUMN_SKIP; mt9v022->rect.top = MT9V022_ROW_SKIP; mt9v022->rect.width = MT9V022_MAX_WIDTH;