[ANNOUNCE] VDR developer version 1.7.17

Message ID 201103191740.p2JHe1CX042314@triton8.kn-bremen.de
State New
Headers

Commit Message

Juergen Lock March 19, 2011, 5:40 p.m. UTC
  In article <201103191519.p2JFJKZw037553@triton8.kn-bremen.de> you write:
>In article <4D849B3A.6060308@tvdr.de> you write:
>>On 17.03.2011 22:36, Juergen Lock wrote:
>>> In article <4D7CAEA2.9050109@tvdr.de> you write:
>>>> VDR developer version 1.7.17 is now available at
>>>>
>>>>      ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.17.tar.bz2
>>>>
>>>> A 'diff' against the previous version is available at
>>>>
>>>>      ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.16-1.7.17.diff
>>>>
>>>>
>>>>
>>>> WARNING:
>>>> ========
>>>>
>>>> This is a *developer* version. Even though *I* use it in my productive
>>>> environment. I strongly recommend that you only use it under controlled
>>>> conditions and for testing and debugging.
>>>>
>>>>
>>>> [...]
>>>> - Fixed detecting frames on channels that broadcast with 50 or 60 fps.
>>>>  This avoids artifacts during fast forward/rewind when replaying recordings from such
>>>>  channels. To fix the index of existing recordings from such channels, just delete the
>>>>  'index' file of the recording and VDR will generate a new one the next time you play it.
>>>>  You should also change the line "F 25" to "F 50" in the 'info' file of that recording.
>>>> [...]
>>> 
>>> I wonder if I'm chasing a ghost there... am I really the only one
>>> seeing this?  I can't get this index rebuilding to work regardless
>>> if I try it with old or new recordings, if I mv away the original
>>> index file that was created with a recording I always get totally
>>> different index files rebuilt (checked with hexdump/cmp -l) that
>>> cause playbacks (via xineliboutput) to look quite corrupted immediately
>>> and make vdr-sxfe hang at eof too.
>>> 
>>>  This is vdr 1.7.17, xineliboutput is a 1.0.90s20110308.2305 checkout,
>>> FreeBSD 8.2/amd64, using these ports:
>>> 
>>> 	http://people.freebsd.org/~nox/dvb/vdr-20110317a.shar
>>> 
>>> (originally noticed with recordings from arte hd on 19.2E, but also
>>> reproduced with new short sd recordings, even from dvb-t.)
>>
>>I just made a recording from "arte HD" with VDR 1.7.17 and everything worked fine.
>>It played correctly (on a TT-S2 6400 prototype), the current and total
>>times displayed by the progress display were correct and I was able to
>>place and move an editing mark with the picture getting updated just
>>fine.
>
>So it also works when you stop vdr, mv the recording's index
>file away and then let vdr regenerate it?  Could this be an
>amd64/x86_64 issue?

Found the problem:  The FreeBSD patches disable USE_FADVISE in tools.c,
and there was an #else clause missing when its not defined:


 There is one remaining bug tho:  After playback of a short recording
(sd in this case, 20s or so), vdr seems to kind of hang and I have
to kill it...  Can you reproduce that?  Longer recordings are not
affected.

 Thanx, :)
	Juergen
  

Comments

Udo Richter March 19, 2011, 5:55 p.m. UTC | #1
Am 19.03.2011 18:40, schrieb Juergen Lock:
>  There is one remaining bug tho:  After playback of a short recording
> (sd in this case, 20s or so), vdr seems to kind of hang and I have
> to kill it...  Can you reproduce that?  Longer recordings are not
> affected.

This is probably an old bug: For me, VDR has always been hanging at the
end of a recording, if that recording is shorter than one minute. Takes
10 or 20 seconds, then brings you back to live view again. Its not that
annoying, as recordings are usually longer, so I've never been going on
bug hunt for this.

Cheers,

Udo
  
Juergen Lock March 19, 2011, 7:46 p.m. UTC | #2
In article <4D84EE1D.8090503@gmx.de> you write:
>Am 19.03.2011 18:40, schrieb Juergen Lock:
>>  There is one remaining bug tho:  After playback of a short recording
>> (sd in this case, 20s or so), vdr seems to kind of hang and I have
>> to kill it...  Can you reproduce that?  Longer recordings are not
>> affected.
>
>This is probably an old bug: For me, VDR has always been hanging at the
>end of a recording, if that recording is shorter than one minute. Takes
>10 or 20 seconds, then brings you back to live view again. Its not that
>annoying, as recordings are usually longer, so I've never been going on
>bug hunt for this.

Ah yeah, that could well be it.  I also found that sometimes playback
of a short recording that was played before(?) doesn't start until
you hit green... (black screen or `no signal', don't remember.)

 Anyway, you are right, short recordings are kinda rare in real life. :)

 Thanx,
	Juergen
  

Patch

--- tools.c.orig
+++ tools.c
@@ -1669,6 +1669,9 @@  ssize_t cUnbufferedFile::Read(void *Data
            }
         }
      lastpos = curpos;
+#else
+     if (bytesRead > 0)
+        curpos += bytesRead;
 #endif
      return bytesRead;
      }