Message ID | 47CF0CCB.70309@ventoso.org |
---|---|
State | New |
Headers |
Received: from 61.pool85-52-226.static.orange.es ([85.52.226.61] helo=ventoso.org) by www.linuxtv.org with esmtp (Exim 4.63) (envelope-from <luca@ventoso.org>) id 1JX0vN-0001Tu-7w for vdr@linuxtv.org; Wed, 05 Mar 2008 22:13:21 +0100 Received: from [192.168.10.30] (unknown [192.168.10.30]) by ventoso.org (Postfix) with ESMTP id 70A1CCAB6D6 for <vdr@linuxtv.org>; Wed, 5 Mar 2008 22:12:42 +0100 (CET) Message-ID: <47CF0CCB.70309@ventoso.org> Date: Wed, 05 Mar 2008 22:12:43 +0100 From: Luca Olivetti <luca@ventoso.org> User-Agent: Thunderbird 2.0.0.4 (X11/20070620) MIME-Version: 1.0 To: VDR Mailing List <vdr@linuxtv.org> References: <20080304205553.GA29585@srotta.homeip.net> <20080304211025.GA29694@srotta.homeip.net> <47CDC07F.6090107@cadsoft.de> <20080305120231.GA32268@srotta.homeip.net> <20080305164745.GA923@srotta.homeip.net> <47CECF7B.5090709@cadsoft.de> <20080305173822.GA1219@srotta.homeip.net> In-Reply-To: <20080305173822.GA1219@srotta.homeip.net> Content-Type: multipart/mixed; boundary="------------000903010100090107090509" X-LSpam-Score: 0.0 (/) Subject: Re: [vdr] DXR3 and subtitles in 1.5.x X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.9 Precedence: list Reply-To: VDR Mailing List <vdr@linuxtv.org> List-Id: VDR Mailing List <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> X-List-Received-Date: Wed, 05 Mar 2008 21:13:22 -0000 Status: O X-Status: X-Keywords: X-UID: 15973 |
Commit Message
Luca Olivetti
March 5, 2008, 9:12 p.m. UTC
En/na Sami Sundell ha escrit: > On Wed, Mar 05, 2008 at 05:51:07PM +0100, Klaus Schmidinger wrote: > >> I'd say this whole thing is a DXR3 problem, not a core VDR problem. >> Therefore I'm afraid I can't contribute to the solution... > > Looks like it, but thanks anyway. > > ... found the 0.2.x-branch in the dxr3 plugin CVS, which gives me Yes, that's the "good" one (I don't think anybody is working on the HEAD version). > picture but still bleeding subtitles. Now it won't crash if I try to > access the OSD, it just stops responding to remote. :P Well, I also had to modify dvbsubtitle.c (with some hints from the dxr3-plugin mailing list), and since I go from one vdr version to the next one with the patch, I forgot it. Attached is a diff from the stock dvbsubtitle.c in 1.5.17 and the version I'm using. I don't know if it's a good or bad patch but it works here, no bleeding and the lirc remote is responsive. I also cannot say if any of the other patches I have make a difference. Bye
Comments
On 03/05/08 22:12, Luca Olivetti wrote: > En/na Sami Sundell ha escrit: >> On Wed, Mar 05, 2008 at 05:51:07PM +0100, Klaus Schmidinger wrote: >> >>> I'd say this whole thing is a DXR3 problem, not a core VDR problem. >>> Therefore I'm afraid I can't contribute to the solution... >> >> Looks like it, but thanks anyway. >> >> ... found the 0.2.x-branch in the dxr3 plugin CVS, which gives me > > Yes, that's the "good" one (I don't think anybody is working on the HEAD > version). > >> picture but still bleeding subtitles. Now it won't crash if I try to >> access the OSD, it just stops responding to remote. :P > > Well, I also had to modify dvbsubtitle.c (with some hints from the > dxr3-plugin mailing list), and since I go from one vdr version to the > next one with the patch, I forgot it. > Attached is a diff from the stock dvbsubtitle.c in 1.5.17 and the > version I'm using. > I don't know if it's a good or bad patch but it works here, no bleeding > and the lirc remote is responsive. > I also cannot say if any of the other patches I have make a difference. There's one thing I can say: this patch is not going into the official VDR source. The problem is in the DXR3 plugin: the correct way to handle this is for the OSD object to truthfully report whether it can handle the requested areas or not, and if it claims to be able to handle them, then do so Klaus
On Wed, Mar 05, 2008 at 10:12:43PM +0100, Luca Olivetti wrote: > Well, I also had to modify dvbsubtitle.c (with some hints from the > dxr3-plugin mailing list), and since I go from one vdr version to the Thanks for the info and the patch - I've spent this evening looking at the sources and got the feeling that the cvs version of dxr3 won't alone help in getting the subs working. I was just in the middle of modifying the said dvbsubtitle.c - good that I won't have to do that alone :P The problems with no picture went away once I noticed that generating a new deb package of VDR and installing it also requires installing the headers and rebuilding the dxr3 plugin against them... > I don't know if it's a good or bad patch but it works here, no > bleeding and the lirc remote is responsive. Ok, now the subtitles work, but I still have problems with subtitles and OSD together - remote becomes unresponsive and I get errors: Mar 5 23:45:42 dvd vdr: [5102] ERROR: attempt to open OSD while it is already open - using dummy OSD! Closer to goal, though 8)
En/na Klaus Schmidinger ha escrit: > > There's one thing I can say: this patch is not going into the official Sure, I understand that > VDR source. The problem is in the DXR3 plugin: the correct way to handle this > is for the OSD object to truthfully report whether it can handle the > requested areas or not, and if it claims to be able to handle them, > then do so Well, it isn't so simple, since color management with the dxr3 uses many tricks. Natively it's only capable of 2bpp, but with a lot of tricks it manages 4bpp for a typical osd. If it reports 2bpp, most everything would work (I think osd teletext wouldn't) but with a very dull osd, if it reports 4bpp everything works as long as there's no antialiasing. Bye
On Thu, Mar 06, 2008 at 12:35:54AM +0200, Sami Sundell wrote: > Ok, now the subtitles work, but I still have problems with subtitles > and OSD together - remote becomes unresponsive and I get errors: > > Mar 5 23:45:42 dvd vdr: [5102] ERROR: attempt to open OSD while it is > already open - using dummy OSD! ... and this went away when I changed the cDxr3SubpictureOsd constructor to call the cOsd with proper level. Unless I'm missing something - and I bet I am - the system seems to be working smoothly now. Thanks for all!
En/na Sami Sundell ha escrit: > On Thu, Mar 06, 2008 at 12:35:54AM +0200, Sami Sundell wrote: > >> Ok, now the subtitles work, but I still have problems with subtitles >> and OSD together - remote becomes unresponsive and I get errors: >> >> Mar 5 23:45:42 dvd vdr: [5102] ERROR: attempt to open OSD while it is >> already open - using dummy OSD! > > ... and this went away when I changed the cDxr3SubpictureOsd constructor > to call the cOsd with proper level. Unless I'm missing something - and I > bet I am - the system seems to be working smoothly now. Mmh, it should be already doing it, look at line 39 http://dxr3plugin.cvs.sourceforge.net/dxr3plugin/dxr3/dxr3osd_subpicture.c?revision=1.1.2.18&view=markup&pathrev=vdr-dxr3-0-2 Bye
En/na Luca Olivetti ha escrit: >> ... and this went away when I changed the cDxr3SubpictureOsd constructor >> to call the cOsd with proper level. Unless I'm missing something - and I >> bet I am - the system seems to be working smoothly now. > > Mmh, it should be already doing it, look at line 39 > > http://dxr3plugin.cvs.sourceforge.net/dxr3plugin/dxr3/dxr3osd_subpicture.c?revision=1.1.2.18&view=markup&pathrev=vdr-dxr3-0-2 (slaps on head), ok, that's calling it with 0, in my local copy I'm calling it with Level (probably the problem was introduced when I made the patch for the cvs version supporting older vdr releases). Sorry for all the trouble. Ville, are you listening? ;-) Bye
On Thursday 06 March 2008, Luca Olivetti wrote: > En/na Luca Olivetti ha escrit: > >> ... and this went away when I changed the cDxr3SubpictureOsd constructor > >> to call the cOsd with proper level. Unless I'm missing something - and I > >> bet I am - the system seems to be working smoothly now. > > > > Mmh, it should be already doing it, look at line 39 > > > > http://dxr3plugin.cvs.sourceforge.net/dxr3plugin/dxr3/dxr3osd_subpicture. > >c?revision=1.1.2.18&view=markup&pathrev=vdr-dxr3-0-2 > > (slaps on head), ok, that's calling it with 0, in my local copy I'm > calling it with Level (probably the problem was introduced when I made > the patch for the cvs version supporting older vdr releases). > Sorry for all the trouble. > > Ville, are you listening? ;-) Sure; committed, thanks!
--- vdr-1.5.17.orig/dvbsubtitle.c 2007-11-25 14:33:08.000000000 +0100 +++ vdr-1.5.17/dvbsubtitle.c 2008-01-20 19:24:05.785023000 +0100 @@ -983,13 +983,22 @@ return; tArea *Areas = Page->GetAreas(); int NumAreas = Page->regions.Count(); - int Bpp = 8; bool Reduced = false; - while (osd->CanHandleAreas(Areas, NumAreas) != oeOk) { + for (int i = 0; i < NumAreas; i++) { + if (Areas[i].bpp > 2) { + Areas[i].bpp = 2; + Reduced = true; + } + } + + /* + int Bpp = 4; + bool Reduced = false; + //while (osd->CanHandleAreas(Areas, NumAreas) != oeOk) { int HalfBpp = Bpp / 2; if (HalfBpp >= 2) { for (int i = 0; i < NumAreas; i++) { - if (Areas[i].bpp >= Bpp) { + while (Areas[i].bpp >= Bpp) { Areas[i].bpp = HalfBpp; Reduced = true; } @@ -998,7 +1007,9 @@ } else return; // unable to draw bitmaps + // } + */ if (Reduced) { for (int i = 0; i < NumAreas; i++) { cSubtitleRegion *sr = Page->regions.Get(i);