Message ID | 4572E433.3060706@gmx.de |
---|---|
State | New |
Headers |
Received: from mail.gmx.net ([213.165.64.20]) by www.linuxtv.org with smtp (Exim 4.50) id 1Gqsh8-0007cK-A5 for vdr@linuxtv.org; Sun, 03 Dec 2006 15:51:54 +0100 Received: (qmail invoked by alias); 03 Dec 2006 14:51:24 -0000 Received: from p57A88913.dip0.t-ipconnect.de (EHLO localhost) [87.168.137.19] by mail.gmx.net (mp029) with SMTP; 03 Dec 2006 15:51:24 +0100 X-Authenticated: #1417946 Message-ID: <4572E433.3060706@gmx.de> Date: Sun, 03 Dec 2006 15:50:27 +0100 From: Udo Richter <udo_richter@gmx.de> User-Agent: Thunderbird 2.0b1 (Windows/20061202) MIME-Version: 1.0 To: VDR Mailing List <vdr@linuxtv.org> Subject: Re: [vdr] Re: Problem with vdr-1.4.4-1 and extrecmenu References: <4572DA75.60204@unterbrecher.de> <4572E105.5090804@fastmail.fm> <4572E1C0.5060507@cadsoft.de> In-Reply-To: <4572E1C0.5060507@cadsoft.de> Content-Type: multipart/mixed; boundary="------------000206000609070306040900" X-Y-GMX-Trusted: 0 X-BeenThere: vdr@linuxtv.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: VDR Mailing List <vdr@linuxtv.org> List-Id: VDR Mailing List <vdr.linuxtv.org> List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=unsubscribe> List-Archive: <http://www.linuxtv.org/pipermail/vdr> List-Post: <mailto:vdr@linuxtv.org> List-Help: <mailto:vdr-request@linuxtv.org?subject=help> List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr>, <mailto:vdr-request@linuxtv.org?subject=subscribe> X-List-Received-Date: Sun, 03 Dec 2006 14:51:54 -0000 Status: O X-Status: X-Keywords: X-UID: 11331 |
Commit Message
Udo Richter
Dec. 3, 2006, 2:50 p.m. UTC
Klaus Schmidinger wrote: > Add the line > > #define uint64 uint64_t > > to VDR/tools.h. > > I'll add this in the next maintenance patch, too. > In the long run all plugins should change this to uint64_t, though. better, re-add it as typedef as it was before. Attached. Cheers, Udo
Comments
Udo Richter wrote: > Klaus Schmidinger wrote: >> Add the line >> >> #define uint64 uint64_t >> >> to VDR/tools.h. >> >> I'll add this in the next maintenance patch, too. >> In the long run all plugins should change this to uint64_t, though. > > better, re-add it as typedef as it was before. Attached. I want to get rid of this completely, so it will be a #define that, if possible, causes a compile time warning. And at some later point I'll remove that #define. Klaus
On Sunday 03 December 2006 15:53, Klaus Schmidinger wrote: > Udo Richter wrote: > > Klaus Schmidinger wrote: > >> Add the line > >> > >> #define uint64 uint64_t > >> > >> to VDR/tools.h. > >> > >> I'll add this in the next maintenance patch, too. > >> In the long run all plugins should change this to uint64_t, though. > > > > better, re-add it as typedef as it was before. Attached. > > I want to get rid of this completely, so it will be a #define > that, if possible, causes a compile time warning. And at some later > point I'll remove that #define. > > Klaus > Why not just keep it away. I think it is not too hard to replace that in the plugins. Matthias
Matthias Schwarzott wrote: > On Sunday 03 December 2006 15:53, Klaus Schmidinger wrote: >> Udo Richter wrote: >>> Klaus Schmidinger wrote: >>>> Add the line >>>> >>>> #define uint64 uint64_t >>>> >>>> to VDR/tools.h. >>>> >>>> I'll add this in the next maintenance patch, too. >>>> In the long run all plugins should change this to uint64_t, though. >>> better, re-add it as typedef as it was before. Attached. >> I want to get rid of this completely, so it will be a #define >> that, if possible, causes a compile time warning. And at some later >> point I'll remove that #define. >> >> Klaus >> > > Why not just keep it away. I think it is not too hard to replace that in the > plugins. > > Matthias You're probably right. By the time I'll release the next maintenance patch I guess all plugins will have been updated, anyway. Klaus
Klaus Schmidinger wrote: > Matthias Schwarzott wrote: >> Why not just keep it away. I think it is not too hard to replace that >> in the plugins. > > You're probably right. > By the time I'll release the next maintenance patch I guess > all plugins will have been updated, anyway. This strikes on the control plugin and the streamdev plugin, both rather un-maintained. Plus, plugin maintainers may need to make sure / test, that adapted plugins also compile on 1.4.4 and earlier, as this may need an additional #include <stdint.h> here and there. What about keeping it for the 1.4.x cycle and dropping it in the first 1.5.x version? Cheers, Udo
Udo Richter wrote: > Klaus Schmidinger wrote: >> Matthias Schwarzott wrote: >>> Why not just keep it away. I think it is not too hard to replace that >>> in the plugins. >> >> You're probably right. >> By the time I'll release the next maintenance patch I guess >> all plugins will have been updated, anyway. > > This strikes on the control plugin and the streamdev plugin, both rather > un-maintained. Plus, plugin maintainers may need to make sure / test, > that adapted plugins also compile on 1.4.4 and earlier, as this may need > an additional #include <stdint.h> here and there. > > What about keeping it for the 1.4.x cycle and dropping it in the first > 1.5.x version? That's what I was heading at with the #define... Klaus
--- tools.h.orig 2006-12-03 15:42:47.000000000 +0100 +++ tools.h 2006-12-03 15:42:49.756970280 +0100 @@ -23,6 +23,7 @@ #include <sys/types.h> typedef unsigned char uchar; +typedef uint64_t uint64; extern int SysLogLevel;