[ANNOUNCE] vdr-xine-0.7.7 plugin

Message ID 43F38630.90802@gmx.de
State New
Headers

Commit Message

Reinhard Nissl Feb. 15, 2006, 7:51 p.m. UTC
Hi,

Reinhard Nissl wrote:

>> Well, i seem to have the same problem : I can use/edit the marks , but 
>> if i move the
>> marks using "4" and "6" , picture is not updated, which makes editing 
>> quite difficult.
> 
> You are right, it doesn't work anymore ;-(

The problem is that xine doesn't show the first I frame after a Clear(). 
Clear() was modified in 0.7.7 as mentioned in HISTORY, so that's the 
main cause why editing cutting marks doesn't work in plain 0.7.7.

While developing for a "real" fix, one can avoid this issue by applying 
the attach patch which has vdr-xine send still images twice to xine.

Bye.
  

Comments

Philippe Gramoullé Feb. 15, 2006, 8:40 p.m. UTC | #1
Hello Reinhard,

On Wed, 15 Feb 2006 20:51:12 +0100
Reinhard Nissl <rnissl@gmx.de> wrote:

  | The problem is that xine doesn't show the first I frame after a Clear(). 
  | Clear() was modified in 0.7.7 as mentioned in HISTORY, so that's the 
  | main cause why editing cutting marks doesn't work in plain 0.7.7.
  | 
  | While developing for a "real" fix, one can avoid this issue by applying 
  | the attach patch which has vdr-xine send still images twice to xine.

Thanks for the patch, i can edit cutting marks just fine right now.

Philippe
  
Darren Salt Feb. 15, 2006, 8:46 p.m. UTC | #2
I demand that Reinhard Nissl may or may not have written...

> Reinhard Nissl wrote:
>>> Well, i seem to have the same problem : I can use/edit the marks , but if
>>> i move the marks using "4" and "6" , picture is not updated, which makes
>>> editing quite difficult.

>> You are right, it doesn't work anymore ;-(

> The problem is that xine doesn't show the first I frame after a Clear().
> Clear() was modified in 0.7.7 as mentioned in HISTORY, so that's the main
> cause why editing cutting marks doesn't work in plain 0.7.7.

> While developing for a "real" fix, one can avoid this issue by applying the
> attach patch which has vdr-xine send still images twice to xine.

Works here. Building and uploading...
  
Grégoire Favre Feb. 15, 2006, 9:41 p.m. UTC | #3
On Wed, Feb 15, 2006 at 08:51:12PM +0100, Reinhard Nissl wrote:

> The problem is that xine doesn't show the first I frame after a Clear(). 
> Clear() was modified in 0.7.7 as mentioned in HISTORY, so that's the 
> main cause why editing cutting marks doesn't work in plain 0.7.7.
> 
> While developing for a "real" fix, one can avoid this issue by applying 
> the attach patch which has vdr-xine send still images twice to xine.

Works also great here !!!

Thank you very much for this quick fix :)
  

Patch

--- ../xine-0.7.7/xineDevice.c	2006-02-13 22:18:52.000000000 +0100
+++ xineDevice.c	2006-02-15 20:43:17.000000000 +0100
@@ -156,7 +156,7 @@  namespace PluginXine
       m_xineLib.execFuncStillFrame();
       m_xineLib.execFuncWait();
 
-//      for (int i = 0; i < 2; i++)
+      for (int i = 0; i < 2; i++)
         m_xineLib.showNoSignal();
 
       PushOut();
@@ -975,7 +975,7 @@  namespace PluginXine
     
     m_xineLib.pause(false);
 
-    for (int i = 0; i < 1 /* 4 */; i++)
+    for (int i = 0; i < 2 /* 4 */; i++)
     {
 //fprintf(stderr, " (%d) ", i);
       int r = PlayVideo1(Data, Length, true);      
@@ -984,7 +984,7 @@  namespace PluginXine
     }
 
     PushOut();
-    m_xineLib.execFuncFlush(0);
+//    m_xineLib.execFuncFlush(0);
     m_xineLib.execFuncFlush();
 
 //    ::fprintf(stderr, "------------\n");