vdr-1.3.38 and master-timer ?

Message ID 20060108151250.GG8960@gmail.com
State New
Headers

Commit Message

Grégoire Favre Jan. 8, 2006, 3:12 p.m. UTC
Hello,

as I can't live anymore without master-timer, I would like to know if
the change in vdr-1.3.38 breaks master-timer support ?

And by the way, on 11 Dec 2005, Olaf Titz wrote on this ml a patch :


It should allow a force to save the EPG, I have done lots of test to try
to really force it, but without success, for example like this :

Kill vdr
rm -f /video0/epg.data
run vdr
zap a lots under vdr such that EPG gets full
touch -r /bin/bash /video0/epg.data
sleep 60
ls -al /video0/epg.data still reports "0" as size...

Thank you very much,
  

Comments

Guido Fiala Jan. 8, 2006, 3:24 p.m. UTC | #1
master timer can also read its data via LSTE which works more reliable, 
however, if something has changed there it is likely to break. Though i 
assume its not hard to fix.

-
Can't test it - personally i have to stick with 1.2.6 for now, as i didn't get 
analogtv working with 1.3.x for unknown reasons (the last time i tried), no 
picture :-(
  
Matthias Schniedermeyer Jan. 8, 2006, 3:28 p.m. UTC | #2
Gregoire Favre wrote:
> Hello,
> 
> as I can't live anymore without master-timer, I would like to know if
> the change in vdr-1.3.38 breaks master-timer support ?

AFAICS from reading the Change-file and the later 'vdradmin broke'-mails:
No

Master-Timer only uses the first 3 fields of "E"-fields in the epg.data.

It ignores the 4th and the new 5th field.




Bis denn
  
Grégoire Favre Jan. 8, 2006, 3:35 p.m. UTC | #3
On Sun, Jan 08, 2006 at 04:28:58PM +0100, Matthias Schniedermeyer wrote:

> AFAICS from reading the Change-file and the later 'vdradmin broke'-mails:
> No
> 
> Master-Timer only uses the first 3 fields of "E"-fields in the epg.data.
> 
> It ignores the 4th and the new 5th field.

Oh great, thank you very much :)
  

Patch

--- vdr-1.3.37/epg.c~        2005-11-11 14:37:43.000000000 +0100
+++ vdr-1.3.37/epg.c    2005-12-09 20:54:31.000000000 +0100
@@ -882,6 +882,12 @@ 
      lastCleanup = now;
      ReportEpgBugFixStats(true);
      }
+  struct stat st;
+  if (!epgDataFileName || stat (epgDataFileName,&st) != 0) {
+     lastDump = 0;
+  } else {
+     lastDump = st.st_mtime;
+  }
   if (epgDataFileName && now - lastDump > 600) {
      cSafeFile f(epgDataFileName);
      if (f.Open()) {