diff mbox

[2/2] au0828: Move under dvb

Message ID 1336716892-5446-2-git-send-email-ismael.luceno@gmail.com (mailing list archive)
State Rejected, archived
Headers

Commit Message

Ismael Luceno May 11, 2012, 6:14 a.m. UTC 
  Signed-off-by: Ismael Luceno <ismael.luceno@gmail.com>
---
 drivers/media/dvb/Kconfig                          |    1 +
 drivers/media/dvb/Makefile                         |    1 +
 drivers/media/{video => dvb}/au0828/Kconfig        |    0
 drivers/media/{video => dvb}/au0828/Makefile       |    0
 drivers/media/{video => dvb}/au0828/au0828-cards.c |    0
 drivers/media/{video => dvb}/au0828/au0828-cards.h |    0
 drivers/media/{video => dvb}/au0828/au0828-core.c  |    0
 drivers/media/{video => dvb}/au0828/au0828-dvb.c   |    0
 drivers/media/{video => dvb}/au0828/au0828-i2c.c   |    0
 drivers/media/{video => dvb}/au0828/au0828-reg.h   |    0
 drivers/media/{video => dvb}/au0828/au0828-vbi.c   |    0
 drivers/media/{video => dvb}/au0828/au0828-video.c |    0
 drivers/media/{video => dvb}/au0828/au0828.h       |    0
 drivers/media/video/Kconfig                        |    2 --
 drivers/media/video/Makefile                       |    2 --
 15 files changed, 2 insertions(+), 4 deletions(-)
 rename drivers/media/{video => dvb}/au0828/Kconfig (100%)
 rename drivers/media/{video => dvb}/au0828/Makefile (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-cards.c (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-cards.h (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-core.c (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-dvb.c (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-i2c.c (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-reg.h (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-vbi.c (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-video.c (100%)
 rename drivers/media/{video => dvb}/au0828/au0828.h (100%)

Comments

Devin Heitmueller May 11, 2012, 12:04 p.m. UTC | #1 
On Fri, May 11, 2012 at 2:14 AM, Ismael Luceno <ismael.luceno@gmail.com> wrote:
> Signed-off-by: Ismael Luceno <ismael.luceno@gmail.com>
> ---
>  drivers/media/dvb/Kconfig                          |    1 +
>  drivers/media/dvb/Makefile                         |    1 +
>  drivers/media/{video => dvb}/au0828/Kconfig        |    0
>  drivers/media/{video => dvb}/au0828/Makefile       |    0
>  drivers/media/{video => dvb}/au0828/au0828-cards.c |    0
>  drivers/media/{video => dvb}/au0828/au0828-cards.h |    0
>  drivers/media/{video => dvb}/au0828/au0828-core.c  |    0
>  drivers/media/{video => dvb}/au0828/au0828-dvb.c   |    0
>  drivers/media/{video => dvb}/au0828/au0828-i2c.c   |    0
>  drivers/media/{video => dvb}/au0828/au0828-reg.h   |    0
>  drivers/media/{video => dvb}/au0828/au0828-vbi.c   |    0
>  drivers/media/{video => dvb}/au0828/au0828-video.c |    0
>  drivers/media/{video => dvb}/au0828/au0828.h       |    0
>  drivers/media/video/Kconfig                        |    2 --
>  drivers/media/video/Makefile                       |    2 --
>  15 files changed, 2 insertions(+), 4 deletions(-)
>  rename drivers/media/{video => dvb}/au0828/Kconfig (100%)
>  rename drivers/media/{video => dvb}/au0828/Makefile (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-cards.c (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-cards.h (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-core.c (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-dvb.c (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-i2c.c (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-reg.h (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-vbi.c (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-video.c (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828.h (100%)

What is the motivation for moving these files?  The au0828 is a hybrid
bridge, and every other hybrid bridge is under video?

NACK unless somebody can provide a good reason for doing this.

Devin
Ismael Luceno May 12, 2012, 3:08 a.m. UTC | #2 
On Fri, 11 May 2012 08:04:59 -0400
Devin Heitmueller <dheitmueller@kernellabs.com> wrote:
... 
> What is the motivation for moving these files?

Well, the device was on the wrong Kconfig section, and while thinking
about changing that, I just thought to move it under DVB.

> The au0828 is a hybrid bridge, and every other hybrid bridge is
> under video?

Sorry, the devices I got don't support analog, so I didn't thought
about it that much...

I guess it's arbitrary... isn't it? wouldn't it be better to have an
hybrid section? (just thinking out loud)
Devin Heitmueller May 12, 2012, 10:21 a.m. UTC | #3 
On Fri, May 11, 2012 at 11:08 PM, Ismael Luceno <ismael.luceno@gmail.com> wrote:
> On Fri, 11 May 2012 08:04:59 -0400
> Devin Heitmueller <dheitmueller@kernellabs.com> wrote:
> ...
>> What is the motivation for moving these files?
>
> Well, the device was on the wrong Kconfig section, and while thinking
> about changing that, I just thought to move it under DVB.
>
>> The au0828 is a hybrid bridge, and every other hybrid bridge is
>> under video?
>
> Sorry, the devices I got don't support analog, so I didn't thought
> about it that much...
>
> I guess it's arbitrary... isn't it? wouldn't it be better to have an
> hybrid section? (just thinking out loud)

Yeah, in this case it's largely historical (a product from before the
V4L and DVB subsystems were merged).  At this point I don't see any
real advantage to arbitrarily moving the stuff around.  And in fact in
some areas it's even more ambiguous because some drivers are hybrid
drivers but support both hybrid chips as well as analog-only (the
em28xx driver is one such example).

Anyway, Mauro is welcome to offer his opinion if it differs, but as
far as I'm concerned this patch shouldn't get applied.

Cheers,

Devin
Mauro Carvalho Chehab May 20, 2012, 1:32 p.m. UTC | #4 
Em 12-05-2012 07:21, Devin Heitmueller escreveu:
> On Fri, May 11, 2012 at 11:08 PM, Ismael Luceno <ismael.luceno@gmail.com> wrote:
>> On Fri, 11 May 2012 08:04:59 -0400
>> Devin Heitmueller <dheitmueller@kernellabs.com> wrote:
>> ...
>>> What is the motivation for moving these files?
>>
>> Well, the device was on the wrong Kconfig section, and while thinking
>> about changing that, I just thought to move it under DVB.
>>
>>> The au0828 is a hybrid bridge, and every other hybrid bridge is
>>> under video?
>>
>> Sorry, the devices I got don't support analog, so I didn't thought
>> about it that much...
>>
>> I guess it's arbitrary... isn't it? wouldn't it be better to have an
>> hybrid section? (just thinking out loud)
> 
> Yeah, in this case it's largely historical (a product from before the
> V4L and DVB subsystems were merged).  At this point I don't see any
> real advantage to arbitrarily moving the stuff around.  And in fact in
> some areas it's even more ambiguous because some drivers are hybrid
> drivers but support both hybrid chips as well as analog-only (the
> em28xx driver is one such example).
> 
> Anyway, Mauro is welcome to offer his opinion if it differs, but as
> far as I'm concerned this patch shouldn't get applied.

I won't apply this patch.

If the Kconfig menus are confusing, then we should fix it, instead of moving
things from one place to another ;)

> 
> Cheers,
> 
> Devin
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/dvb/Kconfig b/drivers/media/dvb/Kconfig
index f6e40b3..1cbb061 100644
--- a/drivers/media/dvb/Kconfig
+++ b/drivers/media/dvb/Kconfig
@@ -43,6 +43,7 @@  source "drivers/media/dvb/ttpci/Kconfig"
 
 comment "Supported USB Adapters"
 	depends on DVB_CORE && USB && I2C
+source "drivers/media/dvb/au0828/Kconfig"
 source "drivers/media/dvb/dvb-usb/Kconfig"
 source "drivers/media/dvb/ttusb-budget/Kconfig"
 source "drivers/media/dvb/ttusb-dec/Kconfig"
diff --git a/drivers/media/dvb/Makefile b/drivers/media/dvb/Makefile
index b2cefe6..3f28163 100644
--- a/drivers/media/dvb/Makefile
+++ b/drivers/media/dvb/Makefile
@@ -19,3 +19,4 @@  obj-y        := dvb-core/	\
 		ddbridge/
 
 obj-$(CONFIG_DVB_FIREDTV)	+= firewire/
+obj-$(CONFIG_VIDEO_AU0828)	+= au0828/
diff --git a/drivers/media/video/au0828/Kconfig b/drivers/media/dvb/au0828/Kconfig
similarity index 100%
rename from drivers/media/video/au0828/Kconfig
rename to drivers/media/dvb/au0828/Kconfig
diff --git a/drivers/media/video/au0828/Makefile b/drivers/media/dvb/au0828/Makefile
similarity index 100%
rename from drivers/media/video/au0828/Makefile
rename to drivers/media/dvb/au0828/Makefile
diff --git a/drivers/media/video/au0828/au0828-cards.c b/drivers/media/dvb/au0828/au0828-cards.c
similarity index 100%
rename from drivers/media/video/au0828/au0828-cards.c
rename to drivers/media/dvb/au0828/au0828-cards.c
diff --git a/drivers/media/video/au0828/au0828-cards.h b/drivers/media/dvb/au0828/au0828-cards.h
similarity index 100%
rename from drivers/media/video/au0828/au0828-cards.h
rename to drivers/media/dvb/au0828/au0828-cards.h
diff --git a/drivers/media/video/au0828/au0828-core.c b/drivers/media/dvb/au0828/au0828-core.c
similarity index 100%
rename from drivers/media/video/au0828/au0828-core.c
rename to drivers/media/dvb/au0828/au0828-core.c
diff --git a/drivers/media/video/au0828/au0828-dvb.c b/drivers/media/dvb/au0828/au0828-dvb.c
similarity index 100%
rename from drivers/media/video/au0828/au0828-dvb.c
rename to drivers/media/dvb/au0828/au0828-dvb.c
diff --git a/drivers/media/video/au0828/au0828-i2c.c b/drivers/media/dvb/au0828/au0828-i2c.c
similarity index 100%
rename from drivers/media/video/au0828/au0828-i2c.c
rename to drivers/media/dvb/au0828/au0828-i2c.c
diff --git a/drivers/media/video/au0828/au0828-reg.h b/drivers/media/dvb/au0828/au0828-reg.h
similarity index 100%
rename from drivers/media/video/au0828/au0828-reg.h
rename to drivers/media/dvb/au0828/au0828-reg.h
diff --git a/drivers/media/video/au0828/au0828-vbi.c b/drivers/media/dvb/au0828/au0828-vbi.c
similarity index 100%
rename from drivers/media/video/au0828/au0828-vbi.c
rename to drivers/media/dvb/au0828/au0828-vbi.c
diff --git a/drivers/media/video/au0828/au0828-video.c b/drivers/media/dvb/au0828/au0828-video.c
similarity index 100%
rename from drivers/media/video/au0828/au0828-video.c
rename to drivers/media/dvb/au0828/au0828-video.c
diff --git a/drivers/media/video/au0828/au0828.h b/drivers/media/dvb/au0828/au0828.h
similarity index 100%
rename from drivers/media/video/au0828/au0828.h
rename to drivers/media/dvb/au0828/au0828.h
diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index ce1e7ba..5a717eb 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -721,8 +721,6 @@  menuconfig V4L_PCI_DRIVERS
 
 if V4L_PCI_DRIVERS
 
-source "drivers/media/video/au0828/Kconfig"
-
 source "drivers/media/video/bt8xx/Kconfig"
 
 source "drivers/media/video/cx18/Kconfig"
diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
index a6282a3..90602a9 100644
--- a/drivers/media/video/Makefile
+++ b/drivers/media/video/Makefile
@@ -198,8 +198,6 @@  obj-$(CONFIG_ARCH_DAVINCI)		+= davinci/
 
 obj-$(CONFIG_VIDEO_SH_VOU)		+= sh_vou.o
 
-obj-$(CONFIG_VIDEO_AU0828) += au0828/
-
 obj-$(CONFIG_USB_VIDEO_CLASS)	+= uvc/
 obj-$(CONFIG_VIDEO_SAA7164)     += saa7164/