drxk: Fix regression introduced by commit '[media] Remove Annex A/C selection via roll-off factor'

Message ID 201201041945.58852@orion.escape-edv.de (mailing list archive)
State Superseded, archived
Headers

Commit Message

Oliver Endriss Jan. 4, 2012, 6:45 p.m. UTC
  Fix regression introduced by commit '[media] Remove Annex A/C selection via roll-off factor'
As a result of this commit, DVB-T tuning did not work anymore.

Signed-off-by: Oliver Endriss <o.endriss@gmx.de>
  

Comments

Mauro Carvalho Chehab Jan. 6, 2012, 7:11 p.m. UTC | #1
On 04-01-2012 16:45, Oliver Endriss wrote:
> Fix regression introduced by commit '[media] Remove Annex A/C selection via roll-off factor'
> As a result of this commit, DVB-T tuning did not work anymore.
> 
> Signed-off-by: Oliver Endriss <o.endriss@gmx.de>
> 
> diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c
> index 36e1c82..13f22a1 100644
> --- a/drivers/media/dvb/frontends/drxk_hard.c
> +++ b/drivers/media/dvb/frontends/drxk_hard.c
> @@ -6235,6 +6235,8 @@ static int drxk_set_parameters(struct dvb_frontend *fe)
>  	case SYS_DVBC_ANNEX_C:
>  		state->m_itut_annex_c = true;
>  		break;
> +	case SYS_DVBT:
> +		break;
>  	default:
>  		return -EINVAL;
>  	}
> 
Hi Oliver,

Thanks for the patch! 

It become obsoleted by the patch that converted the driver
to create just one frontend:
	http://git.linuxtv.org/media_tree.git/commitdiff/fa4b2a171d42ffc512b3a86922ad68e1355eb17a

While I don't have DVB-T signal here, the logs were showing that the driver is
switching properly between DVB-T and DVB-C.

Yet, I'd appreciate if you could test it with a real signal,
for us to be 100% sure that everything is working as expected.

Thanks!
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Patch

diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c
index 36e1c82..13f22a1 100644
--- a/drivers/media/dvb/frontends/drxk_hard.c
+++ b/drivers/media/dvb/frontends/drxk_hard.c
@@ -6235,6 +6235,8 @@  static int drxk_set_parameters(struct dvb_frontend *fe)
 	case SYS_DVBC_ANNEX_C:
 		state->m_itut_annex_c = true;
 		break;
+	case SYS_DVBT:
+		break;
 	default:
 		return -EINVAL;
 	}