[v4,5/5] OMAP_VOUT: Increase MAX_DISPLAYS to a larger value

Message ID 1317221368-3301-6-git-send-email-archit@ti.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Archit Taneja Sept. 28, 2011, 2:49 p.m. UTC
  There is no limit to the number of displays that can registered with DSS2. The
current value of MAX_DISPLAYS is 3, set this to 10 so that the 'displays'
member of omap2video_device struct can store more omap_dss_device pointers.

This fixes a crash seen in omap_vout_probe when DSS2 registers for more than 3
displays.

Signed-off-by: Archit Taneja <archit@ti.com>
---
 drivers/media/video/omap/omap_voutdef.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
  

Comments

Hiremath, Vaibhav Sept. 29, 2011, 11:29 a.m. UTC | #1
> -----Original Message-----
> From: Taneja, Archit
> Sent: Wednesday, September 28, 2011 8:19 PM
> To: Hiremath, Vaibhav
> Cc: Valkeinen, Tomi; linux-omap@vger.kernel.org; Semwal, Sumit; linux-
> media@vger.kernel.org; Taneja, Archit
> Subject: [PATCH v4 5/5] OMAP_VOUT: Increase MAX_DISPLAYS to a larger value
> 
> There is no limit to the number of displays that can registered with DSS2.
> The
> current value of MAX_DISPLAYS is 3, set this to 10 so that the 'displays'
> member of omap2video_device struct can store more omap_dss_device pointers.
> 
> This fixes a crash seen in omap_vout_probe when DSS2 registers for more
> than 3
> displays.
> 
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
>  drivers/media/video/omap/omap_voutdef.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/omap/omap_voutdef.h
> b/drivers/media/video/omap/omap_voutdef.h
> index d793501..27a95d2 100644
> --- a/drivers/media/video/omap/omap_voutdef.h
> +++ b/drivers/media/video/omap/omap_voutdef.h
> @@ -25,7 +25,7 @@
>  #define MAC_VRFB_CTXS	4
>  #define MAX_VOUT_DEV	2
>  #define MAX_OVLS	3
> -#define MAX_DISPLAYS	3
> +#define MAX_DISPLAYS	10
>  #define MAX_MANAGERS	3
> 
>  #define QQVGA_WIDTH		160

Acked-by: Vaibhav Hiremath <hvaibhav@ti.com>

Thanks,
Vaibhav


> --
> 1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Patch

diff --git a/drivers/media/video/omap/omap_voutdef.h b/drivers/media/video/omap/omap_voutdef.h
index d793501..27a95d2 100644
--- a/drivers/media/video/omap/omap_voutdef.h
+++ b/drivers/media/video/omap/omap_voutdef.h
@@ -25,7 +25,7 @@ 
 #define MAC_VRFB_CTXS	4
 #define MAX_VOUT_DEV	2
 #define MAX_OVLS	3
-#define MAX_DISPLAYS	3
+#define MAX_DISPLAYS	10
 #define MAX_MANAGERS	3
 
 #define QQVGA_WIDTH		160