Message ID | 1312442059-23935-8-git-send-email-thierry.reding@avionic-design.de (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Thu, 04 Aug 2011 07:14:34 +0000 Received: from casper.infradead.org [85.118.1.10] by localhost.localdomain with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Thu, 04 Aug 2011 08:52:29 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Qos8X-0002qi-Uq; Thu, 04 Aug 2011 07:14:34 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752104Ab1HDHOc (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Thu, 4 Aug 2011 03:14:32 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:54336 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595Ab1HDHOZ (ORCPT <rfc822; linux-media@vger.kernel.org>); Thu, 4 Aug 2011 03:14:25 -0400 Received: from localhost (p548E06E4.dip0.t-ipconnect.de [84.142.6.228]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0Lrlpy-1RVK9B2KB4-013gct; Thu, 04 Aug 2011 09:14:23 +0200 From: Thierry Reding <thierry.reding@avionic-design.de> To: linux-media@vger.kernel.org Subject: [PATCH 07/21] [staging] tm6000: Remove artificial delay. Date: Thu, 4 Aug 2011 09:14:05 +0200 Message-Id: <1312442059-23935-8-git-send-email-thierry.reding@avionic-design.de> X-Mailer: git-send-email 1.7.6 In-Reply-To: <1312442059-23935-1-git-send-email-thierry.reding@avionic-design.de> References: <1312442059-23935-1-git-send-email-thierry.reding@avionic-design.de> X-Provags-ID: V02:K0:rHhObkku31UWtvEQ6uJFbh46ZtFnO4WcDHmWaBOy0ly SmjHWgLDRL5X24h6IGTtk3OTCMkdklGzCkcJ31TU372I/XATiP 03Md2gP7NlPqBnTY94WM711sV+xptyIXV82XXy8sFF7WQ33Er5 vA91wh/6YDpJbXPA0npXeujaZrPbX0NEhGgNS63AeHzE1l6BiQ /I2w+HcMO8ku1FjWbLNh0vNeAq3hBjexDwqOgQbQAo= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Thierry Reding
Aug. 4, 2011, 7:14 a.m. UTC
--- drivers/staging/tm6000/tm6000-core.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
Comments
Em 04-08-2011 04:14, Thierry Reding escreveu: > --- > drivers/staging/tm6000/tm6000-core.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/tm6000/tm6000-core.c b/drivers/staging/tm6000/tm6000-core.c > index e14bd3d..2c156dd 100644 > --- a/drivers/staging/tm6000/tm6000-core.c > +++ b/drivers/staging/tm6000/tm6000-core.c > @@ -86,9 +86,6 @@ int tm6000_read_write_usb(struct tm6000_core *dev, u8 req_type, u8 req, > } > > kfree(data); > - > - msleep(5); > - > return ret; > } > This delay is needed by some tm5600/6000 devices. Maybe it is due to some specific chipset revision, but I can't remember anymore what device(s) were affected. The right thing to do seems to whitelist the devices that don't need any delay there. Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Mauro Carvalho Chehab wrote: > Em 04-08-2011 04:14, Thierry Reding escreveu: > > --- > > drivers/staging/tm6000/tm6000-core.c | 3 --- > > 1 files changed, 0 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/tm6000/tm6000-core.c b/drivers/staging/tm6000/tm6000-core.c > > index e14bd3d..2c156dd 100644 > > --- a/drivers/staging/tm6000/tm6000-core.c > > +++ b/drivers/staging/tm6000/tm6000-core.c > > @@ -86,9 +86,6 @@ int tm6000_read_write_usb(struct tm6000_core *dev, u8 req_type, u8 req, > > } > > > > kfree(data); > > - > > - msleep(5); > > - > > return ret; > > } > > > > This delay is needed by some tm5600/6000 devices. Maybe it is due to > some specific chipset revision, but I can't remember anymore what > device(s) were affected. > > The right thing to do seems to whitelist the devices that don't need > any delay there. This was actually the first thing I patched because I couldn't see any need for it (the Cinergy Hybrid USB Stick worked fine without) and it made the device pretty much unusable (with this delay, firmware loading takes about 30 seconds!). Do you want me to follow up with a white-listing patch? Thierry
Em 01-09-2011 02:13, Thierry Reding escreveu: > * Mauro Carvalho Chehab wrote: >> Em 04-08-2011 04:14, Thierry Reding escreveu: >>> --- >>> drivers/staging/tm6000/tm6000-core.c | 3 --- >>> 1 files changed, 0 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/staging/tm6000/tm6000-core.c b/drivers/staging/tm6000/tm6000-core.c >>> index e14bd3d..2c156dd 100644 >>> --- a/drivers/staging/tm6000/tm6000-core.c >>> +++ b/drivers/staging/tm6000/tm6000-core.c >>> @@ -86,9 +86,6 @@ int tm6000_read_write_usb(struct tm6000_core *dev, u8 req_type, u8 req, >>> } >>> >>> kfree(data); >>> - >>> - msleep(5); >>> - >>> return ret; >>> } >>> >> >> This delay is needed by some tm5600/6000 devices. Maybe it is due to >> some specific chipset revision, but I can't remember anymore what >> device(s) were affected. >> >> The right thing to do seems to whitelist the devices that don't need >> any delay there. > > This was actually the first thing I patched because I couldn't see any need > for it (the Cinergy Hybrid USB Stick worked fine without) and it made the > device pretty much unusable (with this delay, firmware loading takes about > 30 seconds!). Firmware load timing sucks, but at least the device works. The windows application load time is even worse than 30 s, at least for the devices I have here. > > Do you want me to follow up with a white-listing patch? Yes, please. It is good to speed it up, but only when we're sure that this won't cause troubles. > > Thierry -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/tm6000/tm6000-core.c b/drivers/staging/tm6000/tm6000-core.c index e14bd3d..2c156dd 100644 --- a/drivers/staging/tm6000/tm6000-core.c +++ b/drivers/staging/tm6000/tm6000-core.c @@ -86,9 +86,6 @@ int tm6000_read_write_usb(struct tm6000_core *dev, u8 req_type, u8 req, } kfree(data); - - msleep(5); - return ret; }