Message ID | 1313286189.94904.YahooMailClassic@web121720.mail.ne1.yahoo.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Sun, 14 Aug 2011 01:43:15 +0000 Received: from casper.infradead.org [85.118.1.10] by localhost.localdomain with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Sat, 13 Aug 2011 22:45:27 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QsPjP-0004Ji-Gu; Sun, 14 Aug 2011 01:43:15 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752204Ab1HNBnM (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Sat, 13 Aug 2011 21:43:12 -0400 Received: from nm27-vm3.bullet.mail.ne1.yahoo.com ([98.138.91.157]:46922 "HELO nm27-vm3.bullet.mail.ne1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751721Ab1HNBnL convert rfc822-to-8bit (ORCPT <rfc822;linux-media@vger.kernel.org>); Sat, 13 Aug 2011 21:43:11 -0400 Received: from [98.138.90.57] by nm27.bullet.mail.ne1.yahoo.com with NNFMP; 14 Aug 2011 01:43:10 -0000 Received: from [98.138.89.175] by tm10.bullet.mail.ne1.yahoo.com with NNFMP; 14 Aug 2011 01:43:10 -0000 Received: from [127.0.0.1] by omp1031.mail.ne1.yahoo.com with NNFMP; 14 Aug 2011 01:43:10 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 499397.72107.bm@omp1031.mail.ne1.yahoo.com Received: (qmail 11588 invoked by uid 60001); 14 Aug 2011 01:43:10 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1313286190; bh=hTOw8m3o5AmRnzC7Z1u9h9SD5SLjZpM377CT/A8x8+c=; h=X-YMail-OSG:Received:X-Mailer:Message-ID:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=1bCDxqcXV9Q3aQUC0bPcqALkePY+lzHxoamMzt5BexX0FMOtY2kwJ7lUOVUnHylCbvc6cZTImxoK6lWVUoZ8J0tvr3vEAcPYQpjLx6SX84YDFr0FJ/aF7NJT8ztahjgCAGvVkYvDx/IPh+9B9vUKy1fil2HTFKG150DQc9/4Mrw= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Mailer:Message-ID:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=0HtQv/VPEYDkIT8sklPfGg28khHElvFCJxjB8SiAoQQjYv5JUJWJFQmecacspGxd7w3PVXt2sdPCSCQPxO3gI9yjk/sYifS4ZgUbi79+3Grb5N4M1IifTq/b3L5BMfOWEB1sHXB33WEkE3FSPO4fJw0TKwwaL/lwVIIgSgyXSj8=; X-YMail-OSG: BBcsk3sVM1nkvfJIaKMp.QsVeeydzOCKXeWeSkNJtXN1JaN WXrDw3aY0DWEI9sEeHluWHcRSHRoUBuqqqaiPCt54MVVzxezlYD6VWEcXO1t tBV3CryuzKI04Ul0eHbRlhHmbwOtYNe1gTRUjpSRG3.1h3g_Jgf.lImbPkIy QIi_NVDG9qF1jj7HgNKV8_gszYVVbfVfViNIIjECgK0DQd9A89jsIRXUKX24 j0cLNvvEwOlDO2ycr6eFcltjTsIXj5XOm03snABiZ662AleRjAfgIOKVRF2_ cSkA8Nm4exW2zW8xyPC__ztdT1WMzGXIFWqEAeS4sUxP1BC6SAFz84Z2qfaG pcGlqcGxp9bseZdduiqscjB3y.eqnW_SpbXnZMEws9IHp8XjQyX78vf0OFrb sooWSjqZtLCbjeAjLdjS8_zJdRsStLA..5itr6.LXaTWO9V8dnS.7B_9nLtO iiCRX Received: from [86.178.152.254] by web121720.mail.ne1.yahoo.com via HTTP; Sat, 13 Aug 2011 18:43:09 PDT X-Mailer: YahooMailClassic/14.0.4 YahooMailWebService/0.8.113.313619 Message-ID: <1313286189.94904.YahooMailClassic@web121720.mail.ne1.yahoo.com> Date: Sat, 13 Aug 2011 18:43:09 -0700 (PDT) From: Chris Rankin <rankincj@yahoo.com> Subject: Re: PCTV 290e nanostick and remote control support To: Antti Palosaari <crope@iki.fi> Cc: linux-media@vger.kernel.org In-Reply-To: <4E46FB3C.7060402@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Chris Rankin
Aug. 14, 2011, 1:43 a.m. UTC
Hi, The rc-pinnacle-pctv-hd keymap is missing the definition of the OK key: Cheers, Chris -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
On Sat, Aug 13, 2011 at 9:43 PM, Chris Rankin <rankincj@yahoo.com> wrote: > Hi, > > The rc-pinnacle-pctv-hd keymap is missing the definition of the OK key: > > --- linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c.orig 2011-08-14 02:42:01.000000000 +0100 > +++ linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c 2011-08-14 02:12:45.000000000 +0100 > @@ -20,6 +20,7 @@ > { 0x0701, KEY_MENU }, /* Pinnacle logo */ > { 0x0739, KEY_POWER }, > { 0x0703, KEY_VOLUMEUP }, > + { 0x0705, KEY_OK }, > { 0x0709, KEY_VOLUMEDOWN }, > { 0x0706, KEY_CHANNELUP }, > { 0x070c, KEY_CHANNELDOWN }, > > Cheers, > Chris Wow, how the hell did I miss that? I did numerous remotes for em28xx based devices that use that RC profile, and never noticed that issue. Will have to check the merge logs. Maybe the key got lost when they refactored the IR support. Chris, you should add a signed-off-by tag and submit this as a patch so it can be included upstream. Devin
On 08/14/2011 04:48 AM, Devin Heitmueller wrote: > On Sat, Aug 13, 2011 at 9:43 PM, Chris Rankin <rankincj@yahoo.com> wrote: >> The rc-pinnacle-pctv-hd keymap is missing the definition of the OK key: >> >> --- linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c.orig 2011-08-14 02:42:01.000000000 +0100 >> +++ linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c 2011-08-14 02:12:45.000000000 +0100 >> @@ -20,6 +20,7 @@ >> { 0x0701, KEY_MENU }, /* Pinnacle logo */ >> { 0x0739, KEY_POWER }, >> { 0x0703, KEY_VOLUMEUP }, >> + { 0x0705, KEY_OK }, >> { 0x0709, KEY_VOLUMEDOWN }, >> { 0x0706, KEY_CHANNELUP }, >> { 0x070c, KEY_CHANNELDOWN }, >> >> Cheers, >> Chris > > Wow, how the hell did I miss that? I did numerous remotes for em28xx > based devices that use that RC profile, and never noticed that issue. > > Will have to check the merge logs. Maybe the key got lost when they > refactored the IR support. It seems to be very old bug, year 2007, not coming from merge errors! It could be even possible there have not been such button originally. Very weird situation none have found it earlier. For example I just pressed few buttons to see number are coming to console => OK it works (didn't looked all buttons sends events). That's commit which adds those keytables: commit 54d75ebaa02809f24a16624e32706af3bf97588e regards Antti
--- linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c.orig 2011-08-14 02:42:01.000000000 +0100 +++ linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c 2011-08-14 02:12:45.000000000 +0100 @@ -20,6 +20,7 @@ { 0x0701, KEY_MENU }, /* Pinnacle logo */ { 0x0739, KEY_POWER }, { 0x0703, KEY_VOLUMEUP }, + { 0x0705, KEY_OK }, { 0x0709, KEY_VOLUMEDOWN }, { 0x0706, KEY_CHANNELUP }, { 0x070c, KEY_CHANNELDOWN },