diff mbox series

[v4,1/4] media: pisp_be: Drop reference to non-existing function

Message ID 20240902112408.493201-2-jacopo.mondi@ideasonboard.com (mailing list archive)
State Superseded
Headers
Series media: pisp-be: Split jobs creation and scheduling |

Commit Message

Jacopo Mondi Sept. 2, 2024, 11:24 a.m. UTC 
A comment in the pisp_be driver references the
pispbe_schedule_internal() function which doesn't exist.

Drop it.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 drivers/media/platform/raspberrypi/pisp_be/pisp_be.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Laurent Pinchart Sept. 2, 2024, 10:42 p.m. UTC | #1 
Hi Jacopo,

Thank you for the patch.

On Mon, Sep 02, 2024 at 01:24:03PM +0200, Jacopo Mondi wrote:
> A comment in the pisp_be driver references the
> pispbe_schedule_internal() function which doesn't exist.
> 
> Drop it.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/platform/raspberrypi/pisp_be/pisp_be.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> index 65ff2382cffe..8ba1b9f43ba1 100644
> --- a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> @@ -368,10 +368,7 @@ static void pispbe_xlate_addrs(struct pispbe_dev *pispbe,
>  	ret = pispbe_get_planes_addr(addrs, buf[MAIN_INPUT_NODE],
>  				     &pispbe->node[MAIN_INPUT_NODE]);
>  	if (ret <= 0) {
> -		/*
> -		 * This shouldn't happen; pispbe_schedule_internal should insist
> -		 * on an input.
> -		 */
> +		/* Shouldn't happen, we have validated an input is available. */
>  		dev_warn(pispbe->dev, "ISP-BE missing input\n");
>  		hw_en->bayer_enables = 0;
>  		hw_en->rgb_enables = 0;
diff mbox series

Patch

diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
index 65ff2382cffe..8ba1b9f43ba1 100644
--- a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
+++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
@@ -368,10 +368,7 @@  static void pispbe_xlate_addrs(struct pispbe_dev *pispbe,
 	ret = pispbe_get_planes_addr(addrs, buf[MAIN_INPUT_NODE],
 				     &pispbe->node[MAIN_INPUT_NODE]);
 	if (ret <= 0) {
-		/*
-		 * This shouldn't happen; pispbe_schedule_internal should insist
-		 * on an input.
-		 */
+		/* Shouldn't happen, we have validated an input is available. */
 		dev_warn(pispbe->dev, "ISP-BE missing input\n");
 		hw_en->bayer_enables = 0;
 		hw_en->rgb_enables = 0;