[-next,v3,1/2] media: cx231xx: Switch to use kmemdup() helper
Commit Message
Use kmemdup() helper instead of open-coding to
simplify the code.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
v2:
- Adjust use kmemdup() helper to be the first patch as suggested.
---
drivers/media/usb/cx231xx/cx231xx-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
Hi,
W dniu 3.09.2023 o 10:14, Jinjie Ruan pisze:
> Use kmemdup() helper instead of open-coding to
> simplify the code.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
I have already reviewed this before, you can add my
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> ---
> v2:
> - Adjust use kmemdup() helper to be the first patch as suggested.
> ---
> drivers/media/usb/cx231xx/cx231xx-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/cx231xx/cx231xx-core.c b/drivers/media/usb/cx231xx/cx231xx-core.c
> index 727e6268567f..746727ea1a4c 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-core.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-core.c
> @@ -751,10 +751,9 @@ int cx231xx_ep5_bulkout(struct cx231xx *dev, u8 *firmware, u16 size)
> int ret = -ENOMEM;
> u32 *buffer;
>
> - buffer = kzalloc(4096, GFP_KERNEL);
> + buffer = kmemdup(firmware, 4096, GFP_KERNEL);
> if (buffer == NULL)
> return -ENOMEM;
> - memcpy(&buffer[0], firmware, 4096);
>
> ret = usb_bulk_msg(dev->udev, usb_sndbulkpipe(dev->udev, 5),
> buffer, 4096, &actlen, 2000);
On 2023/9/8 20:19, Andrzej Pietrasiewicz wrote:
> Hi,
>
> W dniu 3.09.2023 o 10:14, Jinjie Ruan pisze:
>> Use kmemdup() helper instead of open-coding to
>> simplify the code.
>>
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>
> I have already reviewed this before, you can add my
>
> Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Thank you very much!
>
>> ---
>> v2:
>> - Adjust use kmemdup() helper to be the first patch as suggested.
>> ---
>> drivers/media/usb/cx231xx/cx231xx-core.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/usb/cx231xx/cx231xx-core.c
>> b/drivers/media/usb/cx231xx/cx231xx-core.c
>> index 727e6268567f..746727ea1a4c 100644
>> --- a/drivers/media/usb/cx231xx/cx231xx-core.c
>> +++ b/drivers/media/usb/cx231xx/cx231xx-core.c
>> @@ -751,10 +751,9 @@ int cx231xx_ep5_bulkout(struct cx231xx *dev, u8
>> *firmware, u16 size)
>> int ret = -ENOMEM;
>> u32 *buffer;
>> - buffer = kzalloc(4096, GFP_KERNEL);
>> + buffer = kmemdup(firmware, 4096, GFP_KERNEL);
>> if (buffer == NULL)
>> return -ENOMEM;
>> - memcpy(&buffer[0], firmware, 4096);
>> ret = usb_bulk_msg(dev->udev, usb_sndbulkpipe(dev->udev, 5),
>> buffer, 4096, &actlen, 2000);
>
@@ -751,10 +751,9 @@ int cx231xx_ep5_bulkout(struct cx231xx *dev, u8 *firmware, u16 size)
int ret = -ENOMEM;
u32 *buffer;
- buffer = kzalloc(4096, GFP_KERNEL);
+ buffer = kmemdup(firmware, 4096, GFP_KERNEL);
if (buffer == NULL)
return -ENOMEM;
- memcpy(&buffer[0], firmware, 4096);
ret = usb_bulk_msg(dev->udev, usb_sndbulkpipe(dev->udev, 5),
buffer, 4096, &actlen, 2000);