Message ID | 4D35BC6D.1050801@matrix-vision.de (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-path: <mchehab@pedra> Envelope-to: mchehab@pedra Delivery-date: Tue, 18 Jan 2011 14:28:18 -0200 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from <mchehab@pedra>) id 1PfEPq-0005in-G8 for mchehab@pedra; Tue, 18 Jan 2011 14:28:18 -0200 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Tue, 18 Jan 2011 14:28:18 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PfELv-0007Eg-OA; Tue, 18 Jan 2011 16:24:16 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751781Ab1ARQYO (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Tue, 18 Jan 2011 11:24:14 -0500 Received: from mail2.matrix-vision.com ([85.214.244.251]:51399 "EHLO mail2.matrix-vision.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122Ab1ARQYN (ORCPT <rfc822;linux-media@vger.kernel.org>); Tue, 18 Jan 2011 11:24:13 -0500 X-Greylist: delayed 574 seconds by postgrey-1.27 at vger.kernel.org; Tue, 18 Jan 2011 11:24:13 EST Received: from mail2.matrix-vision.com (localhost [127.0.0.1]) by mail2.matrix-vision.com (Postfix) with ESMTP id 3A89241400; Tue, 18 Jan 2011 17:14:38 +0100 (CET) Received: from erinome (g2.matrix-vision.com [80.152.136.245]) by mail2.matrix-vision.com (Postfix) with ESMTPA id 10909413ED; Tue, 18 Jan 2011 17:14:38 +0100 (CET) Received: from erinome (localhost [127.0.0.1]) by erinome (Postfix) with ESMTP id B77EB6F8A; Tue, 18 Jan 2011 17:14:37 +0100 (CET) Received: by erinome (Postfix, from userid 108) id ACB346F9C; Tue, 18 Jan 2011 17:14:37 +0100 (CET) Received: from [192.168.65.46] (host65-46.intern.matrix-vision.de [192.168.65.46]) by erinome (Postfix) with ESMTPA id 872606F8A; Tue, 18 Jan 2011 17:14:37 +0100 (CET) Message-ID: <4D35BC6D.1050801@matrix-vision.de> Date: Tue, 18 Jan 2011 17:14:37 +0100 From: Michael Jones <michael.jones@matrix-vision.de> User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101029 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Sakari Ailus <sakari.ailus@maxwell.research.nokia.com> CC: Linux Media Mailing List <linux-media@vger.kernel.org> Subject: link error w/ media-0006-sensors Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-MV-Disclaimer: true (erinome) X-AV-Checked: ClamAV using ClamSMTP (erinome) X-AV-Checked: ClamAV using ClamSMTP (mail2) Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: <mchehab@pedra> |
Commit Message
Michael Jones
Jan. 18, 2011, 4:14 p.m. UTC
Hi Laurent & Sakari, On Laurent's media-0006-sensors branch, when compiling with CONFIG_VIDEO_OMAP3=m, I got the following linking error: ERROR: "omap_pm_set_min_bus_tput" [drivers/media/video/isp/omap3-isp.ko] undefined! I can get rid of the error with the patch below. But as always, I wonder: Why didn't anybody else come across this error? Are you all compiling with VIDEO_OMAP3=y? Is there a config file somewhere I can see where someone is using that? And would anything be wrong with the patch below? -Michael MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
Hi Michael, On Tuesday 18 January 2011 17:14:37 Michael Jones wrote: > Hi Laurent & Sakari, > > On Laurent's media-0006-sensors branch, when compiling with > CONFIG_VIDEO_OMAP3=m, I got the following linking error: > > ERROR: "omap_pm_set_min_bus_tput" [drivers/media/video/isp/omap3-isp.ko] > undefined! > > I can get rid of the error with the patch below. But as always, I > wonder: Why didn't anybody else come across this error? Are you all > compiling with VIDEO_OMAP3=y? Is there a config file somewhere I can see > where someone is using that? > > And would anything be wrong with the patch below? Martin Hostettler sent the same patch to linux-omap today ("[PATCH] OMAP: PM: Export omap_pm_set_min_bus_tput to modules"). See Please see Paul Wamsley's answer on the list.
Hi Laurent, sorry to resurrect this from a month ago... I've continued to export omap_pm_set_min_bus_tput() to enable building the omap3-isp module, although Paul Wamsley's reply you referred to clearly indicates that this is the wrong approach. Aren't you also building omap3-isp as a module? How are you guys getting around this? -Michael On 01/19/2011 12:30 AM, Laurent Pinchart wrote: > Hi Michael, > > On Tuesday 18 January 2011 17:14:37 Michael Jones wrote: >> Hi Laurent & Sakari, >> >> On Laurent's media-0006-sensors branch, when compiling with >> CONFIG_VIDEO_OMAP3=m, I got the following linking error: >> >> ERROR: "omap_pm_set_min_bus_tput" [drivers/media/video/isp/omap3-isp.ko] >> undefined! >> >> I can get rid of the error with the patch below. But as always, I >> wonder: Why didn't anybody else come across this error? Are you all >> compiling with VIDEO_OMAP3=y? Is there a config file somewhere I can see >> where someone is using that? >> >> And would anything be wrong with the patch below? > > Martin Hostettler sent the same patch to linux-omap today ("[PATCH] OMAP: PM: > Export omap_pm_set_min_bus_tput to modules"). See Please see Paul Wamsley's > answer on the list. > MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Michael, On Monday 21 February 2011 15:47:28 Michael Jones wrote: > Hi Laurent, > > sorry to resurrect this from a month ago... > > I've continued to export omap_pm_set_min_bus_tput() to enable building > the omap3-isp module, although Paul Wamsley's reply you referred to > clearly indicates that this is the wrong approach. > > Aren't you also building omap3-isp as a module? How are you guys > getting around this? On MeeGo omap_pm_set_min_bus_tput() is exported. A quick fix would be to add a callback to board code, or even remove the call completely, as omap_pm_set_min_bus_tput() in a no-op in mainline. A good fix would be to export the functionality of omap_pm_set_min_bus_tput() in a generic API that could be used by drivers.
diff --git a/arch/arm/plat-omap/omap-pm-noop.c b/arch/arm/plat-omap/omap-pm-noop.c index e129ce8..9e0bcb6 100644 --- a/arch/arm/plat-omap/omap-pm-noop.c +++ b/arch/arm/plat-omap/omap-pm-noop.c @@ -88,6 +88,7 @@ int omap_pm_set_min_bus_tput(struct device *dev, u8 agent_id, unsigned long r) return 0; } +EXPORT_SYMBOL_GPL(omap_pm_set_min_bus_tput); int omap_pm_set_max_dev_wakeup_lat(struct device *req_dev, struct device *dev, long t)