diff mbox

lirc: Make struct file_operations pointer const

Message ID alpine.DEB.2.00.1009302153210.2434@ayla.of.borg (mailing list archive)
State Superseded, archived
Headers

Commit Message

Geert Uytterhoeven Sept. 30, 2010, 7:55 p.m. UTC 
  struct file_operations was made const in the drivers, but not in struct
lirc_driver:

drivers/staging/lirc/lirc_it87.c:365: warning: initialization discards qualifiers from pointer target type
drivers/staging/lirc/lirc_parallel.c:571: warning: initialization discards qualifiers from pointer target type
drivers/staging/lirc/lirc_serial.c:1073: warning: initialization discards qualifiers from pointer target type
drivers/staging/lirc/lirc_sir.c:482: warning: initialization discards qualifiers from pointer target type
drivers/staging/lirc/lirc_zilog.c:1284: warning: assignment discards qualifiers from pointer target type

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 include/media/lirc_dev.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Jarod Wilson Sept. 30, 2010, 8:19 p.m. UTC | #1 
On Thu, Sep 30, 2010 at 09:55:07PM +0200, Geert Uytterhoeven wrote:
> struct file_operations was made const in the drivers, but not in struct
> lirc_driver:
> 
> drivers/staging/lirc/lirc_it87.c:365: warning: initialization discards qualifiers from pointer target type
> drivers/staging/lirc/lirc_parallel.c:571: warning: initialization discards qualifiers from pointer target type
> drivers/staging/lirc/lirc_serial.c:1073: warning: initialization discards qualifiers from pointer target type
> drivers/staging/lirc/lirc_sir.c:482: warning: initialization discards qualifiers from pointer target type
> drivers/staging/lirc/lirc_zilog.c:1284: warning: assignment discards qualifiers from pointer target type
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Whoops, yeah, obvious fix.

Acked-by: Jarod Wilson <jarod@redhat.com>
diff mbox

Patch

diff --git a/include/media/lirc_dev.h b/include/media/lirc_dev.h
index b1f6066..71a896e 100644
--- a/include/media/lirc_dev.h
+++ b/include/media/lirc_dev.h
@@ -139,7 +139,7 @@  struct lirc_driver {
 	struct lirc_buffer *rbuf;
 	int (*set_use_inc) (void *data);
 	void (*set_use_dec) (void *data);
-	struct file_operations *fops;
+	const struct file_operations *fops;
 	struct device *dev;
 	struct module *owner;
 };