[v2,1/7] media: rockchip: rkisp1: remove unused irq variable
Commit Message
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
The irq variable in struct rkisp1 is unused as it is only used
to request the irq during probe, so remove it.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-common.h | 1 -
drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 --
2 files changed, 3 deletions(-)
Comments
Hi,
On 15.06.21 03:37, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The irq variable in struct rkisp1 is unused as it is only used
> to request the irq during probe, so remove it.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-common.h | 1 -
> drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> index 038c303a8aed..be8a350c7527 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> @@ -352,7 +352,6 @@ struct rkisp1_debug {
> */
> struct rkisp1_device {
> void __iomem *base_addr;
> - int irq;
> struct device *dev;
> unsigned int clk_size;
> struct clk_bulk_data clks[RKISP1_MAX_BUS_CLK];
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> index 7474150b94ed..7afa4c123834 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> @@ -489,8 +489,6 @@ static int rkisp1_probe(struct platform_device *pdev)
> return ret;
> }
>
> - rkisp1->irq = irq;
> -
> for (i = 0; i < match_data->size; i++)
> rkisp1->clks[i].id = match_data->clks[i];
> ret = devm_clk_bulk_get(dev, match_data->size, rkisp1->clks);
>
@@ -352,7 +352,6 @@ struct rkisp1_debug {
*/
struct rkisp1_device {
void __iomem *base_addr;
- int irq;
struct device *dev;
unsigned int clk_size;
struct clk_bulk_data clks[RKISP1_MAX_BUS_CLK];
@@ -489,8 +489,6 @@ static int rkisp1_probe(struct platform_device *pdev)
return ret;
}
- rkisp1->irq = irq;
-
for (i = 0; i < match_data->size; i++)
rkisp1->clks[i].id = match_data->clks[i];
ret = devm_clk_bulk_get(dev, match_data->size, rkisp1->clks);