Message ID | 1276547208-26569-2-git-send-email-justinmattock@gmail.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Mon, 14 Jun 2010 20:29:25 +0000 Received: from bombadil.infradead.org [18.85.46.34] by localhost with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Tue, 15 Jun 2010 07:59:48 +0300 (EEST) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OOGHd-00053T-7H; Mon, 14 Jun 2010 20:29:25 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755693Ab0FNU0w (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Mon, 14 Jun 2010 16:26:52 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:43718 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755366Ab0FNU0u (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 14 Jun 2010 16:26:50 -0400 Received: by mail-pw0-f46.google.com with SMTP id 1so3012616pwi.19 for <multiple recipients>; Mon, 14 Jun 2010 13:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=HMXLuamrXI1adG4GDeXP6bT7bzi6SQGbNYxpRKoH8eY=; b=N6C/XRw6sMFDPVk8dNqR6IjW8JFHUTgszOLTaW7N+EVVR1+Zwo9HcUhQz+cPeHT9Nt 2m152lATnIs/h7JYXgfTFxl2nbt9pYCV7Ppuguwek22tUbCELKpPW/jcKUL74FfMiA+V w6d7c1r1/zPCAKPeH5iiczoi54BMmm9ryDcP0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=TfAAwmb5L2tlxzexKd3S87YSz1WlFBHOq/m1zyawNrmfqZPLOcvgt71IFGZWWiP+UE 8p98Jz+bbzlEh2TwNi13Nz1h5HQxgn1gG2YNWzcelbfT0aN3JTiaKO1AfoWURf9EMGY0 iRqVj3yk914spBVJP44xUlX6OEbY1A2kxHmgM= Received: by 10.114.186.17 with SMTP id j17mr4916400waf.108.1276547208283; Mon, 14 Jun 2010 13:26:48 -0700 (PDT) Received: from localhost.localdomain ([76.91.45.220]) by mx.google.com with ESMTPS id r20sm58982854wam.5.2010.06.14.13.26.46 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 14 Jun 2010 13:26:47 -0700 (PDT) From: "Justin P. Mattock" <justinmattock@gmail.com> To: linux-kernel@vger.kernel.org Cc: reiserfs-devel@vger.kernel.org, linux-bluetooth@vger.kernel.org, clemens@ladisch.de, debora@linux.vnet.ibm.com, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-media@vger.kernel.org, "Justin P. Mattock" <justinmattock@gmail.com> Subject: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used. Date: Mon, 14 Jun 2010 13:26:41 -0700 Message-Id: <1276547208-26569-2-git-send-email-justinmattock@gmail.com> X-Mailer: git-send-email 1.7.1.rc1.21.gf3bd6 In-Reply-To: <1276547208-26569-1-git-send-email-justinmattock@gmail.com> References: <1276547208-26569-1-git-send-email-justinmattock@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Justin P. Mattock
June 14, 2010, 8:26 p.m. UTC
Not sure if this is correct or not.
the below patch gets rid of this warning message
produced by gcc 4.6.0
fs/reiserfs/stree.c: In function 'search_by_key':
fs/reiserfs/stree.c:602:6: warning: variable 'right_neighbor_of_leaf_node' set but not used
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
fs/reiserfs/stree.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
Comments
On 13:26 Mon 14 Jun , Justin P. Mattock wrote: > @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s > > pathrelse(search_path); > > - right_neighbor_of_leaf_node = 0; > - > + This hunk introduces whitespace on the empty line, which is not cool. > /* With each iteration of this loop we search through the items in the > current node, and calculate the next current node(next path element) > for the next iteration of this loop.. */ > @@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s > starting from the root. */ > block_number = SB_ROOT_BLOCK(sb); > expected_level = -1; > - right_neighbor_of_leaf_node = 0; > - > + Here, too. Most of the patches in this series have similar issues.
Justin P. Mattock wrote: > Not sure if this is correct or not. > the below patch gets rid of this warning message > produced by gcc 4.6.0 > > fs/reiserfs/stree.c: In function 'search_by_key': > fs/reiserfs/stree.c:602:6: warning: variable 'right_neighbor_of_leaf_node' set but not used > > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > Acked-by: Edward Shishkin <edward.shishkin@gmail.com> > --- > fs/reiserfs/stree.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c > index 313d39d..73086ad 100644 > --- a/fs/reiserfs/stree.c > +++ b/fs/reiserfs/stree.c > @@ -599,7 +599,6 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s > struct buffer_head *bh; > struct path_element *last_element; > int node_level, retval; > - int right_neighbor_of_leaf_node; > int fs_gen; > struct buffer_head *reada_bh[SEARCH_BY_KEY_READA]; > b_blocknr_t reada_blocks[SEARCH_BY_KEY_READA]; > @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s > > pathrelse(search_path); > > - right_neighbor_of_leaf_node = 0; > - > + > /* With each iteration of this loop we search through the items in the > current node, and calculate the next current node(next path element) > for the next iteration of this loop.. */ > @@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s > starting from the root. */ > block_number = SB_ROOT_BLOCK(sb); > expected_level = -1; > - right_neighbor_of_leaf_node = 0; > - > + > /* repeat search from the root */ > continue; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/14/2010 01:48 PM, Nick Bowler wrote: > On 13:26 Mon 14 Jun , Justin P. Mattock wrote: >> @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s >> >> pathrelse(search_path); >> >> - right_neighbor_of_leaf_node = 0; >> - >> + > > This hunk introduces whitespace on the empty line, which is not cool. I can resend!!(biggest problem is working through these warnings) > >> /* With each iteration of this loop we search through the items in the >> current node, and calculate the next current node(next path element) >> for the next iteration of this loop.. */ >> @@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s >> starting from the root. */ >> block_number = SB_ROOT_BLOCK(sb); >> expected_level = -1; >> - right_neighbor_of_leaf_node = 0; >> - >> + > > Here, too. > > Most of the patches in this series have similar issues. > main thing now(for me atleast)is, is this actual dead code or what? if not then something else needs to be done, if yes then I guess I can resend this, with out the whitespace issue. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/14/2010 02:05 PM, Edward Shishkin wrote: > Justin P. Mattock wrote: >> Not sure if this is correct or not. >> the below patch gets rid of this warning message >> produced by gcc 4.6.0 >> >> fs/reiserfs/stree.c: In function 'search_by_key': >> fs/reiserfs/stree.c:602:6: warning: variable >> 'right_neighbor_of_leaf_node' set but not used >> >> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > > Acked-by: Edward Shishkin <edward.shishkin@gmail.com> > o.k.!! what about the whitespace issue? from what I remember I did notice the "+" that git does when making patches like this but given some many of these warnings I just did a quick workaround or however then figured to worry later on that. >> --- >> fs/reiserfs/stree.c | 7 ++----- >> 1 files changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c >> index 313d39d..73086ad 100644 >> --- a/fs/reiserfs/stree.c >> +++ b/fs/reiserfs/stree.c >> @@ -599,7 +599,6 @@ int search_by_key(struct super_block *sb, const >> struct cpu_key *key, /* Key to s >> struct buffer_head *bh; >> struct path_element *last_element; >> int node_level, retval; >> - int right_neighbor_of_leaf_node; >> int fs_gen; >> struct buffer_head *reada_bh[SEARCH_BY_KEY_READA]; >> b_blocknr_t reada_blocks[SEARCH_BY_KEY_READA]; >> @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const >> struct cpu_key *key, /* Key to s >> >> pathrelse(search_path); >> >> - right_neighbor_of_leaf_node = 0; >> - >> + >> /* With each iteration of this loop we search through the items in the >> current node, and calculate the next current node(next path element) >> for the next iteration of this loop.. */ >> @@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const >> struct cpu_key *key, /* Key to s >> starting from the root. */ >> block_number = SB_ROOT_BLOCK(sb); >> expected_level = -1; >> - right_neighbor_of_leaf_node = 0; >> - >> + >> /* repeat search from the root */ >> continue; >> } > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Justin P. Mattock wrote: > On 06/14/2010 02:05 PM, Edward Shishkin wrote: >> Justin P. Mattock wrote: >>> Not sure if this is correct or not. >>> the below patch gets rid of this warning message >>> produced by gcc 4.6.0 >>> >>> fs/reiserfs/stree.c: In function 'search_by_key': >>> fs/reiserfs/stree.c:602:6: warning: variable >>> 'right_neighbor_of_leaf_node' set but not used >>> >>> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> >> >> Acked-by: Edward Shishkin <edward.shishkin@gmail.com> >> > > o.k.!! > what about the whitespace issue? Whitespaces should be removed. I recommend quilt package for managing patches: "quilt refresh --strip-trailing-whitespace" is your friend.. Thanks, Edward. > > from what I remember I did notice the "+" > that git does when making patches like this > but given some many of these warnings I just > did a quick workaround or however then figured > to worry later on that. > >>> --- >>> fs/reiserfs/stree.c | 7 ++----- >>> 1 files changed, 2 insertions(+), 5 deletions(-) >>> >>> diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c >>> index 313d39d..73086ad 100644 >>> --- a/fs/reiserfs/stree.c >>> +++ b/fs/reiserfs/stree.c >>> @@ -599,7 +599,6 @@ int search_by_key(struct super_block *sb, const >>> struct cpu_key *key, /* Key to s >>> struct buffer_head *bh; >>> struct path_element *last_element; >>> int node_level, retval; >>> - int right_neighbor_of_leaf_node; >>> int fs_gen; >>> struct buffer_head *reada_bh[SEARCH_BY_KEY_READA]; >>> b_blocknr_t reada_blocks[SEARCH_BY_KEY_READA]; >>> @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const >>> struct cpu_key *key, /* Key to s >>> >>> pathrelse(search_path); >>> >>> - right_neighbor_of_leaf_node = 0; >>> - >>> + >>> /* With each iteration of this loop we search through the items in the >>> current node, and calculate the next current node(next path element) >>> for the next iteration of this loop.. */ >>> @@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const >>> struct cpu_key *key, /* Key to s >>> starting from the root. */ >>> block_number = SB_ROOT_BLOCK(sb); >>> expected_level = -1; >>> - right_neighbor_of_leaf_node = 0; >>> - >>> + >>> /* repeat search from the root */ >>> continue; >>> } >> >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/14/2010 02:47 PM, Edward Shishkin wrote: > Justin P. Mattock wrote: >> On 06/14/2010 02:05 PM, Edward Shishkin wrote: >>> Justin P. Mattock wrote: >>>> Not sure if this is correct or not. >>>> the below patch gets rid of this warning message >>>> produced by gcc 4.6.0 >>>> >>>> fs/reiserfs/stree.c: In function 'search_by_key': >>>> fs/reiserfs/stree.c:602:6: warning: variable >>>> 'right_neighbor_of_leaf_node' set but not used >>>> >>>> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> >>> >>> Acked-by: Edward Shishkin <edward.shishkin@gmail.com> >>> >> >> o.k.!! >> what about the whitespace issue? > > Whitespaces should be removed. > I recommend quilt package for managing patches: > "quilt refresh --strip-trailing-whitespace" is your friend.. > > Thanks, > Edward. > o.k. I resent this.. fixed the whitespace(hopefully) and add your Acked to it. as for quilt I'll have to look into that.. (using a lfs system, so if the sourcecode is easy to deal with(build), then it's a good but if it becomes a nightmare maybe not!!). Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 14 Jun, Justin P. Mattock wrote: > On 06/14/2010 02:47 PM, Edward Shishkin wrote: >> Whitespaces should be removed. >> I recommend quilt package for managing patches: >> "quilt refresh --strip-trailing-whitespace" is your friend.. > > o.k. I resent this.. fixed the whitespace(hopefully) > and add your Acked to it. > as for quilt I'll have to look into that.. > (using a lfs system, so if the sourcecode is easy > to deal with(build), then it's a good but if it becomes > a nightmare maybe not!!). Since you appear to generate the patches with git, you can use "git diff --check [...]" for some basic whitespace checks (additions of trailing space, additions of space before tab). For more extensive checks, try "git diff [...] | scripts/checkpatch.pl -". Check this before you commit. If you committed already, "git commit --amend [-a] [...]" lets you alter the very last commit of course.
On 06/14/2010 04:07 PM, Stefan Richter wrote: > On 14 Jun, Justin P. Mattock wrote: >> On 06/14/2010 02:47 PM, Edward Shishkin wrote: >>> Whitespaces should be removed. >>> I recommend quilt package for managing patches: >>> "quilt refresh --strip-trailing-whitespace" is your friend.. >> >> o.k. I resent this.. fixed the whitespace(hopefully) >> and add your Acked to it. >> as for quilt I'll have to look into that.. >> (using a lfs system, so if the sourcecode is easy >> to deal with(build), then it's a good but if it becomes >> a nightmare maybe not!!). > > Since you appear to generate the patches with git, you can use "git diff > --check [...]" for some basic whitespace checks (additions of trailing > space, additions of space before tab). For more extensive checks, try > "git diff [...] | scripts/checkpatch.pl -". Check this before you > commit. If you committed already, "git commit --amend [-a] [...]" lets > you alter the very last commit of course. Thanks for the info on this, copied it down in my book of commands... Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c index 313d39d..73086ad 100644 --- a/fs/reiserfs/stree.c +++ b/fs/reiserfs/stree.c @@ -599,7 +599,6 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s struct buffer_head *bh; struct path_element *last_element; int node_level, retval; - int right_neighbor_of_leaf_node; int fs_gen; struct buffer_head *reada_bh[SEARCH_BY_KEY_READA]; b_blocknr_t reada_blocks[SEARCH_BY_KEY_READA]; @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s pathrelse(search_path); - right_neighbor_of_leaf_node = 0; - + /* With each iteration of this loop we search through the items in the current node, and calculate the next current node(next path element) for the next iteration of this loop.. */ @@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s starting from the root. */ block_number = SB_ROOT_BLOCK(sb); expected_level = -1; - right_neighbor_of_leaf_node = 0; - + /* repeat search from the root */ continue; }