[v4l/dvb] firedtv: add forgotten __exit annotation

Message ID tkrat.c98a9e80d83e315a@s5r6.in-berlin.de (mailing list archive)
State Superseded, archived
Headers

Commit Message

Stefan Richter Dec. 26, 2009, 12:45 a.m. UTC
  fdtv_fw_exit() is part of the firedtv driver's .exit.text section.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 drivers/media/dvb/firewire/firedtv-fw.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Stefan Richter Jan. 10, 2010, 3:12 p.m. UTC | #1
Stefan Richter wrote on 2009-12-26:
> fdtv_fw_exit() is part of the firedtv driver's .exit.text section.
...
> --- linux-2.6.33-rc2.orig/drivers/media/dvb/firewire/firedtv-fw.c
> +++ linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c
> @@ -332,7 +332,7 @@ int __init fdtv_fw_init(void)
>  	return driver_register(&fdtv_driver.driver);
>  }
>  
> -void fdtv_fw_exit(void)
> +void __exit fdtv_fw_exit(void)
>  {
>  	driver_unregister(&fdtv_driver.driver);
>  	fw_core_remove_address_handler(&fcp_handler);
> 

This patch is bogus.  fdtv_fw_exit() is also called from firedtv's init.
  

Patch

Index: linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c
===================================================================
--- linux-2.6.33-rc2.orig/drivers/media/dvb/firewire/firedtv-fw.c
+++ linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c
@@ -332,7 +332,7 @@  int __init fdtv_fw_init(void)
 	return driver_register(&fdtv_driver.driver);
 }
 
-void fdtv_fw_exit(void)
+void __exit fdtv_fw_exit(void)
 {
 	driver_unregister(&fdtv_driver.driver);
 	fw_core_remove_address_handler(&fcp_handler);