| Message ID | 4F2AD89E.70805@xenotime.net (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33])
by www.linuxtv.org with esmtp (Exim 4.72)
(envelope-from <linux-media-owner@vger.kernel.org>)
id 1Rt0gP-00008C-OY
for patchwork@linuxtv.org; Thu, 02 Feb 2012 18:42:53 +0100
X-tubIT-Incoming-IP: 209.132.180.67
Received: from vger.kernel.org ([209.132.180.67])
by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp
for <patchwork@linuxtv.org>
id 1Rt0gO-0001rK-IV; Thu, 02 Feb 2012 18:42:53 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1755534Ab2BBRmg (ORCPT <rfc822;patchwork@linuxtv.org>);
Thu, 2 Feb 2012 12:42:36 -0500
Received: from oproxy3-pub.bluehost.com ([69.89.21.8]:42912 "HELO
oproxy3-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with SMTP id S1754657Ab2BBRme (ORCPT
<rfc822; linux-media@vger.kernel.org>); Thu, 2 Feb 2012 12:42:34 -0500
Received: (qmail 9408 invoked by uid 0); 2 Feb 2012 17:42:33 -0000
Received: from unknown (HELO box742.bluehost.com) (66.147.244.242)
by oproxy3.bluehost.com with SMTP; 2 Feb 2012 17:42:33 -0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=xenotime.net; s=default;
h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID;
bh=CbalO452proTu2/j2uOPzfhYUCPYR8kgvy9zv2s2YVs=;
b=pAPGavtyS6+qe3+UHVvfuacT3f7aX2E9BdaCWwV0EA3Go9yY5/NmyiQz88j6AcFC9Z8G/XgSPSauPdFCmVAfikWp+6ztmtqEw2wCcBUCBB4OpzUU+goGSi7RhLfl+JBi;
Received: from static-50-53-38-135.bvtn.or.frontiernet.net ([50.53.38.135]
helo=[192.168.1.9])
by box742.bluehost.com with esmtpsa (TLSv1:AES256-SHA:256)
(Exim 4.76) (envelope-from <rdunlap@xenotime.net>)
id 1Rt0g5-0007kW-Oz; Thu, 02 Feb 2012 10:42:33 -0700
Message-ID: <4F2AD89E.70805@xenotime.net>
Date: Thu, 02 Feb 2012 10:40:30 -0800
From: Randy Dunlap <rdunlap@xenotime.net>
Organization: YPO4
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
rv:1.9.2.15) Gecko/20110323 Thunderbird/3.1.9
MIME-Version: 1.0
To: Manjunatha Halli <x0130808@ti.com>
CC: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Manjunatha Halli <manjunatha_halli@ti.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: [PATCH] Re: linux-next: Tree for Feb 2 (media/radio/wl128x)
References: <20120202144516.11b33e667a7cbb8d85d96226@canb.auug.org.au>
<4F2AD0E4.6020801@xenotime.net> <4F2AC5F8.1000901@ti.com>
In-Reply-To: <4F2AC5F8.1000901@ti.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net}
{sentby:smtp auth 50.53.38.135 authed with
rdunlap@xenotime.net}
Sender: linux-media-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379,
Antispam-Data: 2012.2.2.173314
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report='
MULTIPLE_RCPTS 0.1, MSGID_ADDED_BY_MTA 0.05,
BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0,
BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0,
__ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0,
__CT_TEXT_PLAIN 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0,
__MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0,
__MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0,
__URI_NO_WWW 0, __URI_NS , __USER_AGENT 0'
|
Commit Message
Randy Dunlap
Feb. 2, 2012, 6:40 p.m. UTC
On 02/02/2012 09:20 AM, Manjunatha Halli wrote: > Hi Randy Dunlap, > > In config file you are missing the CONFIG_TI_ST config which builds the TI's shared transport driver upon which the FM driver works. > > Please select this config in drivers/misc/ti-st/Kconfig which will solve the problem. Wrong answer. The problem seems to be that GPIOLIB is not enabled, but wl128x Kconfig says: config RADIO_WL128X tristate "Texas Instruments WL128x FM Radio" depends on VIDEO_V4L2 && RFKILL select TI_ST if NET && GPIOLIB so TI_ST is not selected here. The Kconfig files should handle this properly. Here is one possible fix for you to consider. --- From: Randy Dunlap <rdunlap@xenotime.net> Fix build errors when GPIOLIB is not enabled. Fix wl128x Kconfig to depend on GPIOLIB since TI_ST also depends on GPIOLIB. (.text+0xe6d60): undefined reference to `st_register' (.text+0xe7016): undefined reference to `st_unregister' (.text+0xe70ce): undefined reference to `st_unregister' Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> Cc: Manjunatha Halli <manjunatha_halli@ti.com> --- drivers/media/radio/wl128x/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) > Regards > Manju > > On 02/02/2012 12:07 PM, Randy Dunlap wrote: >> On 02/01/2012 07:45 PM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20120201: >> >> drivers/built-in.o: In function `fmc_prepare': >> (.text+0xe6d60): undefined reference to `st_register' >> drivers/built-in.o: In function `fmc_prepare': >> (.text+0xe7016): undefined reference to `st_unregister' >> drivers/built-in.o: In function `fmc_release': >> (.text+0xe70ce): undefined reference to `st_unregister' >> >> >> Full randconfig file is attached.
Comments
On 02/02/2012 12:40 PM, Randy Dunlap wrote: > On 02/02/2012 09:20 AM, Manjunatha Halli wrote: >> Hi Randy Dunlap, >> >> In config file you are missing the CONFIG_TI_ST config which builds the TI's shared transport driver upon which the FM driver works. >> >> Please select this config in drivers/misc/ti-st/Kconfig which will solve the problem. > Wrong answer. > > The problem seems to be that GPIOLIB is not enabled, but wl128x Kconfig says: > > config RADIO_WL128X > tristate "Texas Instruments WL128x FM Radio" > depends on VIDEO_V4L2&& RFKILL > select TI_ST if NET&& GPIOLIB > > so TI_ST is not selected here. > > The Kconfig files should handle this properly. > > Here is one possible fix for you to consider. > > --- > From: Randy Dunlap<rdunlap@xenotime.net> > > Fix build errors when GPIOLIB is not enabled. > Fix wl128x Kconfig to depend on GPIOLIB since TI_ST also > depends on GPIOLIB. > > (.text+0xe6d60): undefined reference to `st_register' > (.text+0xe7016): undefined reference to `st_unregister' > (.text+0xe70ce): undefined reference to `st_unregister' > > Signed-off-by: Randy Dunlap<rdunlap@xenotime.net> > Cc: Manjunatha Halli<manjunatha_halli@ti.com> > --- > drivers/media/radio/wl128x/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-next-20120202.orig/drivers/media/radio/wl128x/Kconfig > +++ linux-next-20120202/drivers/media/radio/wl128x/Kconfig > @@ -4,8 +4,8 @@ > menu "Texas Instruments WL128x FM driver (ST based)" > config RADIO_WL128X > tristate "Texas Instruments WL128x FM Radio" > - depends on VIDEO_V4L2&& RFKILL > - select TI_ST if NET&& GPIOLIB > + depends on VIDEO_V4L2&& RFKILL&& GPIOLIB > + select TI_ST if NET > help > Choose Y here if you have this FM radio chip. > > >> Regards >> Manju >> >> On 02/02/2012 12:07 PM, Randy Dunlap wrote: >>> On 02/01/2012 07:45 PM, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20120201: >>> drivers/built-in.o: In function `fmc_prepare': >>> (.text+0xe6d60): undefined reference to `st_register' >>> drivers/built-in.o: In function `fmc_prepare': >>> (.text+0xe7016): undefined reference to `st_unregister' >>> drivers/built-in.o: In function `fmc_release': >>> (.text+0xe70ce): undefined reference to `st_unregister' >>> >>> >>> Full randconfig file is attached. > This solutions seems fine for me... My only concern is since TI_ST is already have GPIOLIB in its dependency list is it OK to have the same thing in FM driver also?. Manju -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/02/2012 10:20 AM, Manjunatha Halli wrote: > On 02/02/2012 12:40 PM, Randy Dunlap wrote: >> On 02/02/2012 09:20 AM, Manjunatha Halli wrote: >>> Hi Randy Dunlap, >>> >>> In config file you are missing the CONFIG_TI_ST config which builds the TI's shared transport driver upon which the FM driver works. >>> >>> Please select this config in drivers/misc/ti-st/Kconfig which will solve the problem. >> Wrong answer. >> >> The problem seems to be that GPIOLIB is not enabled, but wl128x Kconfig says: >> >> config RADIO_WL128X >> tristate "Texas Instruments WL128x FM Radio" >> depends on VIDEO_V4L2&& RFKILL >> select TI_ST if NET&& GPIOLIB >> >> so TI_ST is not selected here. >> >> The Kconfig files should handle this properly. >> >> Here is one possible fix for you to consider. >> >> --- >> From: Randy Dunlap<rdunlap@xenotime.net> >> >> Fix build errors when GPIOLIB is not enabled. >> Fix wl128x Kconfig to depend on GPIOLIB since TI_ST also >> depends on GPIOLIB. >> >> (.text+0xe6d60): undefined reference to `st_register' >> (.text+0xe7016): undefined reference to `st_unregister' >> (.text+0xe70ce): undefined reference to `st_unregister' >> >> Signed-off-by: Randy Dunlap<rdunlap@xenotime.net> >> Cc: Manjunatha Halli<manjunatha_halli@ti.com> >> --- >> drivers/media/radio/wl128x/Kconfig | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> --- linux-next-20120202.orig/drivers/media/radio/wl128x/Kconfig >> +++ linux-next-20120202/drivers/media/radio/wl128x/Kconfig >> @@ -4,8 +4,8 @@ >> menu "Texas Instruments WL128x FM driver (ST based)" >> config RADIO_WL128X >> tristate "Texas Instruments WL128x FM Radio" >> - depends on VIDEO_V4L2&& RFKILL >> - select TI_ST if NET&& GPIOLIB >> + depends on VIDEO_V4L2&& RFKILL&& GPIOLIB >> + select TI_ST if NET >> help >> Choose Y here if you have this FM radio chip. >> >> >>> Regards >>> Manju >>> >>> On 02/02/2012 12:07 PM, Randy Dunlap wrote: >>>> On 02/01/2012 07:45 PM, Stephen Rothwell wrote: >>>>> Hi all, >>>>> >>>>> Changes since 20120201: >>>> drivers/built-in.o: In function `fmc_prepare': >>>> (.text+0xe6d60): undefined reference to `st_register' >>>> drivers/built-in.o: In function `fmc_prepare': >>>> (.text+0xe7016): undefined reference to `st_unregister' >>>> drivers/built-in.o: In function `fmc_release': >>>> (.text+0xe70ce): undefined reference to `st_unregister' >>>> >>>> >>>> Full randconfig file is attached. >> > > This solutions seems fine for me... > > My only concern is since TI_ST is already have GPIOLIB in its dependency list is it OK to have the same thing in FM driver also?. Sure, it's OK.
--- linux-next-20120202.orig/drivers/media/radio/wl128x/Kconfig +++ linux-next-20120202/drivers/media/radio/wl128x/Kconfig @@ -4,8 +4,8 @@ menu "Texas Instruments WL128x FM driver (ST based)" config RADIO_WL128X tristate "Texas Instruments WL128x FM Radio" - depends on VIDEO_V4L2 && RFKILL - select TI_ST if NET && GPIOLIB + depends on VIDEO_V4L2 && RFKILL && GPIOLIB + select TI_ST if NET help Choose Y here if you have this FM radio chip.