Siano DVB USB device called "Smart Plus"

Message ID CACGt9ymVoDWyG8rt3psCT-PmZ7zeB_8YTjv5ZZQ-2Mx2-pteag@mail.gmail.com (mailing list archive)
State RFC, archived
Headers

Commit Message

Denilson Figueiredo de Sá Jan. 20, 2012, 4:34 a.m. UTC
  On Thu, Jan 19, 2012 at 12:42, Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
>
> From the product page, it is a 1-seg device. So, it likely uses a sms1xxx
> chip.

Correct, Siano SMS1140.

> You'll likely need to add a new board entry there for it, and discover
> the GPIO pins linked to the leds and infrared (the numbers for .board_cfg
> and .led* on the above data structure). You can do it by either sniffing
> the USB board traffic or by opening the device and carefully examining the
> board tracks.

I've added two photos of the circuit here:
http://linuxtv.org/wiki/index.php/Smart_Plus

Considering there are these lines at sms-usb.c:
        { USB_DEVICE(0x187f, 0x0202),
                .driver_info = SMS1XXX_BOARD_SIANO_NICE },

I thought I didn't need to add a new board entry, just update the
current one. Then I added a few lines, as shown below, but it seems
the driver still tries to load "dvb_nova_12mhz_b0.inp" instead of
"isdbt_nova_12mhz_b0.inp".

If I rename (or symlink) the firmware file, the driver loads the
firmware. After smsdvb module gets loaded, then there is a /dev/dvb/
entry for my device, but still the programs I tried (w_scan and vlc)
don't find any channels.


About the GPIO pins: even on Windows, the only LED from this device
does not blink. So I don't care about LED feedback. Also, right now
I'm not worried about IR remote, so I'm leaving that out.

Anyway, I can supply some usb logs if they would help debugging this.
  

Comments

Mauro Carvalho Chehab Jan. 20, 2012, 10:01 a.m. UTC | #1
Em 20-01-2012 02:34, Denilson Figueiredo de Sá escreveu:
> On Thu, Jan 19, 2012 at 12:42, Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
>>
>> From the product page, it is a 1-seg device. So, it likely uses a sms1xxx
>> chip.
> 
> Correct, Siano SMS1140.
> 
>> You'll likely need to add a new board entry there for it, and discover
>> the GPIO pins linked to the leds and infrared (the numbers for .board_cfg
>> and .led* on the above data structure). You can do it by either sniffing
>> the USB board traffic or by opening the device and carefully examining the
>> board tracks.
> 
> I've added two photos of the circuit here:
> http://linuxtv.org/wiki/index.php/Smart_Plus
> 
> Considering there are these lines at sms-usb.c:
>         { USB_DEVICE(0x187f, 0x0202),
>                 .driver_info = SMS1XXX_BOARD_SIANO_NICE },
> 
> I thought I didn't need to add a new board entry, just update the
> current one.

You may need to add it anyway, as the device may not be equal to
Siano Nice reference board.

> Then I added a few lines, as shown below, but it seems
> the driver still tries to load "dvb_nova_12mhz_b0.inp" instead of
> "isdbt_nova_12mhz_b0.inp".

No. there's a parameter for the smsmdtv module to select the right
standard:

drivers/media/dvb/siano/smscoreapi.c:module_param(default_mode, int, 0644);

You need to pass "default_mode=6" for ISDB-T to work. Just renaming
the firmware won't work. Of course, the firmware name entry needs to be
filled.

Btw, adding both firmwares work, as the same device can likely be used
in Europe with DVB-T. So, maybe we can add some parameter there to specify
the default mode. Not sure if such change would be easy though.

> 
> If I rename (or symlink) the firmware file, the driver loads the
> firmware. After smsdvb module gets loaded, then there is a /dev/dvb/
> entry for my device, but still the programs I tried (w_scan and vlc)
> don't find any channels.
> 
> 
> About the GPIO pins: even on Windows, the only LED from this device
> does not blink. So I don't care about LED feedback. Also, right now
> I'm not worried about IR remote, so I'm leaving that out.
> 
> Anyway, I can supply some usb logs if they would help debugging this.
> 
> 
> --- sms-cards.c.orig    2012-01-20 00:42:47.000000000 -0200
> +++ sms-cards.c 2012-01-20 01:05:11.000000000 -0200
> @@ -92,6 +92,8 @@
>         /* 11 */
>                 .name = "Siano Nice Digital Receiver",
>                 .type = SMS_NOVA_B0,
> +               .fw[DEVICE_MODE_ISDBT_BDA] = "isdbt_nova_12mhz_b0.inp",
> +               .rc_codes = RC_MAP_HAUPPAUGE,
>         },
>         [SMS1XXX_BOARD_SIANO_VENICE] = {
>         /* 12 */
> @@ -299,6 +301,7 @@
>         case SMS1XXX_BOARD_HAUPPAUGE_WINDHAM:
>         case SMS1XXX_BOARD_HAUPPAUGE_TIGER_MINICARD:
>         case SMS1XXX_BOARD_HAUPPAUGE_TIGER_MINICARD_R2:
> +       case SMS1XXX_BOARD_SIANO_NICE:
>                 request_module("smsdvb");
>                 break;
>         default:
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  
Denilson Figueiredo de Sá Jan. 21, 2012, 1:38 p.m. UTC | #2
On Fri, Jan 20, 2012 at 08:01, Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
>
>> Then I added a few lines, as shown below, but it seems
>> the driver still tries to load "dvb_nova_12mhz_b0.inp" instead of
>> "isdbt_nova_12mhz_b0.inp".
>
> No. there's a parameter for the smsmdtv module to select the right
> standard:
>
> drivers/media/dvb/siano/smscoreapi.c:module_param(default_mode, int, 0644);
>
> You need to pass "default_mode=6" for ISDB-T to work. Just renaming
> the firmware won't work. Of course, the firmware name entry needs to be
> filled.

Okay, I did:
modprobe smsmdtv default_mode=6
Now it loads the correct firmware. But, still, neither vlc nor w_scan
can find any channels.

I bet it requires deeper debugging and more knowledge than what I have now.
  

Patch

--- sms-cards.c.orig    2012-01-20 00:42:47.000000000 -0200
+++ sms-cards.c 2012-01-20 01:05:11.000000000 -0200
@@ -92,6 +92,8 @@ 
        /* 11 */
                .name = "Siano Nice Digital Receiver",
                .type = SMS_NOVA_B0,
+               .fw[DEVICE_MODE_ISDBT_BDA] = "isdbt_nova_12mhz_b0.inp",
+               .rc_codes = RC_MAP_HAUPPAUGE,
        },
        [SMS1XXX_BOARD_SIANO_VENICE] = {
        /* 12 */
@@ -299,6 +301,7 @@ 
        case SMS1XXX_BOARD_HAUPPAUGE_WINDHAM:
        case SMS1XXX_BOARD_HAUPPAUGE_TIGER_MINICARD:
        case SMS1XXX_BOARD_HAUPPAUGE_TIGER_MINICARD_R2:
+       case SMS1XXX_BOARD_SIANO_NICE:
                request_module("smsdvb");
                break;
        default: