diff mbox

[RESEND,v9,1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

Message ID 1525276428-17379-2-git-send-email-andy.yeh@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Yeh, Andy May 2, 2018, 3:53 p.m. UTC 
  From: Alan Chiang <alanx.chiang@intel.com>

Dongwoon DW9807 is a voice coil lens driver.

Signed-off-by: Andy Yeh <andy.yeh@intel.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Acked-by: Rob Herring <robh@kernel.org>

---
 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 +++++++++
 1 file changed, 9 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt

Comments

Sakari Ailus May 2, 2018, 9:36 p.m. UTC | #1 
On Wed, May 02, 2018 at 11:53:47PM +0800, Andy Yeh wrote:
> From: Alan Chiang <alanx.chiang@intel.com>
> 
> Dongwoon DW9807 is a voice coil lens driver.
> 
> Signed-off-by: Andy Yeh <andy.yeh@intel.com>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Tomasz Figa <tfiga@chromium.org>
> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

I don't remember seeing these two on the first patch nor giving mine. For
what it's worth, I've applied v8 to my tree here:

<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=for-4.18-3>

I.e. there's no need to resend the same patch to just add the regular
acked-by or reviewed-by tags. "RESEND" in the subject suggests you're
sending exactly the same patch, and in that case the version would be
unchanged as well.

> Acked-by: Rob Herring <robh@kernel.org>
> 
> ---
>  Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 +++++++++
>  1 file changed, 9 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
> new file mode 100644
> index 0000000..0a1a860
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
> @@ -0,0 +1,9 @@
> +Dongwoon Anatech DW9807 voice coil lens driver
> +
> +DW9807 is a 10-bit DAC with current sink capability. It is intended for
> +controlling voice coil lenses.
> +
> +Mandatory properties:
> +
> +- compatible: "dongwoon,dw9807"
> +- reg: I2C slave address
Yeh, Andy May 3, 2018, 7:31 a.m. UTC | #2 
Hi Sakari,

Thanks to add to your tree. And I am not familiar with the process. So I wonder how the patchset will be applied to the Linux media tree eventually?

Regards, Andy

-----Original Message-----
From: Sakari Ailus [mailto:sakari.ailus@linux.intel.com] 
Sent: Thursday, May 3, 2018 5:37 AM
To: Yeh, Andy <andy.yeh@intel.com>
Cc: linux-media@vger.kernel.org; devicetree@vger.kernel.org; tfiga@chromium.org; jacopo@jmondi.org; Chiang, AlanX <alanx.chiang@intel.com>
Subject: Re: [RESEND PATCH v9 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

On Wed, May 02, 2018 at 11:53:47PM +0800, Andy Yeh wrote:
> From: Alan Chiang <alanx.chiang@intel.com>
> 
> Dongwoon DW9807 is a voice coil lens driver.
> 
> Signed-off-by: Andy Yeh <andy.yeh@intel.com>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Tomasz Figa <tfiga@chromium.org>
> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

I don't remember seeing these two on the first patch nor giving mine. For what it's worth, I've applied v8 to my tree here:

<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=for-4.18-3>

I.e. there's no need to resend the same patch to just add the regular acked-by or reviewed-by tags. "RESEND" in the subject suggests you're sending exactly the same patch, and in that case the version would be unchanged as well.

> Acked-by: Rob Herring <robh@kernel.org>
> 
> ---
>  Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 
> +++++++++
>  1 file changed, 9 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt 
> b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
> new file mode 100644
> index 0000000..0a1a860
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
> @@ -0,0 +1,9 @@
> +Dongwoon Anatech DW9807 voice coil lens driver
> +
> +DW9807 is a 10-bit DAC with current sink capability. It is intended 
> +for controlling voice coil lenses.
> +
> +Mandatory properties:
> +
> +- compatible: "dongwoon,dw9807"
> +- reg: I2C slave address

--
Sakari Ailus
sakari.ailus@linux.intel.com
Yeh, Andy May 8, 2018, 5:36 a.m. UTC | #3 
Dear reviewers,

As the dt-binding patch has been accepted, would any help set the driver patch be accepted too? Any missing action from my side blocked the process. Thanks in advance. 

media: dw9807: Add dw9807 vcm driver
https://patchwork.linuxtv.org/patch/49159/

Regards, Andy

-----Original Message-----
From: Sakari Ailus [mailto:sakari.ailus@linux.intel.com] 
Sent: Thursday, May 3, 2018 5:37 AM
To: Yeh, Andy <andy.yeh@intel.com>
Cc: linux-media@vger.kernel.org; devicetree@vger.kernel.org; tfiga@chromium.org; jacopo@jmondi.org; Chiang, AlanX <alanx.chiang@intel.com>
Subject: Re: [RESEND PATCH v9 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

On Wed, May 02, 2018 at 11:53:47PM +0800, Andy Yeh wrote:
> From: Alan Chiang <alanx.chiang@intel.com>
> 
> Dongwoon DW9807 is a voice coil lens driver.
> 
> Signed-off-by: Andy Yeh <andy.yeh@intel.com>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Tomasz Figa <tfiga@chromium.org>
> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

I don't remember seeing these two on the first patch nor giving mine. For what it's worth, I've applied v8 to my tree here:

<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=for-4.18-3>

I.e. there's no need to resend the same patch to just add the regular acked-by or reviewed-by tags. "RESEND" in the subject suggests you're sending exactly the same patch, and in that case the version would be unchanged as well.

> Acked-by: Rob Herring <robh@kernel.org>
> 
> ---
>  Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 
> +++++++++
>  1 file changed, 9 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt 
> b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
> new file mode 100644
> index 0000000..0a1a860
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
> @@ -0,0 +1,9 @@
> +Dongwoon Anatech DW9807 voice coil lens driver
> +
> +DW9807 is a 10-bit DAC with current sink capability. It is intended 
> +for controlling voice coil lenses.
> +
> +Mandatory properties:
> +
> +- compatible: "dongwoon,dw9807"
> +- reg: I2C slave address

--
Sakari Ailus
sakari.ailus@linux.intel.com
Hello,

The following patches (submitted by you) have been updated in patchwork:

 * linux-media: [RESEND,v8,1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil
     - http://patchwork.linuxtv.org/patch/49028/
     - for: Linux Media kernel patches
    was: New
    now: Accepted

 * linux-media: [RESEND,v9,1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil
     - http://patchwork.linuxtv.org/patch/49158/
     - for: Linux Media kernel patches
    was: New
    now: Accepted

 * linux-media: RESEND[PATCH v6 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil
     - http://patchwork.linuxtv.org/patch/47979/
     - for: Linux Media kernel patches
    was: New
    now: Accepted

This email is a notification only - you do not need to respond.

-

Patches submitted to linux-media@vger.kernel.org have the following
possible states:

New: Patches not yet reviewed (typically new patches);

Under review: When it is expected that someone is reviewing it (typically,
              the driver's author or maintainer). Unfortunately, patchwork
              doesn't have a field to indicate who is the driver maintainer.
              If in doubt about who is the driver maintainer please check the
              MAINTAINERS file or ask at the ML;

Superseded: when the same patch is sent twice, or a new version of the
            same patch is sent, and the maintainer identified it, the first
            version is marked as such. It is also used when a patch was
            superseeded by a git pull request.

Obsoleted: patch doesn't apply anymore, because the modified code doesn't
           exist anymore.

Changes requested: when someone requests changes of the patch;

Rejected: When the patch is wrong or doesn't apply. Most of the
          time, 'rejected' and 'changes requested' means the same thing
          for the developer: he'll need to re-work on the patch.

RFC: patches marked as such and other patches that are also RFC, but the
     patch author was not nice enough to mark them as such. That includes:
        - patches sent by a driver's maintainer who send patches
          via git pull requests;
        - patches with a very active community (typically from developers
          working with embedded devices), where lots of versions are
          needed for the driver maintainer and/or the community to be
          happy with.

TODO: A variant of RFC. It keeps the patch visible at patchwork main
        screen, allowing to better track it.

Not Applicable: for patches that aren't meant to be applied via
                the media-tree.git.

Accepted: when some driver maintainer says that the patch will be applied
          via his tree, or when everything is ok and it got applied
          either at the main tree or via some other tree (fixes tree;
          some other maintainer's tree - when it belongs to other subsystems,
          etc);

If you think any status change is a mistake, please send an email to the ML.

-

This is an automated mail sent by the patchwork system at
patchwork.linuxtv.org. To stop receiving these notifications, edit
your mail settings at:
  http://patchwork.linuxtv.org/mail/
Sakari Ailus May 8, 2018, 9:02 a.m. UTC | #4 
On Tue, May 08, 2018 at 05:36:48AM +0000, Yeh, Andy wrote:
> Dear reviewers,
> 
> As the dt-binding patch has been accepted, would any help set the driver patch be accepted too? Any missing action from my side blocked the process. Thanks in advance. 
> 
> media: dw9807: Add dw9807 vcm driver
> https://patchwork.linuxtv.org/patch/49159/

The patchwork status was wrong and I've fixed it now; the patches
themselves are contained in a pull request to Mauro here:

<URL:https://www.spinics.net/lists/linux-media/msg133734.html>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
new file mode 100644
index 0000000..0a1a860
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
@@ -0,0 +1,9 @@ 
+Dongwoon Anatech DW9807 voice coil lens driver
+
+DW9807 is a 10-bit DAC with current sink capability. It is intended for
+controlling voice coil lenses.
+
+Mandatory properties:
+
+- compatible: "dongwoon,dw9807"
+- reg: I2C slave address